appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: update settings pane validations

Open eco-monk opened this issue 2 years ago • 15 comments

Description

TL;DR -> Updated validation logic for fields in settings pane.

App name - all characters are allowed now (shouldn’t be empty) Page name - alphanumeric and accented characters are allowed (shouldn’t be empty), cannot use other entities name or any global keyword. Custom slug - alphanumeric and "-” are allowed (can be empty)

Fixes #18698

Media https://www.loom.com/share/64c488e2fc9f4a44802b10bfb3ccac84

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

eco-monk avatar Dec 07 '22 07:12 eco-monk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 10, 2022 at 11:33AM (UTC)

vercel[bot] avatar Dec 07 '22 07:12 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 07 '22 07:12 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 15 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Dec 07 '22 12:12 vercel[bot]

/ok-to-test sha=f61355a

eco-monk avatar Dec 08 '22 09:12 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3646873873. Workflow: Appsmith External Integration Test Workflow. Commit: f61355a. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3646873873_1

github-actions[bot] avatar Dec 08 '22 09:12 github-actions[bot]

/ok-to-test sha=25393dd

eco-monk avatar Dec 08 '22 10:12 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3647484647. Workflow: Appsmith External Integration Test Workflow. Commit: 25393dd. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3647484647_1

github-actions[bot] avatar Dec 08 '22 10:12 github-actions[bot]

/ok-to-test sha=5ff5466

eco-monk avatar Dec 08 '22 12:12 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3648224050. Workflow: Appsmith External Integration Test Workflow. Commit: 5ff5466. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3648224050_1

github-actions[bot] avatar Dec 08 '22 12:12 github-actions[bot]

/ok-to-test sha=f109d44

eco-monk avatar Dec 09 '22 04:12 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3654448259. Workflow: Appsmith External Integration Test Workflow. Commit: f109d44. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3654448259_1

github-actions[bot] avatar Dec 09 '22 04:12 github-actions[bot]

/ok-to-test sha=ac5080f

eco-monk avatar Dec 09 '22 07:12 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655463033. Workflow: Appsmith External Integration Test Workflow. Commit: ac5080f. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3655463033_1

github-actions[bot] avatar Dec 09 '22 07:12 github-actions[bot]

/ok-to-test sha=d867400

Aishwarya-U-R avatar Dec 09 '22 17:12 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3659441971. Workflow: Appsmith External Integration Test Workflow. Commit: d867400. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3659441971_1

github-actions[bot] avatar Dec 09 '22 17:12 github-actions[bot]

/ok-to-test sha=59b066b

Aishwarya-U-R avatar Dec 09 '22 18:12 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3659922487. Workflow: Appsmith External Integration Test Workflow. Commit: 59b066b. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3659922487_1

github-actions[bot] avatar Dec 09 '22 18:12 github-actions[bot]

/ok-to-test sha=78468c4

Aishwarya-U-R avatar Dec 10 '22 06:12 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3663113956. Workflow: Appsmith External Integration Test Workflow. Commit: 78468c4. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3663113956_1

github-actions[bot] avatar Dec 10 '22 06:12 github-actions[bot]

/ok-to-test sha=78468c4

Aishwarya-U-R avatar Dec 10 '22 08:12 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3663331895. Workflow: Appsmith External Integration Test Workflow. Commit: 78468c4. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3663331895_1

github-actions[bot] avatar Dec 10 '22 08:12 github-actions[bot]

/ok-to-test sha=0adee85

Aishwarya-U-R avatar Dec 10 '22 11:12 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3663980044. Workflow: Appsmith External Integration Test Workflow. Commit: 0adee85. PR: 18739. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18739&runId=3663980044_1

github-actions[bot] avatar Dec 10 '22 11:12 github-actions[bot]