appsmith
appsmith copied to clipboard
fix: Add error message for protected branch
Description
When a git push is failed due to reasons other than upstream changes like a protected branch, the application displays there are upstream changes which is not correct. This PR adds a error message when the git push operation fails due to the protected branch rule.
Add a TL;DR when description is extra long (helps content team)
Fixes #15347
Media
A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
Type of change
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
Test Plan
Add Testsmith test cases links that relate to this PR
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ⬜️ Ignored (Inspect) | Dec 12, 2022 at 11:13AM (UTC) |
Unable to find test scripts. Please add necessary tests to the PR.
/ok-to-test sha=f7042ff
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3667775438.
Workflow: Appsmith External Integration Test Workflow.
Commit: f7042ff.
PR: 18737.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18737&runId=3667775438_1
/ok-to-test sha=60241f6
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3675220359.
Workflow: Appsmith External Integration Test Workflow.
Commit: 60241f6.
PR: 18737.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18737&runId=3675220359_1
/ok-to-test sha=60241f6
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3701543067.
Workflow: Appsmith External Integration Test Workflow.
Commit: 60241f6.
PR: 18737.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18737&runId=3701543067_1
/perf-test sha=60241f6
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3705566928.
Workflow: Performance Tests Workflow.
Commit: 60241f6.
PR: 18737.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18737&runId=3705566928_1