appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Return undefined for nonexistent action headers

Open Irongade opened this issue 3 years ago • 4 comments

This issue occurs when users switch the datasource of an API action, and the actionConfiguration headers is empty. This PR adds conditional checks to prevent an error from happening.

Fixes #18682

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

Irongade avatar Dec 06 '22 12:12 Irongade

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 0:36AM (UTC)

vercel[bot] avatar Dec 06 '22 12:12 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 06 '22 12:12 github-actions[bot]

/ok-to-test sha=b64ff45

Irongade avatar Dec 07 '22 12:12 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3639046656. Workflow: Appsmith External Integration Test Workflow. Commit: b64ff45. PR: 18724. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18724&runId=3639046656_1

github-actions[bot] avatar Dec 07 '22 12:12 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Dec 14 '22 16:12 github-actions[bot]

This PR has been closed because of inactivity.

github-actions[bot] avatar Dec 27 '22 16:12 github-actions[bot]