appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: discard popup for gsheet updates

Open sneha122 opened this issue 2 years ago • 6 comments

Description

For a GSheet DS, Add a ds & click on back.. In the pop-up when alerted to save - click on save.. User is taken to Authorise the sheet also, Hence this "save" button text is replaced with "save and authorize" in case of Google sheet datasource.

This PR also contains cypress improvements mentioned by @Parthvi12. https://github.com/appsmithorg/appsmith/pull/18690

Add a TL;DR when description is extra long (helps content team)

Fixes #18035

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

sneha122 avatar Dec 06 '22 08:12 sneha122

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 4:01PM (UTC)

vercel[bot] avatar Dec 06 '22 08:12 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 06 '22 08:12 github-actions[bot]

/ok-to-test sha=c749408

sneha122 avatar Dec 07 '22 06:12 sneha122

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 07 '22 06:12 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3636337596. Workflow: Appsmith External Integration Test Workflow. Commit: c749408. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3636337596_1

github-actions[bot] avatar Dec 07 '22 06:12 github-actions[bot]

@sneha122

  1. Consider the user has Auth for "Read files" and then goes back and edit on the scope. What is the expectation here should the user re - Authorise this cc : @rohan-arthur @parth-appsmith
  2. [BUG] : Once the datasource is Authorised the Pop up must have button as Save and Re-Authorise. Currently we are displaying it as Save and Authorise.

prapullac avatar Dec 08 '22 12:12 prapullac

@sneha122

  1. Consider the user has Auth for "Read files" and then goes back and edit on the scope. What is the expectation here should the user re - Authorise this cc : @rohan-arthur @parth-appsmith
  2. [BUG] : Once the datasource is Authorised the Pop up must have button as Save and Re-Authorise. Currently we are displaying it as Save and Authorise.

@prapullac This bug has been fixed. While fixing this bug, I found that when we create gsheet datasource, save and authorize it, Now after editing this same datasource and changing the scope should ideally make the datasource form dirty and on click of back button it should show discard popup, but it was not showing discard popup, I have fixed that bug as well. Please check that as well. Note: It happens only when I open gsheet datasource for editing from entity explorer

sneha122 avatar Dec 13 '22 09:12 sneha122

/ok-to-test sha=184e4b4

sneha122 avatar Dec 13 '22 09:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3684008743. Workflow: Appsmith External Integration Test Workflow. Commit: 184e4b4. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3684008743_1

github-actions[bot] avatar Dec 13 '22 09:12 github-actions[bot]

/ok-to-test sha=3393cc1

sneha122 avatar Dec 14 '22 10:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3693978591. Workflow: Appsmith External Integration Test Workflow. Commit: 3393cc1. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3693978591_1

github-actions[bot] avatar Dec 14 '22 10:12 github-actions[bot]

/ok-to-test sha=57cf6c2

sneha122 avatar Dec 14 '22 10:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3694107233. Workflow: Appsmith External Integration Test Workflow. Commit: 57cf6c2. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3694107233_1

github-actions[bot] avatar Dec 14 '22 10:12 github-actions[bot]

/ok-to-test sha=e9e87dc

sneha122 avatar Dec 15 '22 07:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3702147568. Workflow: Appsmith External Integration Test Workflow. Commit: e9e87dc. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3702147568_1

github-actions[bot] avatar Dec 15 '22 07:12 github-actions[bot]

@sneha122

  1. Consider the user has Auth for "Read files" and then goes back and edit on the scope. What is the expectation here should the user re - Authorise this cc : @rohan-arthur @parth-appsmith
  2. [BUG] : Once the datasource is Authorised the Pop up must have button as Save and Re-Authorise. Currently we are displaying it as Save and Authorise.

@prapullac This bug has been fixed. While fixing this bug, I found that when we create gsheet datasource, save and authorize it, Now after editing this same datasource and changing the scope should ideally make the datasource form dirty and on click of back button it should show discard popup, but it was not showing discard popup, I have fixed that bug as well. Please check that as well. Note: It happens only when I open gsheet datasource for editing from entity explorer

@prapullac Tracking this issue in #18982

sneha122 avatar Dec 15 '22 14:12 sneha122

/ok-to-test sha=2dc61ee

sneha122 avatar Dec 15 '22 14:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3704955389. Workflow: Appsmith External Integration Test Workflow. Commit: 2dc61ee. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3704955389_1

github-actions[bot] avatar Dec 15 '22 14:12 github-actions[bot]

/ok-to-test sha=c523faa

sneha122 avatar Dec 15 '22 14:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3705135512. Workflow: Appsmith External Integration Test Workflow. Commit: c523faa. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3705135512_1

github-actions[bot] avatar Dec 15 '22 14:12 github-actions[bot]

/ok-to-test sha=9052ff4

sneha122 avatar Dec 16 '22 08:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3711395168. Workflow: Appsmith External Integration Test Workflow. Commit: 9052ff4. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3711395168_1

github-actions[bot] avatar Dec 16 '22 08:12 github-actions[bot]

/ok-to-test sha=950aa80

sneha122 avatar Dec 16 '22 10:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3712468205. Workflow: Appsmith External Integration Test Workflow. Commit: 950aa80. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3712468205_1

github-actions[bot] avatar Dec 16 '22 10:12 github-actions[bot]

/ok-to-test sha=673e66e

sneha122 avatar Dec 17 '22 15:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3720631652. Workflow: Appsmith External Integration Test Workflow. Commit: 673e66e. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3720631652_1

github-actions[bot] avatar Dec 17 '22 15:12 github-actions[bot]

/perf-test

sneha122 avatar Dec 20 '22 06:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3738163362. Workflow: Performance Tests Workflow. Commit: ``. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3738163362_1

github-actions[bot] avatar Dec 20 '22 06:12 github-actions[bot]

/ok-to-test sha=d8f6d12

sneha122 avatar Dec 21 '22 05:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3746751626. Workflow: Appsmith External Integration Test Workflow. Commit: d8f6d12. PR: 18719. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18719&runId=3746751626_1

github-actions[bot] avatar Dec 21 '22 05:12 github-actions[bot]