fix: no feedback when user denied permission on watchPosition

[ravikp7]

Description

This fixes an issue where no feedback was being shown to a user when the user denied location permissions. This happened only when no callback function was provided.

Fixes #18678

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] PR is being merged under a feature flag

QA activity:

• [ ] Test plan has been approved by relevant developers
• [ ] Test plan has been peer reviewed by QA
• [ ] Cypress test cases have been added and approved by either SDET or manual QA
• [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
• [ ] Added Test Plan Approved label after reveiwing all Cypress test

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Dec 20, 2022 at 9:58AM (UTC)

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[ravikp7]

/ok-to-test sha=2fd5c4858a0810bbeb032f06c25db32e1b302352

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3628456453. Workflow: Appsmith External Integration Test Workflow. Commit: 2fd5c4858a0810bbeb032f06c25db32e1b302352. PR: 18712. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18712&runId=3628456453_1

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[AnandiKulkarni]

@ravikp7 Verified the bug. Only part with with .then it does not work where messages such as user has denied and watch is already running is not displayed watchposition2: ()=>{

	appsmith.geolocation.watchPosition().then(()=>{
		console.log('hi')
		showAlert('clearded the watch')
	})

},

Defect attached to above issue #18713 [Bug]: getCurrentPosition not showing error correctly when no callback is passed

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[ravikp7]

not valid anymore