appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

ci: Ship source maps + fix perf test failures on EE

Open SatishGandham opened this issue 3 years ago • 14 comments

Description

  • Perf tests were failing on EE because the EE license key was not available.
  • Delete source maps only on EE
  • Remove the wait for the server to start, instead install the performance infra dependencies in that time.

Fixes #18687 #18688

Type of change

Non breaking change to CI

How Has This Been Tested?

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

SatishGandham avatar Dec 05 '22 13:12 SatishGandham

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Dec 6, 2022 at 7:00AM (UTC)

vercel[bot] avatar Dec 05 '22 13:12 vercel[bot]

/perf-test

SatishGandham avatar Dec 05 '22 13:12 SatishGandham

/perf-test

SatishGandham avatar Dec 06 '22 03:12 SatishGandham

/perf-test

SatishGandham avatar Dec 06 '22 04:12 SatishGandham

/perf-test

SatishGandham avatar Dec 06 '22 06:12 SatishGandham

/ok-to-test

SatishGandham avatar Dec 06 '22 10:12 SatishGandham

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3628578399. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 18700. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18700&runId=3628578399_1

github-actions[bot] avatar Dec 06 '22 10:12 github-actions[bot]

/perf-test ref=rhito/check-for-prev-runs

Rhitottam avatar Dec 06 '22 14:12 Rhitottam