appsmith
appsmith copied to clipboard
appsmithorg
[Bug]: Error is displayed for page name which does not have special character
Is there an existing issue for this?
- [X] I have searched the existing issues
Description
Add the special character to the page name, Verify it displays error, Click on other page which has right page name, Error is displayed for that page
Steps To Reproduce
- Click on '...' and setting for page1
- Change the page name as page1_123
- Error is displayed as only alphanumeric values are allowed
- Click on page2 and verify error is displayed for Page2
Public Sample App
No response
Issue video log
No response
Version
cloud-release
I believe this is caused by #17393. Will investigate this to see if there are any workarounds.
@eco-monk Error messages should be cleared when we open a new page's setting
@eco-monk this error message doesn't look good and taking space down. Not sure if design is discussed.
@AnandiKulkarni, we're using design system error messages for this, so there wasn't much to discuss. It overlays on top of other components. So, We have added space manually for this.
This is already mentioned in #17393. Please add your thoughts to this.
@kocharrahul7 @eco-monk in this case, it should not overlap and push the rest of the components down right? This obviously looks bad
@Nikhil-Nandagopal, we're looking at a combination of two problems here.
- Yes, it ideally should push rest of the components down by default. But it doesn't right now. So, we ended up manually doing this. (maintaining a boolean variable to track error and add padding)
- Plus, In this case the error message shouldn't be shown at all. That's the other part where the design-system component doesn't clear the error message.
What's happening here is, when page is changed the validations kick-in and the state is set as valid (so, we remove the padding). But the error message is not getting cleared from the input component.
https://www.loom.com/share/a9af2d33715e4f82b0722ffac1d2fe34
@eco-monk I get the problem, I'm just saying lets fix it. We don't have to wait for the design system team, this seems like a simple component fix that we can contribute to that repo
Thanks @Nikhil-Nandagopal. I thought, design-system was closed for contribution. Since there was nothing mentioned in the main readme.md. Just got to know about this document nested inside. Will use this as reference for future issues I run into.
For now, they've fixed this and it should be ready soon.