appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: query command value from being reset to an empty state

Open Irongade opened this issue 3 years ago • 8 comments

Query form command values are being reset to an empty string whenever you navigate between two different Query actions(with different datasources) for example, Switching between Mongo query and S3 query.

Fixes #18353

  • Bug fix (non-breaking change which fixes an issue)

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

Irongade avatar Nov 29 '22 13:11 Irongade

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 0:40AM (UTC)

vercel[bot] avatar Nov 29 '22 13:11 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 29 '22 13:11 github-actions[bot]

/ok-to-test sha=770c344

Irongade avatar Nov 29 '22 13:11 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3574475122. Workflow: Appsmith External Integration Test Workflow. Commit: 770c344. PR: 18559. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18559&runId=3574475122_1

github-actions[bot] avatar Nov 29 '22 13:11 github-actions[bot]

/ok-to-test sha=e0e276e

Irongade avatar Nov 30 '22 11:11 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3583309619. Workflow: Appsmith External Integration Test Workflow. Commit: e0e276e. PR: 18559. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18559&runId=3583309619_1

github-actions[bot] avatar Nov 30 '22 12:11 github-actions[bot]

/ok-to-test sha=3439ccb

Irongade avatar Dec 05 '22 00:12 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3615824734. Workflow: Appsmith External Integration Test Workflow. Commit: 3439ccb. PR: 18559. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18559&runId=3615824734_1

github-actions[bot] avatar Dec 05 '22 00:12 github-actions[bot]