appsmith
appsmith copied to clipboard
appsmithorg
feat: Adding an upgrade page for Access control
Description
Adding an upgrade page for Access control to help users know about the enterprise feature.
Fixes #18555
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Manually tested the page to work as per designs
- Manual
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Dec 4, 2022 at 11:19AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
Deployment failed with the following error:
Resource is limited - try again in 53 minutes (more than 100, code: "api-deployments-free-per-day").
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3581277550.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9977a52.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3581277550_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3582414078.
Workflow: Appsmith External Integration Test Workflow.
Commit: 10dc90b.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3582414078_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3583103926.
Workflow: Appsmith External Integration Test Workflow.
Commit: fbd3d14.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3583103926_1
Deployment failed with the following error:
Resource is limited - try again in 47 minutes (more than 100, code: "api-deployments-free-per-day").
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3585977631.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8e1a499.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3585977631_1
@IAmAnubhavSaini @berzerkeer
Before: https://www.loom.com/share/2c6cf6b78e6b4ec58d39fd989bb46300
After: https://www.loom.com/share/eb6bad159b4f45c2972de06817d0dfe3
@vinay-appsmith @Debsourabh @vasanth-appsmith what would be your inputs on the same? Let me know if anything is breaking as per the designs due to my changes, or if I should change something here.
This is how it looked on my screen earlier
and this is how it looks now (on this branch)
The right side images were supposed to be pushed to the right as per design, as that was purely a design requirement.
The images have weird borders around them? Are these screenshots instead of exports?
Same before and after for different screen configuration
Before
After
Here it looks okay. I'd say test for different screen sizes and in different browsers.
@IAmAnubhavSaini just pushed a change for fixing the UI on different screen sizes. Regarding images having borders, these images will be getting changed later and we are pushing Access control upgrade page under feature flag right now.
Please merge with correct images. Highlight any blocker in getting the final images.
@IAmAnubhavSaini This was asked by @trishaanand to be merged now with these images and update later as this is behind feature flag anyway.
@trishaanand What is the value we are deriving from it merging today without correct images?
@trishaanand What is the value we are deriving from it merging today without correct images?
@IAmAnubhavSaini : I was of the opinion that as a tech task this can be completed and if there are any changes to the images or content, this can be picked up by anyone at all in the team to do the updates. As this does not impact any user (since its behind feature flag), there is no harm as well.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3590579937.
Workflow: Appsmith External Integration Test Workflow.
Commit: cdedbbe.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3590579937_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3591752511.
Workflow: Appsmith External Integration Test Workflow.
Commit: 67a387d.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3591752511_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3593452411.
Workflow: Appsmith External Integration Test Workflow.
Commit: 67a387d.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3593452411_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3594160248.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6fa4cf5.
PR: 18554.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18554&runId=3594160248_1