appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: Button grouping default value

Open aswathkk opened this issue 3 years ago • 3 comments

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

aswathkk avatar Nov 28 '22 17:11 aswathkk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
appsmith ❌ Failed (Inspect) Mar 6, 2023 at 5:28AM (UTC)

vercel[bot] avatar Nov 28 '22 17:11 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 28 '22 17:11 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Dec 06 '22 16:12 github-actions[bot]

This PR has been closed because of inactivity.

github-actions[bot] avatar Dec 13 '22 16:12 github-actions[bot]

This PR has been closed because of inactivity.

github-actions[bot] avatar Jan 07 '23 16:01 github-actions[bot]

/ok-to-test sha=a28eef6

aswathkk avatar Mar 06 '23 05:03 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4340214612. Workflow: Appsmith External Integration Test Workflow. Commit: a28eef6. PR: 18533. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18533&runId=4340214612_1

github-actions[bot] avatar Mar 06 '23 05:03 github-actions[bot]

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js

github-actions[bot] avatar Mar 06 '23 07:03 github-actions[bot]

/ok-to-test sha=248955b

aswathkk avatar Mar 19 '23 03:03 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4458807297. Workflow: Appsmith External Integration Test Workflow. Commit: 248955b. PR: 18533. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18533&runId=4458807297_1

github-actions[bot] avatar Mar 19 '23 03:03 github-actions[bot]

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List4_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_spec.js

github-actions[bot] avatar Mar 19 '23 05:03 github-actions[bot]

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_spec.js

github-actions[bot] avatar Mar 19 '23 05:03 github-actions[bot]

/ok-to-test sha=643dd94

aswathkk avatar Mar 19 '23 08:03 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4459733617. Workflow: Appsmith External Integration Test Workflow. Commit: 643dd94. PR: 18533. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18533&runId=4459733617_1

github-actions[bot] avatar Mar 19 '23 08:03 github-actions[bot]

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

github-actions[bot] avatar Mar 19 '23 09:03 github-actions[bot]

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

github-actions[bot] avatar Mar 19 '23 10:03 github-actions[bot]

is this fix applicable to buttons/code scanner currently? @aswathkk

kamakshibhat-appsmith avatar Mar 28 '23 13:03 kamakshibhat-appsmith

also, i dont see any DP generated , can you check ? @aswathkk

kamakshibhat-appsmith avatar Mar 28 '23 13:03 kamakshibhat-appsmith

/build-deploy-preview env=release

aswathkk avatar Mar 29 '23 04:03 aswathkk

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4550230048. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 18533.

github-actions[bot] avatar Mar 29 '23 04:03 github-actions[bot]

Deploy-Preview-URL: https://appsmith-ejjnx9buh-get-appsmith.vercel.app

github-actions[bot] avatar Mar 29 '23 04:03 github-actions[bot]

  1. Button group--> Button settings-->Button type : Once you toggle into JS mode and remove the value and toggle back, it is not selecting the default value Screenshot 2023-03-29 at 10 40 34 AM

  2. Same as Case 1 for DIvider widget-->(Style)Direction Screenshot 2023-03-29 at 11 00 41 AM

  3. Menu button-> Menu Items Settings->Position (Nothing is selected by default) Screenshot 2023-03-29 at 11 09 38 AM

  4. table -->Default row height(Style : By default selection not highlighted Screenshot 2023-03-29 at 11 15 36 AM

  5. Same as Case 1 for Table-->Text align/vertical alignment (Style) Screenshot 2023-03-29 at 11 17 10 AM

  6. Same as case 1 for text widget --> ALignment (Style ) Screenshot 2023-03-29 at 11 21 34 AM

kamakshibhat-appsmith avatar Mar 29 '23 05:03 kamakshibhat-appsmith

/build-deploy-preview env=release

aswathkk avatar May 26 '23 15:05 aswathkk

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5092343745. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 18533. recreate: .

github-actions[bot] avatar May 26 '23 15:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-d2qgv7m6s-get-appsmith.vercel.app

github-actions[bot] avatar May 26 '23 15:05 github-actions[bot]

@Sripriya93 : please test the pr

rohitagarwal88 avatar Jun 01 '23 12:06 rohitagarwal88

No ads review required

tanvibhakta avatar Jun 02 '23 02:06 tanvibhakta

  1. All the cases mentioned as same as Case 1 are still happening - If we toggle JS and remove the value and toggle back default value isnt selected
  2. For JSON Form: Reset and Submit button, Border radius and Box Shadow aren't highlighted when selected, but the widget's border is changing

https://github.com/appsmithorg/appsmith/assets/104895602/f49ae027-adac-45e1-b2c6-26b@rohitagarwal88 188ba7

@aswathkk @rohitagarwal88

Sripriya93 avatar Jun 02 '23 14:06 Sripriya93

image

The visibility of the position segment should be hidden when no icons are selected.

@aswathkk @rohitagarwal88

vasanthappsmith avatar Jun 05 '23 11:06 vasanthappsmith

/build-deploy-preview env=release

aswathkk avatar Jun 06 '23 06:06 aswathkk