appsmith
appsmith copied to clipboard
appsmithorg
fix: secret saved indicator on ui for datasource forms
Description
Secret saved indicator on ui exists if the datasource field has a valueExistPath and server sends back the boolean value for the specific field in secretExists key.
The UI would appear as follows :
When the password is saved and there exists a key valueExistPath for Password field and the value in secretExists is true then
-
When password field is not focused. An overlay indicating the password shows up.
-
When the password field is focused. The overlay goes away.
TL;DR
Fixes #14783
Media Loom Video of 4 sec
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
- Manual
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Jan 20, 2023 at 8:00AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3566661054.
Workflow: Appsmith External Integration Test Workflow.
Commit: a53f527.
PR: 18531.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18531&runId=3566661054_1
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3820955451.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18531.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18531&runId=3820955451_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3958629894.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18531.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18531&runId=3958629894_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3965249094.
Workflow: Appsmith External Integration Test Workflow.
Commit: e34091f.
PR: 18531.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18531&runId=3965249094_1