fix: add js for icon property in button group

[iamrkcheers]

Description

Adds JS for icon property in the style section of button group

Fixes #11142

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Manual (verified that the icon property within the style panel of button widget has a JS icon and is JS configured)

Checklist:

Dev activity

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] PR is being merged under a feature flag

QA activity:

• [x] Test plan has been approved by relevant developers
• [x] Test plan has been peer reviewed by QA
• [ ] Cypress test cases have been added and approved by either SDET or manual QA
• [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
• [ ] Added Test Plan Approved label after reveiwing all Cypress test

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Nov 28, 2022 at 11:08AM (UTC)

[iamrkcheers]

/ok-to-test sha=7405c8b

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3564359638. Workflow: Appsmith External Integration Test Workflow. Commit: 7405c8b. PR: 18524. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18524&runId=3564359638_1

[chandannkumar]

Tested this PR and LGTM

• Added JS for icon property in Button Group widget

[somangshu]

@iamrkcheers @Tooluloope would this need any kinda doc change, do we should what properties are JS convertible?

[Tooluloope]

https://docs.appsmith.com/reference/widgets/button-group I didn't see JS convertible on properties in the current doc @somangshu

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[chandannkumar]

Adding test coverage for js editor option for Icon property in Button Group widget https://github.com/appsmithorg/TestSmith/issues/2094

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.