appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: add tooltip property to select widgets

Open iamrkcheers opened this issue 2 years ago • 11 comments

Description

It adds a tooltip property (similar to the one found in input widget) to the following widgets,

  • Select family - select, multi-select, tree-select, multi-tree-select
  • Datepicker

Fixes #18097

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual (verified that tooltip property is added to all of the aforementioned widgets and that it is working as per desired)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

iamrkcheers avatar Nov 28 '22 05:11 iamrkcheers

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 9:44AM (UTC)

vercel[bot] avatar Nov 28 '22 05:11 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 28 '22 05:11 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 28 '22 06:11 github-actions[bot]

/ok-to-test sha=fbf8223

iamrkcheers avatar Nov 28 '22 08:11 iamrkcheers

/ok-to-test sha=fbf8223

iamrkcheers avatar Nov 28 '22 08:11 iamrkcheers

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 28 '22 08:11 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3563141438. Workflow: Appsmith External Integration Test Workflow. Commit: fbf8223. PR: 18480. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18480&runId=3563141438_1

github-actions[bot] avatar Nov 28 '22 09:11 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Dec 06 '22 16:12 github-actions[bot]

  1. Added Cypress test cases
  2. Raised a request for a change in documentation

iamrkcheers avatar Dec 07 '22 11:12 iamrkcheers

/ok-to-test sha=cd64711

iamrkcheers avatar Dec 07 '22 11:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3638460267. Workflow: Appsmith External Integration Test Workflow. Commit: cd64711. PR: 18480. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18480&runId=3638460267_1

github-actions[bot] avatar Dec 07 '22 11:12 github-actions[bot]

/ok-to-test sha=bdc7b52

iamrkcheers avatar Dec 11 '22 10:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3668603058. Workflow: Appsmith External Integration Test Workflow. Commit: bdc7b52. PR: 18480. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18480&runId=3668603058_1

github-actions[bot] avatar Dec 11 '22 10:12 github-actions[bot]

/ok-to-test sha=34554d3

iamrkcheers avatar Dec 12 '22 04:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3672677076. Workflow: Appsmith External Integration Test Workflow. Commit: 34554d3. PR: 18480. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18480&runId=3672677076_1

github-actions[bot] avatar Dec 12 '22 04:12 github-actions[bot]

Some of the changes that were being pushed under this PR have already been merged in Release by this. The remaining changes being pushed under this are,

  • Default tooltip placeholder text in Select family changed to “Add tooltip text here”
  • Added tooltip in Datepicker

iamrkcheers avatar Dec 12 '22 05:12 iamrkcheers

/ok-to-test sha=da58902

iamrkcheers avatar Dec 12 '22 06:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3673317711. Workflow: Appsmith External Integration Test Workflow. Commit: da58902. PR: 18480. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18480&runId=3673317711_1

github-actions[bot] avatar Dec 12 '22 06:12 github-actions[bot]

Tested and verified for the tooltip property for datepicker and select family on this DP. LGTM. https://github.com/appsmithorg/TestSmith/issues/2119

laveena-en avatar Dec 13 '22 09:12 laveena-en