appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Remove duplicate schema fetch calls

Open ChandanBalajiBP opened this issue 3 years ago • 4 comments

Description

On expanding entity in Entity explorer, API to fetch schema was called twice. (Expected to be called only once). API: /api/v1/datasources/*/structure*

Fixes #18403

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

ChandanBalajiBP avatar Nov 25 '22 08:11 ChandanBalajiBP

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 10:31AM (UTC)

vercel[bot] avatar Nov 25 '22 08:11 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 25 '22 08:11 github-actions[bot]

/ok-to-test sha=f20fa43

ChandanBalajiBP avatar Dec 05 '22 18:12 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3622959187. Workflow: Appsmith External Integration Test Workflow. Commit: f20fa43. PR: 18448. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18448&runId=3622959187_1

github-actions[bot] avatar Dec 05 '22 18:12 github-actions[bot]

Tested the 18403 issue on the DP linked to this PR.

  1. Tested on first attempt of accessing the dropdown - Works fine
  2. Tested on refresh and again accessing the dropdown - Works fine
  3. Tested on Mongo/PostGreSQL/GS/MySQL - Works fine on all of them On expanding any datasource, in the network tab, and only one call is made to the API - of the format - "structure?ignoreCache=true"

Not seeing any performance test results.. @ChandanBalajiBP - please do check with the team on this.

btsgh avatar Dec 12 '22 07:12 btsgh

/ok-to-test sha=cc553a6

ChandanBalajiBP avatar Dec 12 '22 07:12 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3673744089. Workflow: Appsmith External Integration Test Workflow. Commit: cc553a6. PR: 18448. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18448&runId=3673744089_1

github-actions[bot] avatar Dec 12 '22 07:12 github-actions[bot]

/perf-test

ChandanBalajiBP avatar Dec 13 '22 05:12 ChandanBalajiBP

/perf-test

SatishGandham avatar Dec 13 '22 10:12 SatishGandham

/perf-test

SatishGandham avatar Dec 13 '22 14:12 SatishGandham

/perf-test

SatishGandham avatar Dec 13 '22 18:12 SatishGandham

/perf-test ref=rhito/change-threshold-of-recheck

Rhitottam avatar Dec 14 '22 08:12 Rhitottam

/ok-to-test sha=62fa1c7

ChandanBalajiBP avatar Dec 14 '22 09:12 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3693303859. Workflow: Appsmith External Integration Test Workflow. Commit: 62fa1c7. PR: 18448. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18448&runId=3693303859_1

github-actions[bot] avatar Dec 14 '22 09:12 github-actions[bot]

/ok-to-test sha=f02f412

ChandanBalajiBP avatar Dec 15 '22 13:12 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3704386809. Workflow: Appsmith External Integration Test Workflow. Commit: f02f412. PR: 18448. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18448&runId=3704386809_1

github-actions[bot] avatar Dec 15 '22 13:12 github-actions[bot]

/ok-to-test sha=6d7f083

ChandanBalajiBP avatar Dec 16 '22 09:12 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3711881744. Workflow: Appsmith External Integration Test Workflow. Commit: 6d7f083. PR: 18448. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18448&runId=3711881744_1

github-actions[bot] avatar Dec 16 '22 09:12 github-actions[bot]

/perf-test ref=rhito/change-threshold-merged-results

Rhitottam avatar Dec 16 '22 13:12 Rhitottam

/ok-to-test sha=f9a7c66

ChandanBalajiBP avatar Dec 16 '22 13:12 ChandanBalajiBP

/perf-test ref=rhito/change-threshold-merged-results

ChandanBalajiBP avatar Dec 16 '22 13:12 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3713603876. Workflow: Appsmith External Integration Test Workflow. Commit: f9a7c66. PR: 18448. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18448&runId=3713603876_1

github-actions[bot] avatar Dec 16 '22 13:12 github-actions[bot]

/ok-to-test sha=39ebd00

ChandanBalajiBP avatar Dec 19 '22 05:12 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3728842569. Workflow: Appsmith External Integration Test Workflow. Commit: 39ebd00. PR: 18448. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18448&runId=3728842569_1

github-actions[bot] avatar Dec 19 '22 05:12 github-actions[bot]