appsmithorg
fix: treat empty valued env variables as false | FE
Description
Converting empty env values or no env value to boolean FALSE before storing in redux store. The empty-valued key in .env files was being treated as a true value in the frontend code just because the key was present in the response. This PR makes it false explicitely and fixes an attached bug. Fixes: #18419
Before
After
When value is not available
When truthy value is received
When false value is received
Type of change
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ⬜️ Ignored (Inspect) | Dec 13, 2022 at 6:22AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3564034117.
Workflow: Appsmith External Integration Test Workflow.
Commit: 293ddff.
PR: 18428.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18428&runId=3564034117_1
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3645621026.
Workflow: Appsmith External Integration Test Workflow.
Commit: 45c867c.
PR: 18428.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18428&runId=3645621026_1
@ankitsrivas14 git checkout release && git pull --rebase origin release && git checkout fix/email-settings-env-keys && git merge release and then git push origin fix/email-settings-env-keys
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3682862799.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7ed449e.
PR: 18428.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18428&runId=3682862799_1