appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: datasource switching issue for Google sheets

Open Irongade opened this issue 3 years ago • 13 comments

When Google sheets datasource is switched, The dynamic trigger values are not refetched i.e. The google sheets does not refetch spreadsheet urls, sheet names or columns.

While this might look like a google sheets specific issue, The solution here can be extended to every future plugins that need to fetch dynamic values when datasource context is switched.

Fixes #17498

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

  • Manual

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

Irongade avatar Nov 23 '22 15:11 Irongade

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 0:14AM (UTC)

vercel[bot] avatar Nov 23 '22 15:11 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 23 '22 15:11 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 23 '22 15:11 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 23 '22 15:11 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 23 '22 15:11 github-actions[bot]

/ok-to-test sha=3b4ab10

Irongade avatar Nov 23 '22 15:11 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3533339333. Workflow: Appsmith External Integration Test Workflow. Commit: 3b4ab10. PR: 18397. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18397&runId=3533339333_1

github-actions[bot] avatar Nov 23 '22 15:11 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 24 '22 07:11 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 24 '22 07:11 github-actions[bot]

/ok-to-test sha=b0e54d2

Irongade avatar Nov 30 '22 13:11 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3584147862. Workflow: Appsmith External Integration Test Workflow. Commit: b0e54d2. PR: 18397. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18397&runId=3584147862_1

github-actions[bot] avatar Nov 30 '22 14:11 github-actions[bot]

/ok-to-test sha=91114ab

Irongade avatar Dec 02 '22 12:12 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3601936774. Workflow: Appsmith External Integration Test Workflow. Commit: 91114ab. PR: 18397. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18397&runId=3601936774_1

github-actions[bot] avatar Dec 02 '22 14:12 github-actions[bot]