appsmith
appsmith copied to clipboard
fix: center align select and RTE labels.
Description
- Label for all select widgets are not center alignment when we choose LabelPosition = LEFT. This pull request fixes it, the label is now center aligned to the input.
- Center align RTE widget label.
- Add tooltips to Labels similar to the input widget
Fixes #18259
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Dec 3, 2022 at 10:32AM (UTC) |
Deployment failed with the following error:
Resource is limited - try again in 35 minutes (more than 100, code: "api-deployments-free-per-day").
/ok-to-test sha=b812088
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3550230340.
Workflow: Appsmith External Integration Test Workflow.
Commit: b812088.
PR: 18378.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18378&runId=3550230340_1
@yaldram Let's merge this into release.
/ok-to-test sha=8718236
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3585264022.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8718236.
PR: 18378.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18378&runId=3585264022_1
/ok-to-test sha=b1e5f2c
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3608176593.
Workflow: Appsmith External Integration Test Workflow.
Commit: b1e5f2c.
PR: 18378.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18378&runId=3608176593_1