appsmith
appsmith copied to clipboard
appsmithorg
fix: Aggregate calls to add and remove Appsmith errors
Description
This PR aims at aggregating calls to update debugger logs. Previously, logs were getting updated singly, causing multiple re-renders to subscribing components.
Fixes #14007 Fixes #17650
Media
A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
Type of change
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important
- Manual
- Jest
- Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Dec 7, 2022 at 7:59AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3499898657.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3c89199.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3499898657_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3512162930.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3c89199.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3512162930_1
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3525253124.
Workflow: Appsmith External Integration Test Workflow.
Commit: a7fc2d9.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3525253124_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3542396572.
Workflow: Appsmith External Integration Test Workflow.
Commit: d3ca910.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3542396572_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3546328032.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3546328032_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3560498551.
Workflow: Appsmith External Integration Test Workflow.
Commit: c7a99e5.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3560498551_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3560506187.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9bb5bf2.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3560506187_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3564030924.
Workflow: Appsmith External Integration Test Workflow.
Commit: 856883b.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3564030924_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3565877186.
Workflow: Appsmith External Integration Test Workflow.
Commit: e56765d.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3565877186_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3619777189.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4ee892a.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18285&runId=3619777189_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3627712247.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4aff94d.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18285&runId=3627712247_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3627712247.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4aff94d.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18285&runId=3627712247_3
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3636910273.
Workflow: Appsmith External Integration Test Workflow.
Commit: f14addf.
PR: 18285.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18285&runId=3636910273_1