appsmith
appsmith copied to clipboard
fix: Meta Rehydration
Description
The introduction of MetaWidgets in List widget v2 introduces a scenario where widgets are newly added to the unevalTree but already have defined meta values. These previously defined meta values have higher priority and should not get overridden by default values.
Fixes #16926
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
[WIP]
- Manual
- Jest
- Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
appsmith | ✅ Ready (Inspect) | Visit Preview | Nov 23, 2022 at 4:24PM (UTC) |
Unable to find test scripts. Please add necessary tests to the PR.
/ok-to-test sha=34aaef9
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3513501472.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 34aaef9
.
PR: 18256.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18256&runId=3513501472_1
/ok-to-test sha=de6727c
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3521863024.
Workflow: Appsmith External Integration Test Workflow
.
Commit: de6727c
.
PR: 18256.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18256&runId=3521863024_1
/ok-to-test sha=d2811bc
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3524283511.
Workflow: Appsmith External Integration Test Workflow
.
Commit: d2811bc
.
PR: 18256.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18256&runId=3524283511_1
/ok-to-test sha=4dd5ee1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3524622468.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 4dd5ee1
.
PR: 18256.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18256&runId=3524622468_1
/ok-to-test sha=5b1768e
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3533822040.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 5b1768e
.
PR: 18256.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18256&runId=3533822040_1
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.