appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: Added support for country code flags on windows devices

Open yaldram opened this issue 2 years ago • 12 comments

Description

  • Added polyfill to support country flags on the windows devices.

Fixes #18177

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

yaldram avatar Nov 16 '22 13:11 yaldram

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 3, 2022 at 10:32AM (UTC)

vercel[bot] avatar Nov 16 '22 13:11 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 16 '22 13:11 github-actions[bot]

@Sripriya93 pls check this

kamakshibhat-appsmith avatar Nov 25 '22 06:11 kamakshibhat-appsmith

We are seeing Country code flags in Phone Input widget. Working fine moving to done.

Sripriya93 avatar Nov 25 '22 07:11 Sripriya93

/ok-to-test sha=7351be1

yaldram avatar Nov 26 '22 09:11 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3553099507. Workflow: Appsmith External Integration Test Workflow. Commit: 7351be1. PR: 18203. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18203&runId=3553099507_1

github-actions[bot] avatar Nov 26 '22 09:11 github-actions[bot]

/ok-to-test sha=9baa410

yaldram avatar Nov 28 '22 06:11 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3562375098. Workflow: Appsmith External Integration Test Workflow. Commit: 9baa410. PR: 18203. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18203&runId=3562375098_1

github-actions[bot] avatar Nov 28 '22 06:11 github-actions[bot]

/ok-to-test sha=efdc91b

Aishwarya-U-R avatar Nov 29 '22 11:11 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3574084474. Workflow: Appsmith External Integration Test Workflow. Commit: efdc91b. PR: 18203. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18203&runId=3574084474_1

github-actions[bot] avatar Nov 29 '22 12:11 github-actions[bot]

/ok-to-test sha=603876f

yaldram avatar Dec 03 '22 10:12 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3608176363. Workflow: Appsmith External Integration Test Workflow. Commit: 603876f. PR: 18203. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18203&runId=3608176363_1

github-actions[bot] avatar Dec 03 '22 10:12 github-actions[bot]