appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Provide currentRow access in the table widget select column typ…

Open sbalaji1192 opened this issue 3 years ago • 9 comments

…e's selectOptions property

Description

  • Now app developers have access to the currentRow variable in the selectOptions property of the select columns in the table widget. This enables them to create different select options for each row in the table.

Fixes #18148

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

sbalaji1192 avatar Nov 16 '22 05:11 sbalaji1192

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 11:14AM (UTC)

vercel[bot] avatar Nov 16 '22 05:11 vercel[bot]

/ok-to-test sha=e8f93b2

sbalaji1192 avatar Nov 23 '22 09:11 sbalaji1192

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3530856477. Workflow: Appsmith External Integration Test Workflow. Commit: e8f93b2. PR: 18180. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18180&runId=3530856477_1

github-actions[bot] avatar Nov 23 '22 09:11 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 22 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 23 '22 10:11 vercel[bot]

The DP link is broken/failed in this PR and also branch has some conflicts. Please check @sbalaji1192 image.png

chandannkumar avatar Nov 24 '22 08:11 chandannkumar

/ok-to-test sha=32f9a2b

sbalaji1192 avatar Dec 01 '22 06:12 sbalaji1192

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3590001664. Workflow: Appsmith External Integration Test Workflow. Commit: 32f9a2b. PR: 18180. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18180&runId=3590001664_1

github-actions[bot] avatar Dec 01 '22 06:12 github-actions[bot]

@sbalaji1192 The table widget is crashing on using currentRow within a select column. Can you please check? https://ivP6ez0lJB.vmaker.com/record/ScL3BURRhLnxYBzc

laveena-en avatar Dec 02 '22 09:12 laveena-en

Deployment failed with the following error:

Resource is limited - try again in 7 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Dec 06 '22 09:12 vercel[bot]

/ok-to-test sha=8703b94

sbalaji1192 avatar Dec 09 '22 04:12 sbalaji1192

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3654339442. Workflow: Appsmith External Integration Test Workflow. Commit: 8703b94. PR: 18180. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18180&runId=3654339442_1

github-actions[bot] avatar Dec 09 '22 04:12 github-actions[bot]

/ok-to-test sha=f69b44c

sbalaji1192 avatar Dec 09 '22 04:12 sbalaji1192

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3654441274. Workflow: Appsmith External Integration Test Workflow. Commit: f69b44c. PR: 18180. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18180&runId=3654441274_1

github-actions[bot] avatar Dec 09 '22 04:12 github-actions[bot]

/ok-to-test sha=87338bf

sbalaji1192 avatar Dec 12 '22 08:12 sbalaji1192

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3673982093. Workflow: Appsmith External Integration Test Workflow. Commit: 87338bf. PR: 18180. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18180&runId=3673982093_1

github-actions[bot] avatar Dec 12 '22 08:12 github-actions[bot]

/ok-to-test sha=a62cbd8

sbalaji1192 avatar Dec 15 '22 04:12 sbalaji1192

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3701071616. Workflow: Appsmith External Integration Test Workflow. Commit: a62cbd8. PR: 18180. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18180&runId=3701071616_1

github-actions[bot] avatar Dec 15 '22 04:12 github-actions[bot]

/ok-to-test sha=4ffb0e2

sbalaji1192 avatar Dec 15 '22 11:12 sbalaji1192

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3703526528. Workflow: Appsmith External Integration Test Workflow. Commit: 4ffb0e2. PR: 18180. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18180&runId=3703526528_1

github-actions[bot] avatar Dec 15 '22 11:12 github-actions[bot]