fix: Login password length upper limit changed from 48 to 256 characters
Description
Changed the login password length upper limit from 48 to 256 characters
Fixes # (issue) [Bug]-[672]:Passwords longer than 48 characters are "not strong enough
Before

After

Type of change
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ⬜️ Ignored (Inspect) | Dec 13, 2022 at 6:25AM (UTC) |
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
/ok-to-test sha=7286dbd
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3476067162.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7286dbd.
PR: 18176.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18176&runId=3476067162_1
Unable to find test scripts. Please add necessary tests to the PR.
@ankit Srivastava Please make max limit 256 characters long.
Done
/ok-to-test sha=e2d1f79
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3545397954.
Workflow: Appsmith External Integration Test Workflow.
Commit: e2d1f79.
PR: 18176.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18176&runId=3545397954_1
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
/ok-to-test sha=5b414a2
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3645600947.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5b414a2.
PR: 18176.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18176&runId=3645600947_1
Update the branch with release changes and trigger testing.
/ok-to-test sha=64545aa
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3682884988.
Workflow: Appsmith External Integration Test Workflow.
Commit: 64545aa.
PR: 18176.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18176&runId=3682884988_1