appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: resetting audio and video widget

Open iamrkcheers opened this issue 2 years ago • 20 comments

Description

Resetting audio and video widget ui when playstate value resets

Fixes #14692

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

iamrkcheers avatar Nov 07 '22 07:11 iamrkcheers

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 9:44AM (UTC)

vercel[bot] avatar Nov 07 '22 07:11 vercel[bot]

/ok-to-test sha=c8a262e

iamrkcheers avatar Nov 21 '22 18:11 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3516915527. Workflow: Appsmith External Integration Test Workflow. Commit: c8a262e. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18126&runId=3516915527_1

github-actions[bot] avatar Nov 21 '22 18:11 github-actions[bot]

/ok-to-test sha=10d81d6

iamrkcheers avatar Nov 28 '22 08:11 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3563001269. Workflow: Appsmith External Integration Test Workflow. Commit: 10d81d6. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18126&runId=3563001269_1

github-actions[bot] avatar Nov 28 '22 08:11 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3563001410. Workflow: Appsmith External Integration Test Workflow. Commit: fbf8223. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18126&runId=3563001410_1

github-actions[bot] avatar Nov 28 '22 08:11 github-actions[bot]

/ok-to-test sha=24e36c4

iamrkcheers avatar Nov 29 '22 09:11 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3572792226. Workflow: Appsmith External Integration Test Workflow. Commit: 24e36c4. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18126&runId=3572792226_1

github-actions[bot] avatar Nov 29 '22 09:11 github-actions[bot]

/ok-to-test sha=e0f9e30

iamrkcheers avatar Nov 29 '22 11:11 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3573466137. Workflow: Appsmith External Integration Test Workflow. Commit: e0f9e30. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18126&runId=3573466137_1

github-actions[bot] avatar Nov 29 '22 11:11 github-actions[bot]

@iamrkcheers @dilippitchika The fix for the camera widget mentioned in the same thread https://github.com/appsmithorg/appsmith/issues/14692#issuecomment-1160698296 hasn’t been covered in this PR. Shall I raise a separate issue for it or do we add this to the scope in the current PR itself?

cc: @sbalaji1192

laveena-en avatar Dec 01 '22 11:12 laveena-en

Thanks for pointing this @laveena-en, yes you can raise a separate issue for this

dilippitchika avatar Dec 02 '22 04:12 dilippitchika

Raising a separate issue for the camera widget here: https://github.com/appsmithorg/appsmith/issues/18622

laveena-en avatar Dec 02 '22 06:12 laveena-en

Tested and verified the PR. Internal properties and UI of the audio and video are being reset as expected.

laveena-en avatar Dec 02 '22 06:12 laveena-en

/ok-to-test sha=11e3cb6

iamrkcheers avatar Dec 02 '22 09:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3600964056. Workflow: Appsmith External Integration Test Workflow. Commit: 11e3cb6. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18126&runId=3600964056_1

github-actions[bot] avatar Dec 02 '22 11:12 github-actions[bot]

/ok-to-test sha=e9afed3

iamrkcheers avatar Dec 05 '22 11:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3619594795. Workflow: Appsmith External Integration Test Workflow. Commit: e9afed3. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18126&runId=3619594795_1

github-actions[bot] avatar Dec 05 '22 11:12 github-actions[bot]

/ok-to-test sha=5861568

iamrkcheers avatar Dec 06 '22 17:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3632081716. Workflow: Appsmith External Integration Test Workflow. Commit: 5861568. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18126&runId=3632081716_1

github-actions[bot] avatar Dec 06 '22 17:12 github-actions[bot]

/ok-to-test sha=7dc1756

iamrkcheers avatar Dec 07 '22 09:12 iamrkcheers

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3637539464. Workflow: Appsmith External Integration Test Workflow. Commit: 7dc1756. PR: 18126. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18126&runId=3637539464_1

github-actions[bot] avatar Dec 07 '22 09:12 github-actions[bot]