appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

Fix: Add JS for icon property in buttons

Open sanjus-robotic-studio opened this issue 1 year ago • 2 comments

Description

Add JS functionality for icon in buttons, button group, menu button

Fixes #11142

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested Manually

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

sanjus-robotic-studio avatar Oct 20 '22 15:10 sanjus-robotic-studio

@sanjus-robotic-studio is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 20 '22 15:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 0:31AM (UTC)

vercel[bot] avatar Oct 20 '22 15:10 vercel[bot]

/perf-test ref=rhito/feat-create-run-meta-before-test-starts-compare-lt-st-for-prev-runs

Rhitottam avatar Oct 21 '22 04:10 Rhitottam

/ok-to-test sha=92977ef

Tooluloope avatar Oct 21 '22 07:10 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3295636712. Workflow: Appsmith External Integration Test Workflow. Commit: 92977ef. PR: 17779. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17779&runId=3295636712_1

github-actions[bot] avatar Oct 21 '22 08:10 github-actions[bot]

/perf-test ref=rhito/feat-create-run-meta-before-test-starts-compare-lt-st-for-prev-runs

Rhitottam avatar Oct 22 '22 02:10 Rhitottam

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3301662676. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 17779. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17779&runId=3301662676_1

github-actions[bot] avatar Oct 22 '22 02:10 github-actions[bot]

Hey when will this PR be accepted

sanjus-robotic-studio avatar Oct 25 '22 06:10 sanjus-robotic-studio

Hey @Tooluloope Can you approve the changes

sanjus-robotic-studio avatar Oct 25 '22 11:10 sanjus-robotic-studio

@somangshu Can you review this too?

sanjus-robotic-studio avatar Oct 25 '22 12:10 sanjus-robotic-studio

@sanjus-robotic-studio while I am looking into the above query, can you merge with latest release branch

somangshu avatar Oct 25 '22 12:10 somangshu

@somangshu I have merged this branch with the latest release branch

sanjus-robotic-studio avatar Oct 25 '22 12:10 sanjus-robotic-studio

/ok-to-test sha=a4daf2a

Tooluloope avatar Oct 25 '22 12:10 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3320950788. Workflow: Appsmith External Integration Test Workflow. Commit: a4daf2a. PR: 17779. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17779&runId=3320950788_1

github-actions[bot] avatar Oct 25 '22 12:10 github-actions[bot]

@sanjus-robotic-studio thanks for the changes, the tests are running right now; Ill merge this by tomorrow. 🙏

somangshu avatar Oct 25 '22 13:10 somangshu

Sure, Thanks

sanjus-robotic-studio avatar Oct 25 '22 13:10 sanjus-robotic-studio