appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

chore: List v2 virtual list

Open ashit-rath opened this issue 1 year ago • 4 comments

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #17378

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

ashit-rath avatar Oct 19 '22 09:10 ashit-rath

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 3:20PM (UTC)

vercel[bot] avatar Oct 19 '22 09:10 vercel[bot]

Also, it looks like there are a lot of changes that would cause conflict in my task #17480, so I'll wait for this is to be merged

Tooluloope avatar Oct 19 '22 23:10 Tooluloope

Screen.Recording.2022-10-19.at.23.55.17.mov

The horizontal scroll is a result of the scrollbar taking up a fixed space. This is still under discussion as to how to deal with it. I'll look into the extra scrollbar that appears.

ashit-rath avatar Oct 20 '22 04:10 ashit-rath

https://user-images.githubusercontent.com/31691737/196820038-c62bb742-0961-4fd2-b584-05eef1ba374d.mov

Okay, that fine @ashit-rath . Any update on the second observation?

Tooluloope avatar Oct 20 '22 07:10 Tooluloope