appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: remove file references on click of cancel button

Open keyurparalkar opened this issue 2 years ago • 10 comments

Description

To remove the selectedFiles meta property whenever the cancel button is clicked. This will make sure to remove the files from the redux store and also from the uppy's instance.

Fixes #17659

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated the FilePickerV2_spec.js with the following scenario:

  • Click on cancel button
  • Check the file picker button for the file count text. Since all files are deleted the text inside the file picker button becomes "Select Files"
  • Check the API page and check the evaluated value inside the binding

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

keyurparalkar avatar Oct 18 '22 11:10 keyurparalkar

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 1:48PM (UTC)

vercel[bot] avatar Oct 18 '22 11:10 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 18 '22 12:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 18 '22 12:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 18 '22 12:10 github-actions[bot]

/ok-to-test sha=7cdc0fa

keyurparalkar avatar Oct 18 '22 14:10 keyurparalkar

/ok-to-test sha=7cdc0fa

keyurparalkar avatar Oct 18 '22 15:10 keyurparalkar

Tested on DP. Working fine This fixes #17659

kamakshibhat-appsmith avatar Oct 18 '22 15:10 kamakshibhat-appsmith

/ok-to-test sha=7cdc0fa

keyurparalkar avatar Oct 18 '22 17:10 keyurparalkar

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3275054572. Workflow: Appsmith External Integration Test Workflow. Commit: 7cdc0fa. PR: 17664. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17664&runId=3275054572_1

github-actions[bot] avatar Oct 18 '22 17:10 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3275489373. Workflow: Appsmith External Integration Test Workflow. Commit: 7cdc0fa. PR: 17664. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17664&runId=3275489373_1

github-actions[bot] avatar Oct 18 '22 17:10 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3276006213. Workflow: Appsmith External Integration Test Workflow. Commit: 7cdc0fa. PR: 17664. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17664&runId=3276006213_1

github-actions[bot] avatar Oct 18 '22 19:10 github-actions[bot]

/ok-to-test sha=7cdc0fa

keyurparalkar avatar Oct 19 '22 02:10 keyurparalkar

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3278347342. Workflow: Appsmith External Integration Test Workflow. Commit: 7cdc0fa. PR: 17664. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17664&runId=3278347342_1

github-actions[bot] avatar Oct 19 '22 02:10 github-actions[bot]