appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Fix evaluated popup on all screens

Open Irongade opened this issue 2 years ago • 4 comments

This PR fixes how the evaluated pop up overlaps the property pane when on smaller window screens.

Fixes #4458

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Visual Test.

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

Irongade avatar Oct 18 '22 07:10 Irongade

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 6:56AM (UTC)

vercel[bot] avatar Oct 18 '22 07:10 vercel[bot]

/ok-to-test sha=589f353

Irongade avatar Oct 18 '22 07:10 Irongade

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 18 '22 08:10 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3271723855. Workflow: Appsmith External Integration Test Workflow. Commit: 589f353. PR: 17643. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17643&runId=3271723855_1

github-actions[bot] avatar Oct 18 '22 09:10 github-actions[bot]

/ok-to-test sha=909add4

Aishwarya-U-R avatar Oct 19 '22 12:10 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3282106332. Workflow: Appsmith External Integration Test Workflow. Commit: 909add4. PR: 17643. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17643&runId=3282106332_1

github-actions[bot] avatar Oct 19 '22 14:10 github-actions[bot]

/ok-to-test sha=934a0d6

Aishwarya-U-R avatar Oct 20 '22 06:10 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3287321374. Workflow: Appsmith External Integration Test Workflow. Commit: 934a0d6. PR: 17643. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17643&runId=3287321374_1

github-actions[bot] avatar Oct 20 '22 06:10 github-actions[bot]

Please find the screenshot here as I observe there is overlap of the evaluated value on the query body Screenshot 2022-10-22 at 10 17 44 PM

prapullac avatar Oct 26 '22 13:10 prapullac

@Irongade We discussed about the solution but it doesn't cater to all the scenarios. Hence, we would like to go back to the design phase to correct the ui as well. So moving the issue to Design backlog and marking this Pr as draft so that it doesn't reminds daily to review this PR for a while.

AmanAgarwal041 avatar Nov 02 '22 13:11 AmanAgarwal041

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Nov 09 '22 16:11 github-actions[bot]

This PR has been closed because of inactivity.

github-actions[bot] avatar Nov 25 '22 16:11 github-actions[bot]