appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: JS option missing for Label Font Style in Input widget

Open sanjus-robotic-studio opened this issue 3 years ago • 5 comments

Description

Made changes to baseinputwidget label style - Emphasis Property Fixes #15542

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been tested locally on my Computer

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

sanjus-robotic-studio avatar Oct 17 '22 18:10 sanjus-robotic-studio

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

welcome[bot] avatar Oct 17 '22 18:10 welcome[bot]

@sanjus-robotic-studio is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 17 '22 18:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 0:22AM (UTC)

vercel[bot] avatar Oct 17 '22 18:10 vercel[bot]

@aswathkk can you review this change? It's from our external contributor

CC @somangshu

dilippitchika avatar Oct 18 '22 03:10 dilippitchika

@aswathkk I have made the changes

sanjus-robotic-studio avatar Oct 18 '22 12:10 sanjus-robotic-studio

/ok-to-test sha=d76c635

aswathkk avatar Oct 19 '22 05:10 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3279081343. Workflow: Appsmith External Integration Test Workflow. Commit: d76c635. PR: 17631. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17631&runId=3279081343_1

github-actions[bot] avatar Oct 19 '22 05:10 github-actions[bot]