appsmith
appsmith copied to clipboard
appsmithorg
chore: import common variables from design system
Description
Import variables that are commonly used both in the design system and in the core repository from the design-system in order to prevent duplication of code and maintain a single source of truth. Closes https://github.com/appsmithorg/appsmith/issues/17599
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Builds pass locally. Regression across app on DP.
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Oct 28, 2022 at 11:07AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3287973556.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5fafeb1.
PR: 17600.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17600&runId=3287973556_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3296390549.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6c09028792dc5eab079fc0e57ce7731c1de6f031.
PR: 17600.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17600&runId=3296390549_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3302886226.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6c09028792dc5eab079fc0e57ce7731c1de6f031.
PR: 17600.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17600&runId=3302886226_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3318605862.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6c09028792dc5eab079fc0e57ce7731c1de6f031.
PR: 17600.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17600&runId=3318605862_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3333995917.
Workflow: Appsmith External Integration Test Workflow.
Commit: aed2ee63b7a2e1957d1dfa5e4f0ebe52c9151feb.
PR: 17600.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17600&runId=3333995917_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3337028147.
Workflow: Appsmith External Integration Test Workflow.
Commit: aed2ee63b7a2e1957d1dfa5e4f0ebe52c9151feb.
PR: 17600.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17600&runId=3337028147_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3344902492.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8d2e07bd0f8f88bda290d479fbb7a387bafb8b2d.
PR: 17600.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17600&runId=3344902492_1