appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: replace time based action to event based

Open ayushpahwa opened this issue 2 years ago • 10 comments

Description

  • The delete datasource button was getting reset to its original state after a static time of 2200ms. This was causing the system to go into an error state when the API was taking too long to respond.
  • Replaced this to reset on completion of deletion instead.

Smartlook video for one such incident: https://app.smartlook.com/org/9b6c5c859e85745d01196fa4/project/e373e3a21d27278fd281d8b0/recordings?filter=4dcb8034873b25b4d28bd3b05de52996b626d39a09e98396833e29f33fc22ce4&player=1&session=Tu-Epbj3mk&visitor=XM_bAVqFBI

Fixes #16721

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Test A
  • Test B

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

ayushpahwa avatar Oct 16 '22 11:10 ayushpahwa

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 6:44AM (UTC)

vercel[bot] avatar Oct 16 '22 11:10 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 16 '22 11:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 16 '22 11:10 github-actions[bot]

/ok-to-test sha=062ab83

ayushpahwa avatar Oct 16 '22 11:10 ayushpahwa

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3259347623. Workflow: Appsmith External Integration Test Workflow. Commit: 062ab83. PR: 17586. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17586&runId=3259347623_1

github-actions[bot] avatar Oct 16 '22 11:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 16 '22 11:10 github-actions[bot]

/ok-to-test sha=a3a5b1d

ayushpahwa avatar Oct 16 '22 11:10 ayushpahwa

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3259386774. Workflow: Appsmith External Integration Test Workflow. Commit: a3a5b1d. PR: 17586. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17586&runId=3259386774_1

github-actions[bot] avatar Oct 16 '22 11:10 github-actions[bot]

/ok-to-test sha=855f6fc

ayushpahwa avatar Oct 17 '22 10:10 ayushpahwa

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3264740503. Workflow: Appsmith External Integration Test Workflow. Commit: 855f6fc. PR: 17586. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17586&runId=3264740503_1

github-actions[bot] avatar Oct 17 '22 11:10 github-actions[bot]

/ok-to-test sha=8b75553

ayushpahwa avatar Oct 19 '22 06:10 ayushpahwa

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3279902865. Workflow: Appsmith External Integration Test Workflow. Commit: 8b75553. PR: 17586. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17586&runId=3279902865_1

github-actions[bot] avatar Oct 19 '22 08:10 github-actions[bot]