appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: checkbox widget label right alignment issue.

Open yaldram opened this issue 2 years ago • 15 comments

Description

Label Position right option was not aligning the label to the right for the Checkbox widget.

Fixes #16126

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested Manually on the canvas

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

yaldram avatar Oct 12 '22 10:10 yaldram

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 5:14PM (UTC)

vercel[bot] avatar Oct 12 '22 10:10 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 12 '22 10:10 github-actions[bot]

During widget reskinning I see we have removed width: 100% for the checkbox here https://github.com/appsmithorg/appsmith/pull/15329 - image Therefore, the label was not taking the full width of the parent and the right alignment was not working.

yaldram avatar Oct 12 '22 10:10 yaldram

@yaldram @Sripriya93 this is not what i expected the fix to be. Can you check this loom - https://www.loom.com/share/2d508428f3e94ae6a329a55ca0738691

dilippitchika avatar Oct 13 '22 10:10 dilippitchika

Thanks @dilippitchika for the explanation. I have made the necessary changes and pushed the code please check the latest Deploy Preview. Thanks

yaldram avatar Oct 13 '22 12:10 yaldram

Position - changes the position of the label along with the checkbox Alignment - Changes the alignment of the label alone Working fine, moving to done

https://images.zenhubusercontent.com/275993885/7e6d3aba-c477-4dae-b9b8-934b8c766760/untitled_application_1___editor___appsmith___14_october_2022.mp4

Sripriya93 avatar Oct 14 '22 05:10 Sripriya93

/ok-to-test sha=0006bd8

yaldram avatar Oct 15 '22 08:10 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3255024252. Workflow: Appsmith External Integration Test Workflow. Commit: 0006bd8. PR: 17516. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3255024252_1

github-actions[bot] avatar Oct 15 '22 08:10 github-actions[bot]

/ok-to-test sha=abd584f

yaldram avatar Oct 17 '22 11:10 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3264910789. Workflow: Appsmith External Integration Test Workflow. Commit: abd584f. PR: 17516. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3264910789_1

github-actions[bot] avatar Oct 17 '22 11:10 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 25 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Oct 17 '22 15:10 vercel[bot]

/ok-to-test sha=dc490af

AnaghHegde avatar Oct 17 '22 16:10 AnaghHegde

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3267149293. Workflow: Appsmith External Integration Test Workflow. Commit: dc490af. PR: 17516. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3267149293_1

github-actions[bot] avatar Oct 17 '22 18:10 github-actions[bot]

/ok-to-test sha=2c34f2b

yaldram avatar Oct 20 '22 17:10 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3291691714. Workflow: Appsmith External Integration Test Workflow. Commit: 2c34f2b. PR: 17516. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3291691714_1

github-actions[bot] avatar Oct 20 '22 17:10 github-actions[bot]