appsmith
appsmith copied to clipboard
fix: checkbox widget label right alignment issue.
Description
Label Position right option was not aligning the label to the right for the Checkbox widget.
Fixes #16126
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Tested Manually on the canvas
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
appsmith | ✅ Ready (Inspect) | Visit Preview | Oct 20, 2022 at 5:14PM (UTC) |
Unable to find test scripts. Please add necessary tests to the PR.
During widget reskinning I see we have removed width: 100%
for the checkbox here https://github.com/appsmithorg/appsmith/pull/15329 -
Therefore, the label was not taking the full width of the parent and the right alignment was not working.
@yaldram @Sripriya93 this is not what i expected the fix to be. Can you check this loom - https://www.loom.com/share/2d508428f3e94ae6a329a55ca0738691
Thanks @dilippitchika for the explanation. I have made the necessary changes and pushed the code please check the latest Deploy Preview. Thanks
Position - changes the position of the label along with the checkbox Alignment - Changes the alignment of the label alone Working fine, moving to done
https://images.zenhubusercontent.com/275993885/7e6d3aba-c477-4dae-b9b8-934b8c766760/untitled_application_1___editor___appsmith___14_october_2022.mp4
/ok-to-test sha=0006bd8
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3255024252.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 0006bd8
.
PR: 17516.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3255024252_1
/ok-to-test sha=abd584f
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3264910789.
Workflow: Appsmith External Integration Test Workflow
.
Commit: abd584f
.
PR: 17516.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3264910789_1
Deployment failed with the following error:
Resource is limited - try again in 25 minutes (more than 100, code: "api-deployments-free-per-day").
/ok-to-test sha=dc490af
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3267149293.
Workflow: Appsmith External Integration Test Workflow
.
Commit: dc490af
.
PR: 17516.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3267149293_1
/ok-to-test sha=2c34f2b
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3291691714.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 2c34f2b
.
PR: 17516.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17516&runId=3291691714_1