appsmith
appsmith copied to clipboard
appsmithorg
feat: migrated form group from ads folder to design system repository
Description
Changed imports of form group component to design system repository.
Fixes #17399
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
- Tested in local
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Oct 20, 2022 at 5:10AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3211415571.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4ae194b.
PR: 17400.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3211415571.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 380.44 | 360.23 | 360.32 | 359.87 | 358.09 | 358.09 | 360.23 | 363.79 | 6.14 | 2.57 | 2.30 |
| painting | 4.68 | 3.91 | 5.45 | 4.72 | 7.38 | 3.91 | 4.72 | 5.23 | 66.35 | 25.24 | 22.56 |
| rendering | 107.56 | 107.13 | 106.2 | 108.78 | 104.19 | 104.19 | 107.13 | 106.77 | 4.30 | 1.61 | 1.43 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 980.01 | 1101.73 | 1063.65 | 1116.06 | 1078.38 | 980.01 | 1078.38 | 1067.97 | 12.74 | 4.98 | 4.45 |
| painting | 9.87 | 20.65 | 20.4 | 17.54 | 16.97 | 9.87 | 17.54 | 17.09 | 63.08 | 25.51 | 22.82 |
| rendering | 813 | 851.19 | 799.81 | 846.76 | 803.19 | 799.81 | 813 | 822.79 | 6.24 | 2.97 | 2.66 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 910.81 | 867.09 | 818.56 | 877.66 | 932.24 | 818.56 | 877.66 | 881.27 | 12.90 | 4.95 | 4.43 |
| painting | 18.07 | 8.48 | 9.16 | 10.33 | 9.45 | 8.48 | 9.45 | 11.1 | 86.40 | 35.59 | 31.89 |
| rendering | 300.4 | 302.77 | 294.78 | 300.42 | 299.92 | 294.78 | 300.4 | 299.66 | 2.67 | 0.98 | 0.88 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 931.21 | 875.89 | 984 | 861.71 | 907.33 | 861.71 | 907.33 | 912.03 | 13.41 | 5.32 | 4.76 |
| painting | 11.41 | 12.88 | 8.88 | 7.61 | 11.99 | 7.61 | 11.41 | 10.55 | 49.95 | 21.04 | 18.77 |
| rendering | 593.77 | 575.21 | 596.67 | 583.53 | 598.45 | 575.21 | 593.77 | 589.53 | 3.94 | 1.67 | 1.50 |
| OPEN_MODAL | |||||||||||
| scripting | 433.07 | 438.84 | 449.86 | 466.39 | 451.96 | 433.07 | 449.86 | 448.02 | 7.44 | 2.88 | 2.57 |
| painting | 9.08 | 13 | 8.11 | 12.45 | 13.04 | 8.11 | 12.45 | 11.14 | 44.25 | 21.18 | 18.94 |
| rendering | 1174.19 | 1191.73 | 1182.63 | 1236.87 | 1194.98 | 1174.19 | 1191.73 | 1196.08 | 5.24 | 2.02 | 1.81 |
| CLOSE_MODAL | |||||||||||
| scripting | 189.46 | 188.73 | 211.94 | 186.14 | 223.93 | 186.14 | 189.46 | 200.04 | 18.89 | 8.46 | 7.57 |
| painting | 5.1 | 9.05 | 8.69 | 4.67 | 4.06 | 4.06 | 5.1 | 6.31 | 79.08 | 37.56 | 33.60 |
| rendering | 889.04 | 902.82 | 878.43 | 880.63 | 913.27 | 878.43 | 889.04 | 892.84 | 3.90 | 1.67 | 1.49 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 295.88 | 294.09 | 278.42 | 292.59 | 296.58 | 278.42 | 294.09 | 291.51 | 6.23 | 2.57 | 2.29 |
| painting | 6.1 | 6.18 | 9.98 | 7.98 | 8.12 | 6.1 | 7.98 | 7.67 | 50.59 | 20.99 | 18.77 |
| rendering | 671.47 | 654.89 | 633.72 | 654.04 | 648 | 633.72 | 654.04 | 652.42 | 5.79 | 2.09 | 1.87 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 158.95 | 158.62 | 157.02 | 167.46 | 164.76 | 157.02 | 158.95 | 161.36 | 6.47 | 2.79 | 2.49 |
| painting | 5.53 | 5.39 | 13.25 | 6.31 | 2.03 | 2.03 | 5.53 | 6.5 | 172.62 | 63.38 | 56.62 |
| rendering | 316 | 320.89 | 314.52 | 319.52 | 312.6 | 312.6 | 316 | 316.71 | 2.62 | 1.09 | 0.97 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3237250596.
Workflow: Appsmith External Integration Test Workflow.
Commit: e515bca.
PR: 17400.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17400&runId=3237250596_1
The labels for the input fields are grey in colour. They should be black in colour.
This affects all the impact areas of the FormGroup component.
Deployment failed with the following error:
Resource is limited - try again in 6 hours (more than 100, code: "api-deployments-free-per-day").
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3245735366.
Workflow: Appsmith External Integration Test Workflow.
Commit: e144d2b.
PR: 17400.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17400&runId=3245735366_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3260591175.
Workflow: Appsmith External Integration Test Workflow.
Commit: e775d27.
PR: 17400.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17400&runId=3260591175_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3263406858.
Workflow: Appsmith External Integration Test Workflow.
Commit: b0cd81a.
PR: 17400.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17400&runId=3263406858_1
Deployment failed with the following error:
Resource is limited - try again in 12 minutes (more than 100, code: "api-deployments-free-per-day").
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3278990842.
Workflow: Appsmith External Integration Test Workflow.
Commit: b8d22a7.
PR: 17400.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17400&runId=3278990842_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3286952508.
Workflow: Appsmith External Integration Test Workflow.
Commit: fb74b77206d41d02190cc5571a524579d7a529d7.
PR: 17400.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17400&runId=3286952508_1