appsmith
appsmith copied to clipboard
appsmithorg
feat: Split evaluation and linting
Description
Improvements
Case study: Loading of App stated here .
View Mode Timings
Edit Mode Timings
Fixes #16259
Type of change
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Jest
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Nov 3, 2022 at 6:56AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3217336074.
Workflow: Appsmith External Integration Test Workflow.
Commit: 871cf7a.
PR: 17287.
Can we move test files to tests subfolder of evaluations and linting ?
Done
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3218423901.
Workflow: Appsmith External Integration Test Workflow.
Commit: 620aebe.
PR: 17287.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3219279896.
Workflow: Appsmith External Integration Test Workflow.
Commit: df2cc46.
PR: 17287.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3219811929.
Workflow: Appsmith External Integration Test Workflow.
Commit: 96322c0.
PR: 17287.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3224881685.
Workflow: Appsmith External Integration Test Workflow.
Commit: e8a49db.
PR: 17287.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3225139557.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7aa0714.
PR: 17287.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3259588347.
Workflow: Appsmith External Integration Test Workflow.
Commit: a35a7a5.
PR: 17287.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17287&runId=3259588347_1
Issues seen on this DP and not on release:
-
[x] app save state takes goes into an infinite saving state and all edits made on the canvas is lost, editor changes are saved though
-
[x] When such an error state widget is loaded on page load then related errors are not displayed on the debugger and all widgets on the canvas fail to load
-
[x] New function created on the editor is not parsed so it does not appear on the dropdown and the run button does not show up on the editor gutter. Refresh the page and the function gets parsed and appears on settings
https://www.loom.com/share/22bfd27aa2b140d09a14cef9ca54e973 https://www.loom.com/share/afd416c3939d4e63b79473505eb2a9a4 Sample app - https://appsmith-git-feat-split-evaluation-and-linting-get-appsmith.vercel.app/applications/6253f53e20a66f0a70f8[…]ges/633fb536bab79849bfde6f25/edit
