appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

chore: move render field to component

Open rimildeyjsr opened this issue 2 years ago • 28 comments

Description

As part of the action selector refactor, we are making the following changes -

  • moving renderField to its own component called Field
  • created FieldConfig to hold all the configurations of these functions fields: This config will slowly be built up to hold all the miscellaneous configurations which is currently scattered throughout different files
  • added types for the props
  • moved FieldConfig to its own type

Fixes #16934 #16936

Type of change

  • Refactor

How Has This Been Tested?

  • manually
  • Jest test cases

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

rimildeyjsr avatar Sep 27 '22 07:09 rimildeyjsr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 22, 2022 at 7:27AM (UTC)

vercel[bot] avatar Sep 27 '22 07:09 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Sep 27 '22 07:09 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 20 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Sep 29 '22 06:09 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 15 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Sep 29 '22 06:09 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 04 '22 13:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 04 '22 13:10 github-actions[bot]

/ok-to-test sha=f467815

rimildeyjsr avatar Oct 05 '22 08:10 rimildeyjsr

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 05 '22 09:10 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3188753793. Workflow: Appsmith External Integration Test Workflow. Commit: f467815. PR: 17084.

github-actions[bot] avatar Oct 05 '22 09:10 github-actions[bot]

/ok-to-test sha=dd3a28a

rimildeyjsr avatar Oct 05 '22 10:10 rimildeyjsr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3189147821. Workflow: Appsmith External Integration Test Workflow. Commit: dd3a28a. PR: 17084.

github-actions[bot] avatar Oct 05 '22 11:10 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3189147821. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 330.17 351.36 351.99 345.46 348.05 330.17 348.05 345.41 6.32 2.58 2.31
painting 3.23 4.99 6.06 16.79 3.2 3.2 4.99 6.85 198.39 83.07 74.31
rendering 105.35 108.61 106.9 104.71 104.19 104.19 105.35 105.95 4.17 1.70 1.52
BIND_TABLE_DATA
scripting 1078.22 1057.46 1002.84 1076.1 971.23 971.23 1057.46 1037.17 10.32 4.61 4.12
painting 16.34 15.21 16.85 17.02 12.17 12.17 16.34 15.52 31.25 12.89 11.53
rendering 783.45 893.46 813.08 820.9 779.15 779.15 813.08 818.01 13.97 5.61 5.02
CLICK_ON_TABLE_ROW
scripting 888.27 957.45 903.72 890.73 883.84 883.84 890.73 904.8 8.14 3.35 3.00
painting 20.04 14.44 12.18 9.44 8.56 8.56 12.18 12.93 88.79 35.58 31.86
rendering 303.23 324.42 292.35 297.75 294.24 292.35 297.75 302.4 10.61 4.30 3.84
UPDATE_POST_TITLE
scripting 988.42 931.63 952.14 850.51 881.29 850.51 931.63 920.8 14.98 5.99 5.36
painting 9.86 10.13 8.31 7.86 7.91 7.86 8.31 8.81 25.77 12.49 11.12
rendering 583.81 628.48 640.11 580.68 585.86 580.68 585.86 603.79 9.84 4.67 4.18
OPEN_MODAL
scripting 462.46 508.24 465.57 474.56 460.86 460.86 465.57 474.34 9.99 4.15 3.71
painting 13.06 17.67 8.58 18.05 12.38 8.58 13.06 13.95 67.89 28.39 25.38
rendering 1181.23 1288.25 1166.76 1196.44 1188.96 1166.76 1188.96 1204.33 10.09 4.00 3.58
CLOSE_MODAL
scripting 219.34 255.79 197.73 202.24 186.79 186.79 202.24 212.38 32.49 12.69 11.35
painting 6.49 6.54 6.71 4.72 11.16 4.72 6.54 7.12 90.45 33.71 30.06
rendering 896.25 940.47 879.96 904.61 897.86 879.96 897.86 903.83 6.69 2.48 2.22
SELECT_WIDGET_MENU_OPEN
scripting 281.24 295.33 295.49 275.95 297.65 275.95 295.33 289.13 7.51 3.40 3.04
painting 12.05 5.56 8.78 6.37 20.49 5.56 8.78 10.65 140.19 56.81 50.80
rendering 648.73 650.37 675.23 631.13 642.86 631.13 648.73 649.66 6.79 2.49 2.23
SELECT_WIDGET_SELECT_OPTION
scripting 155.63 163.6 150.01 157.55 161.86 150.01 157.55 157.73 8.62 3.40 3.05
painting 3.91 5.77 3.35 3.98 3.93 3.35 3.93 4.19 57.76 21.96 19.57
rendering 306.64 317.27 320.67 316.29 296.48 296.48 316.29 311.47 7.77 3.17 2.83

github-actions[bot] avatar Oct 05 '22 11:10 github-actions[bot]

/ok-to-test sha=8613f1c

rimildeyjsr avatar Oct 06 '22 06:10 rimildeyjsr

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 06 '22 06:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 06 '22 06:10 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3195126817. Workflow: Appsmith External Integration Test Workflow. Commit: 8613f1c. PR: 17084.

github-actions[bot] avatar Oct 06 '22 08:10 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3195126817. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_WIDGET_MENU_OPEN
scripting 352.52 294.24 283.97 275.51 277.57 275.51 283.97 296.76 25.95 10.79 9.65
painting 13.59 6.38 5.98 5.12 13.54 5.12 6.38 8.92 94.96 47.76 42.71
rendering 775.86 660.23 647.76 646.93 657.24 646.93 657.24 677.6 19.03 8.15 7.29
SELECT_WIDGET_SELECT_OPTION
scripting 177.62 168.78 152.06 156.89 153.18 152.06 156.89 161.71 15.81 6.86 6.13
painting 5.85 2.79 1.83 2.77 6.38 1.83 2.79 3.92 116.07 52.30 46.68
rendering 338.5 322.12 314.14 305.31 316.41 305.31 316.41 319.3 10.39 3.86 3.45
SELECT_CATEGORY
scripting 375.2 353.59 367.24 405.19 353.59 371.22 375.31 13.75 5.82 5.04
painting 4.03 5.93 4.22 5.34 4.03 4.779999999999999 4.88 38.93 18.65 16.19
rendering 110.3 103.76 104.54 111.75 103.76 107.42 107.59 7.43 3.75 3.24
BIND_TABLE_DATA
scripting 1078.61 1040.94 1052.64 1099.08 1040.94 1065.625 1067.82 5.44 2.45 2.12
painting 17.22 16.61 18.57 24.15 16.61 17.895 19.14 39.39 17.97 15.57
rendering 837.65 783.61 818.35 856.96 783.61 828 824.14 8.90 3.80 3.29
CLICK_ON_TABLE_ROW
scripting 880.02 911.19 910.19 896.46 880.02 903.325 899.47 3.47 1.62 1.41
painting 14.29 8.19 13.15 13.27 8.19 13.21 12.22 49.92 22.42 19.39
rendering 303.15 292.88 300.23 305.13 292.88 301.69 300.35 4.08 1.79 1.55
UPDATE_POST_TITLE
scripting 971.28 830.87 819.73 1019.39 819.73 901.075 910.32 21.93 11.01 9.53
painting 9.82 7.94 7.54 26.07 7.54 8.88 12.84 144.31 69.08 59.89
rendering 618.26 577.89 578.68 626.11 577.89 598.47 600.24 8.03 4.26 3.69
OPEN_MODAL
scripting 482.16 474.34 490.42 495.11 474.34 486.29 485.51 4.28 1.89 1.64
painting 9.26 8.06 21.43 17.78 8.06 13.52 14.13 94.62 46.07 39.92
rendering 1232.75 1251.2 1198.75 1246.48 1198.75 1239.615 1232.3 4.26 1.92 1.67
CLOSE_MODAL
scripting 222.15 214.86 225.23 219.07 214.86 220.61 220.33 4.71 2.01 1.74
painting 8.27 8.44 5.39 5.63 5.39 6.949999999999999 6.93 44.01 23.81 20.63
rendering 921.36 880.97 911.97 911.38 880.97 911.675 906.42 4.46 1.94 1.68

github-actions[bot] avatar Oct 06 '22 08:10 github-actions[bot]

@rimildeyjsr I am getting bad request error, not sure if this is error due to action selector please check Screen Recording 2022-10-12 at

https://user-images.githubusercontent.com/80756091/195245899-876b0eed-dab3-4dac-9a56-2d7c16213c2a.mov

9.15.21 AM

AnandiKulkarni avatar Oct 12 '22 03:10 AnandiKulkarni

/ok-to-test sha=53b20ab

rimildeyjsr avatar Oct 16 '22 10:10 rimildeyjsr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3259166183. Workflow: Appsmith External Integration Test Workflow. Commit: 53b20ab. PR: 17084. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17084&runId=3259166183_1

github-actions[bot] avatar Oct 16 '22 10:10 github-actions[bot]

/ok-to-test sha=bdc2023

rimildeyjsr avatar Oct 19 '22 11:10 rimildeyjsr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3281677522. Workflow: Appsmith External Integration Test Workflow. Commit: bdc2023. PR: 17084. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17084&runId=3281677522_1

github-actions[bot] avatar Oct 19 '22 14:10 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 4 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Oct 20 '22 07:10 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 16 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Oct 20 '22 08:10 vercel[bot]

/ok-to-test sha=52f35ff

rimildeyjsr avatar Oct 20 '22 09:10 rimildeyjsr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3288676407. Workflow: Appsmith External Integration Test Workflow. Commit: 52f35ff. PR: 17084. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17084&runId=3288676407_1

github-actions[bot] avatar Oct 20 '22 10:10 github-actions[bot]

/ok-to-test sha=6cfbdc8

rimildeyjsr avatar Oct 20 '22 14:10 rimildeyjsr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3290858945. Workflow: Appsmith External Integration Test Workflow. Commit: 6cfbdc8. PR: 17084. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17084&runId=3290858945_1

github-actions[bot] avatar Oct 20 '22 16:10 github-actions[bot]

/ok-to-test sha=d2a5192

rimildeyjsr avatar Oct 21 '22 04:10 rimildeyjsr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3294934459. Workflow: Appsmith External Integration Test Workflow. Commit: d2a5192. PR: 17084. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17084&runId=3294934459_1

github-actions[bot] avatar Oct 21 '22 05:10 github-actions[bot]