appsmith
appsmith copied to clipboard
appsmithorg
fix: Form and JSONForm reskinning
Description
Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #15171 Fixes #10977
if no issue exists, please create an issue and ask the maintainers about this first
Type of change
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.
- Test A
- Test B
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Sep 26, 2022 at 4:08PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Tested this for:
- UI inconsistencies in RTE, Form and JSON Form reskinning
- Fixes one small color bug for checkbox in disabled state
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3110965045.
Workflow: Appsmith External Integration Test Workflow.
Commit: a0abade.
PR: 16956.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3111779841.
Workflow: Appsmith External Integration Test Workflow.
Commit: 72156eb.
PR: 16956.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3111779841.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 356.16 | 367.74 | 398.86 | 467.29 | 389.51 | 356.16 | 389.51 | 395.91 | 28.07 | 10.95 | 9.80 |
| painting | 9.48 | 4.08 | 5.9 | 4.05 | 4.15 | 4.05 | 4.15 | 5.53 | 98.19 | 42.31 | 37.79 |
| rendering | 105.46 | 105.92 | 118.9 | 116.32 | 106.47 | 105.46 | 106.47 | 110.61 | 12.15 | 5.84 | 5.23 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 1077.62 | 1071.9 | 1184.4 | 1132.75 | 1133.53 | 1071.9 | 1132.75 | 1120.04 | 10.04 | 4.14 | 3.70 |
| painting | 20.43 | 18.66 | 26.1 | 36.37 | 24.14 | 18.66 | 24.14 | 25.14 | 70.45 | 27.57 | 24.66 |
| rendering | 834.27 | 798.11 | 872.4 | 874.46 | 867.29 | 798.11 | 867.29 | 849.31 | 8.99 | 3.88 | 3.47 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 1048.73 | 973.99 | 954.25 | 1068.93 | 837.09 | 837.09 | 973.99 | 976.6 | 23.74 | 9.40 | 8.41 |
| painting | 12.42 | 17.44 | 14.73 | 10.71 | 10.37 | 10.37 | 12.42 | 13.13 | 53.85 | 22.54 | 20.18 |
| rendering | 329.38 | 295.54 | 311.28 | 308.02 | 292.45 | 292.45 | 308.02 | 307.33 | 12.02 | 4.78 | 4.28 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 1652.07 | 1434.35 | 1323.18 | 1611.59 | 1548.68 | 1323.18 | 1548.68 | 1513.97 | 21.72 | 8.90 | 7.96 |
| painting | 17.56 | 14.29 | 13.38 | 17.94 | 16 | 13.38 | 16 | 15.83 | 28.81 | 12.57 | 11.24 |
| rendering | 513 | 465.58 | 438.22 | 505.21 | 460.25 | 438.22 | 465.58 | 476.45 | 15.70 | 6.64 | 5.94 |
| OPEN_MODAL | |||||||||||
| scripting | 522.26 | 483.52 | 444.65 | 514.27 | 937.34 | 444.65 | 514.27 | 580.41 | 84.89 | 34.78 | 31.11 |
| painting | 21.61 | 8.69 | 14.47 | 18.14 | 9.56 | 8.69 | 14.47 | 14.49 | 89.16 | 38.10 | 34.09 |
| rendering | 402.63 | 382.64 | 390.19 | 407.4 | 387.75 | 382.64 | 390.19 | 394.12 | 6.28 | 2.65 | 2.37 |
| CLOSE_MODAL | |||||||||||
| scripting | 181.61 | 233.95 | 189.64 | 242.87 | 192.28 | 181.61 | 192.28 | 208.07 | 29.44 | 13.53 | 12.10 |
| painting | 18.82 | 4.66 | 4.64 | 13.58 | 14.34 | 4.64 | 13.58 | 11.21 | 126.49 | 56.29 | 50.40 |
| rendering | 342.11 | 333.79 | 336.26 | 346.96 | 331.92 | 331.92 | 336.26 | 338.21 | 4.45 | 1.84 | 1.64 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 1031.39 | 959.83 | 980.92 | 1028.25 | 976.83 | 959.83 | 980.92 | 995.44 | 7.19 | 3.25 | 2.91 |
| painting | 10.06 | 9.88 | 5.36 | 11.34 | 6.5 | 5.36 | 9.88 | 8.63 | 69.29 | 29.66 | 26.54 |
| rendering | 659.06 | 609.7 | 631.74 | 678.13 | 608.94 | 608.94 | 631.74 | 637.51 | 10.85 | 4.80 | 4.29 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 192.83 | 163.67 | 186.14 | 168.41 | 185.29 | 163.67 | 185.29 | 179.27 | 16.27 | 7.00 | 6.25 |
| painting | 19.4 | 3.66 | 9.94 | 5.12 | 7.8 | 3.66 | 7.8 | 9.18 | 171.46 | 67.54 | 60.46 |
| rendering | 352.43 | 312.48 | 330.73 | 324.81 | 318.5 | 312.48 | 324.81 | 327.79 | 12.19 | 4.69 | 4.19 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3125299926.
Workflow: Appsmith External Integration Test Workflow.
Commit: d02b5ea.
PR: 16956.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3125808513.
Workflow: Appsmith External Integration Test Workflow.
Commit: ab3bd31.
PR: 16956.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3125808513.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 355.2 | 330.98 | 360.06 | 356.76 | 336.18 | 330.98 | 355.2 | 347.84 | 8.36 | 3.81 | 3.41 |
| painting | 6.66 | 6.29 | 4.73 | 4.54 | 3.63 | 3.63 | 4.73 | 5.17 | 58.61 | 24.56 | 21.86 |
| rendering | 107.32 | 105.56 | 108.01 | 104.93 | 103.81 | 103.81 | 105.56 | 105.93 | 3.96 | 1.62 | 1.45 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 1041.61 | 1061.36 | 1146.43 | 1991.43 | 1061.04 | 1041.61 | 1061.36 | 1260.37 | 75.36 | 32.58 | 29.14 |
| painting | 15.69 | 20.04 | 20.09 | 38.52 | 17.14 | 15.69 | 20.04 | 22.3 | 102.38 | 41.57 | 37.17 |
| rendering | 790.23 | 787.03 | 842.27 | 739.91 | 784.75 | 739.91 | 787.03 | 788.84 | 12.98 | 4.60 | 4.12 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 867.84 | 915.94 | 955.13 | 1540.11 | 927.55 | 867.84 | 927.55 | 1041.31 | 64.56 | 26.95 | 24.10 |
| painting | 11.66 | 12.02 | 11.97 | 23.93 | 10.32 | 10.32 | 11.97 | 13.98 | 97.35 | 40.06 | 35.84 |
| rendering | 309.77 | 300.4 | 316.75 | 437.65 | 284.01 | 284.01 | 309.77 | 329.72 | 46.60 | 18.67 | 16.70 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 1536.88 | 1463.39 | 1515.05 | 2315.73 | 1382.74 | 1382.74 | 1515.05 | 1642.76 | 56.79 | 23.18 | 20.74 |
| painting | 13.85 | 20.57 | 16.42 | 25.35 | 13.46 | 13.46 | 16.42 | 17.93 | 66.31 | 28.00 | 25.04 |
| rendering | 464.83 | 480.94 | 472.59 | 558.52 | 477.71 | 464.83 | 477.71 | 490.92 | 19.08 | 7.80 | 6.97 |
| OPEN_MODAL | |||||||||||
| scripting | 461.41 | 435.74 | 459.94 | 996.87 | 463.16 | 435.74 | 461.41 | 563.42 | 99.59 | 43.05 | 38.51 |
| painting | 13.7 | 11.23 | 17.55 | 27.35 | 9.68 | 9.68 | 13.7 | 15.9 | 111.13 | 44.40 | 39.69 |
| rendering | 400.55 | 379.66 | 382.62 | 650.31 | 390.71 | 379.66 | 390.71 | 440.77 | 61.40 | 26.64 | 23.83 |
| CLOSE_MODAL | |||||||||||
| scripting | 204.7 | 213.24 | 163.1 | 283 | 170.03 | 163.1 | 204.7 | 206.81 | 57.98 | 23.08 | 20.64 |
| painting | 9.79 | 17.75 | 8.55 | 6.77 | 4.21 | 4.21 | 8.55 | 9.41 | 143.89 | 54.30 | 48.57 |
| rendering | 341.99 | 328.67 | 325.61 | 382.72 | 326.29 | 325.61 | 328.67 | 341.06 | 16.74 | 7.10 | 6.35 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 923.68 | 943.09 | 995.65 | 948.03 | 910.66 | 910.66 | 943.09 | 944.22 | 9.00 | 3.44 | 3.07 |
| painting | 5.53 | 11.77 | 6.9 | 5.24 | 5.25 | 5.24 | 5.53 | 6.94 | 94.09 | 40.20 | 35.88 |
| rendering | 588.42 | 595.59 | 625.39 | 587.29 | 596.78 | 587.29 | 595.59 | 598.69 | 6.36 | 2.59 | 2.32 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 151.84 | 156.17 | 181 | 163.39 | 149.9 | 149.9 | 156.17 | 160.46 | 19.38 | 7.85 | 7.02 |
| painting | 2.72 | 3.9 | 3.94 | 2.03 | 7.16 | 2.03 | 3.9 | 3.95 | 129.87 | 49.87 | 44.56 |
| rendering | 299.95 | 305.92 | 324.17 | 297.61 | 303.83 | 297.61 | 303.83 | 306.3 | 8.67 | 3.43 | 3.07 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3129255446.
Workflow: Appsmith External Integration Test Workflow.
Commit: 937431f.
PR: 16956.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3129255446.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 394.86 | 422.61 | 714.5 | 376.4 | 358.39 | 358.39 | 394.86 | 453.35 | 78.55 | 32.63 | 29.18 |
| painting | 5.2 | 5.89 | 6.29 | 10.14 | 3.22 | 3.22 | 5.89 | 6.15 | 112.52 | 40.98 | 36.75 |
| rendering | 114.35 | 116.09 | 145.08 | 110.14 | 112.78 | 110.14 | 114.35 | 119.69 | 29.19 | 12.00 | 10.74 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 1212.78 | 1245.98 | 2080.18 | 1690.14 | 1075.98 | 1075.98 | 1245.98 | 1461.01 | 68.73 | 28.47 | 25.46 |
| painting | 29.64 | 33.84 | 37.9 | 23.45 | 20.23 | 20.23 | 29.64 | 29.01 | 60.91 | 25.03 | 22.37 |
| rendering | 927.2 | 959.62 | 991.29 | 565.95 | 864.39 | 565.95 | 927.2 | 861.69 | 49.36 | 19.94 | 17.84 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 984.31 | 1065.99 | 1971.97 | 1105.05 | 900.64 | 900.64 | 1065.99 | 1205.59 | 88.86 | 36.13 | 32.32 |
| painting | 11.57 | 13.41 | 29.9 | 12.34 | 9.39 | 9.39 | 12.34 | 15.32 | 133.88 | 54.05 | 48.37 |
| rendering | 333.46 | 364.82 | 486 | 356.17 | 309.75 | 309.75 | 356.17 | 370.04 | 47.63 | 18.45 | 16.50 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 1737.41 | 1787.84 | 1687.28 | 1621.18 | 1944.08 | 1621.18 | 1737.41 | 1755.56 | 18.39 | 6.96 | 6.22 |
| painting | 16.69 | 22.56 | 19.24 | 18.15 | 13.68 | 13.68 | 18.15 | 18.06 | 49.17 | 18.11 | 16.17 |
| rendering | 491.87 | 519.97 | 555.24 | 508.81 | 479.84 | 479.84 | 508.81 | 511.15 | 14.75 | 5.69 | 5.09 |
| OPEN_MODAL | |||||||||||
| scripting | 559.04 | 538.87 | 533.41 | 451.03 | 506.82 | 451.03 | 533.41 | 517.83 | 20.86 | 8.06 | 7.21 |
| painting | 10.82 | 14.16 | 13.26 | 8.59 | 15.25 | 8.59 | 13.26 | 12.42 | 53.62 | 21.66 | 19.40 |
| rendering | 428.78 | 409.6 | 405.56 | 399.78 | 408.58 | 399.78 | 408.58 | 410.46 | 7.07 | 2.66 | 2.38 |
| CLOSE_MODAL | |||||||||||
| scripting | 235.57 | 200.82 | 232.76 | 181.26 | 680.67 | 181.26 | 232.76 | 306.22 | 163.09 | 68.76 | 61.50 |
| painting | 6.35 | 5.06 | 14.49 | 4.53 | 4.43 | 4.43 | 5.06 | 6.97 | 144.33 | 61.26 | 54.81 |
| rendering | 382.74 | 358.67 | 396 | 341.5 | 349.29 | 341.5 | 358.67 | 365.64 | 14.91 | 6.28 | 5.62 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 1051.04 | 1098.54 | 1113.4 | 989.46 | 1004.51 | 989.46 | 1051.04 | 1051.39 | 11.79 | 5.23 | 4.68 |
| painting | 8.28 | 10.7 | 15.73 | 6.5 | 7.71 | 6.5 | 8.28 | 9.78 | 94.38 | 37.42 | 33.44 |
| rendering | 666.55 | 701.24 | 702.07 | 656.96 | 641.48 | 641.48 | 666.55 | 673.66 | 8.99 | 4.02 | 3.60 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 170.14 | 187.09 | 240.54 | 188.87 | 173.6 | 170.14 | 187.09 | 192.05 | 36.66 | 14.74 | 13.18 |
| painting | 6.4 | 3.77 | 7.61 | 2.99 | 3.15 | 2.99 | 3.77 | 4.78 | 96.65 | 43.72 | 39.12 |
| rendering | 326.89 | 333.68 | 359.5 | 319.58 | 328.44 | 319.58 | 328.44 | 333.62 | 11.97 | 4.59 | 4.11 |