appsmith
appsmith copied to clipboard
appsmithorg
fix: Add collapse icon for bottom bar
Fixes #16855
Description
Cypress:
- Added EntityBottomBar_spec.ts.
- Created an object registry for commonly used methods in debugger.
- Cleaned up debugger locators
Functional:
Add collapse icon for bottom bar in query and api pages. Open collapsed bottom bar on header click.
- Added
containerRefandexpandedHeightprops to bottom bar component. This was being checked internally to enable the collapse icon. - Also fixed alignment for result and status text.
- Changed collapse icon to arrow down in debugger, to keep things consistent.
- Made Debugger/API/Query/Js bottom panes similar in height
- Removed unwanted padding in api response view. (helps remove nested scroll bars)
API:
Query:
Debugger:
Type of change
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Oct 20, 2022 at 7:33AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3172530753.
Workflow: Appsmith External Integration Test Workflow.
Commit: 09325b1.
PR: 16939.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3172530753.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 332.68 | 325.79 | 337.56 | 468.42 | 451.53 | 325.79 | 337.56 | 383.2 | 37.22 | 18.39 | 16.45 |
| painting | 3.35 | 9.6 | 3.4 | 11.07 | 5.1 | 3.35 | 5.1 | 6.5 | 118.77 | 55.54 | 49.54 |
| rendering | 103.15 | 103.08 | 105.54 | 121.04 | 117.97 | 103.08 | 105.54 | 110.16 | 16.30 | 7.86 | 7.04 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 1160.7 | 1095.61 | 1089.83 | 1308.87 | 1230.43 | 1089.83 | 1160.7 | 1177.09 | 18.61 | 7.92 | 7.08 |
| painting | 19.79 | 25.66 | 26.24 | 41.69 | 31.65 | 19.79 | 26.24 | 29.01 | 75.49 | 28.40 | 25.41 |
| rendering | 804.49 | 842.24 | 844.12 | 1134.44 | 937.65 | 804.49 | 844.12 | 912.59 | 36.16 | 14.62 | 13.07 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 805.58 | 868.58 | 1280.68 | 1765.19 | 888.05 | 805.58 | 888.05 | 1121.62 | 85.56 | 36.16 | 32.34 |
| painting | 8.92 | 10.87 | 17.2 | 20.45 | 8.03 | 8.03 | 10.87 | 13.09 | 94.88 | 41.63 | 37.28 |
| rendering | 312.93 | 298.2 | 321.97 | 387.58 | 291.33 | 291.33 | 312.93 | 322.4 | 29.85 | 11.90 | 10.65 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 1428.8 | 1451.63 | 1581.93 | 1844.63 | 1416.89 | 1416.89 | 1451.63 | 1544.78 | 27.69 | 11.66 | 10.43 |
| painting | 16.97 | 23.26 | 17.49 | 22.12 | 15.68 | 15.68 | 17.49 | 19.1 | 39.69 | 17.59 | 15.76 |
| rendering | 594.07 | 635.16 | 638.56 | 713.85 | 601.25 | 594.07 | 635.16 | 636.58 | 18.82 | 7.46 | 6.68 |
| OPEN_MODAL | |||||||||||
| scripting | 442.08 | 477.4 | 457.34 | 693.09 | 438.08 | 438.08 | 457.34 | 501.6 | 50.84 | 21.56 | 19.29 |
| painting | 13.28 | 8.83 | 16.73 | 16.46 | 15.86 | 8.83 | 15.86 | 14.23 | 55.52 | 23.26 | 20.80 |
| rendering | 1212.02 | 1199.73 | 1203.27 | 1804.89 | 1125.29 | 1125.29 | 1203.27 | 1309.04 | 51.92 | 21.34 | 19.09 |
| CLOSE_MODAL | |||||||||||
| scripting | 204.97 | 229.63 | 181.74 | 475.59 | 168.94 | 168.94 | 204.97 | 252.17 | 121.60 | 50.37 | 45.05 |
| painting | 8.07 | 6.19 | 8.9 | 8.72 | 14.17 | 6.19 | 8.72 | 9.21 | 86.64 | 32.25 | 28.88 |
| rendering | 867.04 | 888.09 | 887.81 | 1879.79 | 845.77 | 845.77 | 887.81 | 1073.7 | 96.30 | 42.00 | 37.57 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 974.67 | 987.79 | 1275.4 | 935.08 | 952.89 | 935.08 | 974.67 | 1025.17 | 33.20 | 13.79 | 12.33 |
| painting | 6.23 | 9.5 | 10.65 | 5.43 | 5.28 | 5.28 | 6.23 | 7.42 | 72.37 | 33.56 | 29.92 |
| rendering | 663.66 | 687.27 | 822.7 | 652.22 | 645.66 | 645.66 | 663.66 | 694.3 | 25.50 | 10.59 | 9.47 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 150.14 | 157.3 | 317.75 | 158.16 | 156.46 | 150.14 | 157.3 | 187.96 | 89.17 | 38.64 | 34.56 |
| painting | 3.29 | 3.95 | 4.25 | 3.14 | 2.45 | 2.45 | 3.29 | 3.42 | 52.63 | 20.76 | 18.42 |
| rendering | 308.17 | 315.52 | 648.66 | 311.23 | 298.56 | 298.56 | 311.23 | 376.43 | 93.01 | 40.46 | 36.19 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3172530753.
Workflow: Appsmith External Integration Test Workflow.
Commit: 09325b1.
PR: 16939.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3172530753.
Workflow: Appsmith External Integration Test Workflow.
Commit: 09325b1.
PR: 16939.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3179441599.
Workflow: Appsmith External Integration Test Workflow.
Commit: 683fc59.
PR: 16939.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3179441599.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 335.99 | 352.13 | 330.57 | 355.76 | 325.49 | 325.49 | 335.99 | 339.99 | 8.90 | 3.92 | 3.51 |
| painting | 7.1 | 5.06 | 7.76 | 4.57 | 7.28 | 4.57 | 7.1 | 6.35 | 50.24 | 22.68 | 20.16 |
| rendering | 105.04 | 104.44 | 102.91 | 101.06 | 100.65 | 100.65 | 102.91 | 102.82 | 4.27 | 1.91 | 1.70 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 1046.53 | 1057.83 | 1045.4 | 991.85 | 1062.82 | 991.85 | 1046.53 | 1040.89 | 6.82 | 2.73 | 2.44 |
| painting | 14.26 | 16.06 | 13.91 | 16.97 | 16.72 | 13.91 | 16.06 | 15.58 | 19.64 | 9.05 | 8.09 |
| rendering | 773.62 | 781.72 | 773.71 | 764.02 | 784.72 | 764.02 | 773.71 | 775.56 | 2.67 | 1.04 | 0.93 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 811.19 | 908.98 | 860.28 | 1009.28 | 863.39 | 811.19 | 863.39 | 890.62 | 22.24 | 8.40 | 7.51 |
| painting | 11.88 | 11.63 | 13.57 | 8.09 | 8.9 | 8.09 | 11.63 | 10.81 | 50.69 | 20.91 | 18.69 |
| rendering | 289.79 | 296.24 | 291.42 | 291.23 | 294.37 | 289.79 | 291.42 | 292.61 | 2.20 | 0.90 | 0.80 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 1476.56 | 1350.72 | 1392.5 | 1348.01 | 1809.24 | 1348.01 | 1392.5 | 1475.41 | 31.26 | 13.13 | 11.74 |
| painting | 13.2 | 13.75 | 14.38 | 13.03 | 22.89 | 13.03 | 13.75 | 15.45 | 63.82 | 27.12 | 24.27 |
| rendering | 591.49 | 592.49 | 586.12 | 583.11 | 580.04 | 580.04 | 586.12 | 586.65 | 2.12 | 0.91 | 0.81 |
| OPEN_MODAL | |||||||||||
| scripting | 463.95 | 420.35 | 466.03 | 425.96 | 425.55 | 420.35 | 425.96 | 440.37 | 10.37 | 5.13 | 4.59 |
| painting | 15.85 | 16.68 | 14.58 | 14.59 | 14.26 | 14.26 | 14.59 | 15.19 | 15.93 | 6.78 | 6.06 |
| rendering | 1196.67 | 1157.96 | 1153.41 | 1128.59 | 1138.16 | 1128.59 | 1153.41 | 1154.96 | 5.89 | 2.26 | 2.02 |
| CLOSE_MODAL | |||||||||||
| scripting | 202.27 | 646.96 | 209.76 | 199.39 | 182.95 | 182.95 | 202.27 | 288.27 | 160.96 | 69.64 | 62.29 |
| painting | 11.91 | 15.04 | 16.28 | 21.77 | 8.43 | 8.43 | 15.04 | 14.69 | 90.81 | 33.97 | 30.43 |
| rendering | 904.91 | 875.84 | 851.85 | 844.66 | 877.96 | 844.66 | 875.84 | 871.04 | 6.92 | 2.74 | 2.45 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 913.14 | 946.6 | 904.42 | 913.8 | 949.8 | 904.42 | 913.8 | 925.55 | 4.90 | 2.27 | 2.03 |
| painting | 6.5 | 5.42 | 16.94 | 4.63 | 5.06 | 4.63 | 5.42 | 7.71 | 159.66 | 67.57 | 60.44 |
| rendering | 646.49 | 630.31 | 631.74 | 648.08 | 638.21 | 630.31 | 638.21 | 638.97 | 2.78 | 1.28 | 1.14 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 150.02 | 151.04 | 153.26 | 154.44 | 150.64 | 150.02 | 151.04 | 151.88 | 2.91 | 1.24 | 1.11 |
| painting | 3.41 | 5.17 | 2.33 | 2.24 | 3.39 | 2.24 | 3.39 | 3.31 | 88.52 | 35.65 | 32.02 |
| rendering | 298.52 | 307.78 | 303.52 | 307.24 | 305.36 | 298.52 | 305.36 | 304.48 | 3.04 | 1.23 | 1.10 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3181031280.
Workflow: Appsmith External Integration Test Workflow.
Commit: 00a9645.
PR: 16939.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3183116697.
Workflow: Appsmith External Integration Test Workflow.
Commit: 55cfa05.
PR: 16939.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3183116697.
Workflow: Appsmith External Integration Test Workflow.
Commit: 55cfa05.
PR: 16939.