feat: Map Chart Reskinning

[dhruvikn]

Description

This PR fixes UI inconsistencies in the Map Chart widget.

• Use font Family from the theme
• Fix caption styles
• Fix legend styles
• Fix chart spacing

Another PR, #16922, has been raised which adds the changes required to inherit font family from system themes. #16922 should be merged before this PR to enable testing on DPs.

Fixes #10981

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Manually (a fresh local backend build was used to test theming).
• Tested migrations by creating an app on release, then importing that app on local and testing the font family.

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Sep 23, 2022 at 7:56AM (UTC)

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[jsartisan]

Do we need migration for this PR that will add font family to the existing app's map chart? @dilippitchika

[dilippitchika]

Yes for existing themes we should handle it

[dhruvikn]

@jsartisan @dilippitchika, have added migrations.

[github-actions[bot]]

Unable to find test scripts. Please add necessary tests to the PR.

[dhruvikn]

/ok-to-test sha=fc93433

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3112250589. Workflow: Appsmith External Integration Test Workflow. Commit: fc93433. PR: 16921.

[github-actions[bot]]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3112250589. Commit: ``. Results:

Click to view performance test results

	Run 1 (ms)	Run 2 (ms)	Run 3 (ms)	Run 4 (ms)	Run 5 (ms)	Minimum (ms)	Median (ms)	Mean (ms)	Range (%)	SD.Sample (%)	SD.Population (%)
SELECT_CATEGORY
scripting	1274.54	369.69	395.59	597.92	346.41	346.41	395.59	596.83	155.51	65.65	58.72
painting	4.07	5.07	3.83	5.27	8	3.83	5.07	5.25	79.43	31.62	28.19
rendering	114.74	106.47	127.41	170.13	105.99	105.99	114.74	124.95	51.33	21.37	19.12
BIND_TABLE_DATA
scripting	1748.84	1096.36	1186.93	1258.44	1126.53	1096.36	1186.93	1283.42	50.84	20.84	18.64
painting	38.82	25.31	29.66	26.55	20.1	20.1	26.55	28.09	66.64	24.64	22.04
rendering	637.83	862.35	890.24	930.88	818.19	637.83	862.35	827.9	35.40	13.76	12.31
CLICK_ON_TABLE_ROW
scripting	1343.8	976.85	1019.24	1037.51	942.96	942.96	1019.24	1064.07	37.67	15.10	13.50
painting	16.3	13.64	15.11	18.45	14.04	13.64	15.11	15.51	31.01	12.51	11.22
rendering	496.02	310.96	330.94	319.84	309.97	309.97	319.84	353.55	52.62	22.65	20.26
UPDATE_POST_TITLE
scripting	2923.3	1465.15	1451.22	1815.36	1467.71	1451.22	1467.71	1824.55	80.68	34.70	31.04
painting	30.53	24.44	17.39	24.06	14.38	14.38	24.06	22.16	72.88	28.75	25.68
rendering	660.5	483.57	478.79	544.15	461.96	461.96	483.57	525.79	37.76	15.49	13.86
OPEN_MODAL
scripting	698.05	462.45	552.97	552.92	445.61	445.61	552.92	542.4	46.54	18.48	16.53
painting	21.03	22.41	12.21	9.91	17.38	9.91	17.38	16.59	75.35	32.73	29.29
rendering	454.46	382.62	421.41	397.85	378.82	378.82	397.85	407.03	18.58	7.70	6.89
CLOSE_MODAL
scripting	253.43	668.34	269.76	314.74	604.43	253.43	314.74	422.14	98.29	46.94	41.99
painting	12.25	9.53	11.25	7.35	7.2	7.2	9.53	9.52	53.05	23.84	21.32
rendering	411.16	362.4	366.7	388.63	334.7	334.7	366.7	372.72	20.51	7.73	6.91
SELECT_WIDGET_MENU_OPEN
scripting	1032.92	1014.07	1012.88	1016.2	974.87	974.87	1014.07	1010.19	5.75	2.11	1.89
painting	11.09	7.39	6.67	7.12	10.45	6.67	7.39	8.54	51.76	24.12	21.55
rendering	673.47	650.57	649.42	650.3	621.16	621.16	650.3	648.98	8.06	2.86	2.56
SELECT_WIDGET_SELECT_OPTION
scripting	170.8	166.55	184.42	176.49	169.46	166.55	170.8	173.54	10.30	4.07	3.65
painting	2.58	3.99	5.06	3.05	11.27	2.58	3.99	5.19	167.44	68.02	60.89
rendering	324.85	315.61	315.85	319.93	315.65	315.61	315.85	318.38	2.90	1.28	1.14

[SatishGandham]

/ok-to-test sha=fc93433

There are lot of negatives in the perf test, re running again.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3112860236. Workflow: Appsmith External Integration Test Workflow. Commit: fc93433. PR: 16921.

[github-actions[bot]]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3112860236. Commit: ``. Results:

Click to view performance test results

	Run 1 (ms)	Run 2 (ms)	Run 3 (ms)	Run 4 (ms)	Run 5 (ms)	Minimum (ms)	Median (ms)	Mean (ms)	Range (%)	SD.Sample (%)	SD.Population (%)
SELECT_CATEGORY
scripting	611.29	424.89	406	389.93	369.96	369.96	406	440.41	54.80	22.17	19.83
painting	5.68	5.68	7.8	3.96	3.35	3.35	5.68	5.29	84.12	32.89	29.49
rendering	179.81	117.04	115.64	111.56	109.21	109.21	115.64	126.65	55.74	23.59	21.11
BIND_TABLE_DATA
scripting	1742.74	1586.62	1069.35	1772.93	1134.97	1069.35	1586.62	1461.32	48.15	23.01	20.58
painting	38.9	27.77	27.26	29.07	24.69	24.69	27.77	29.54	48.10	18.52	16.55
rendering	753.59	532.14	888.9	623.26	874.26	532.14	753.59	734.43	48.58	21.21	18.97
CLICK_ON_TABLE_ROW
scripting	960.02	1087.27	1060.85	1225.67	917.46	917.46	1060.85	1050.25	29.35	11.47	10.26
painting	10.9	14.29	17.09	16.17	13.47	10.9	14.29	14.38	43.05	16.83	15.09
rendering	330.41	326.97	322.1	429.36	302.95	302.95	326.97	342.36	36.92	14.54	13.00
UPDATE_POST_TITLE
scripting	2215.36	1797.7	2978.93	2014.79	1368.71	1368.71	2014.79	2075.1	77.60	28.67	25.65
painting	22.78	18.98	30.22	19.99	14.3	14.3	19.99	21.25	74.92	27.62	24.71
rendering	541.58	531.38	714.82	549.29	460.99	460.99	541.58	559.61	45.36	16.73	14.96
OPEN_MODAL
scripting	536.2	522.32	1066.48	528.01	438.87	438.87	528.01	618.38	101.49	41.00	36.67
painting	11.02	10.26	33.65	10.59	9.88	9.88	10.59	15.08	157.63	68.90	61.60
rendering	435.26	418.48	782.6	401.31	383.74	383.74	418.48	484.28	82.36	34.66	31.00
CLOSE_MODAL
scripting	237.01	345.3	347.77	208.3	217.12	208.3	237.01	271.1	51.45	25.69	22.98
painting	6.45	9.11	8.99	4.94	3.8	3.8	6.45	6.66	79.73	35.74	31.98
rendering	374.13	410.2	563.29	362.54	321.67	321.67	374.13	406.37	59.46	22.94	20.52
SELECT_WIDGET_MENU_OPEN
scripting	1002.99	1050.86	1108.59	997.48	961.78	961.78	1002.99	1024.34	14.33	5.54	4.96
painting	6.04	11.79	21.61	5.32	4.97	4.97	6.04	9.95	167.24	71.26	63.72
rendering	647.17	678.07	747.75	633.35	612.74	612.74	647.17	663.82	20.34	7.92	7.09
SELECT_WIDGET_SELECT_OPTION
scripting	188.36	211.43	252.1	168.54	167.78	167.78	188.36	197.64	42.66	17.86	15.97
painting	4.46	3.32	6.43	2.8	2.56	2.56	3.32	3.91	98.98	40.66	36.32
rendering	352	336.7	406.34	325.85	318.98	318.98	336.7	347.97	25.11	10.04	8.98

[laveena-en]

Tested and verified.