appsmith
appsmith copied to clipboard
feat: migrate SearchSnippet
Description
This PR migrates the SearchSnippet component into the ads, and leaves the redux responsibilities with the parent. Closes #16884
Type of change
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Tested locally
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
appsmith | ✅ Ready (Inspect) | Visit Preview | Sep 26, 2022 at 3:01AM (UTC) |
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
/ok-to-test sha=003f3fb
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3088137706.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 003f3fb
.
PR: 16886.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3088137706.
Commit: ``.
Results: Click to view performance test results
| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 343.75 | 347.49 | 350.14 | 692.14 | 381.96 | 343.75| 350.14| 423.1 | 82.34| 35.73 | 31.96| | painting | 3.5 | 4.44 | 4.75 | 8.85 | 3.41 | 3.41| 4.44| 4.99 | 109.02| 44.69 | 40.08| | rendering | 106.63 | 104.27 | 110.74 | 130.28 | 111.08 | 104.27| 110.74| 112.6 | 23.10| 9.14 | 8.17| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1021.24 | 1095.17 | 1003.83 | 1997.19 | 1085.25 | 1003.83| 1085.25| 1240.54 | 80.07| 34.24 | 30.63| | painting | 16.28 | 15.2 | 14.82 | 34.43 | 24.75 | 14.82| 16.28| 21.1 | 92.94| 40.24 | 36.02| | rendering | 785.45 | 807.1 | 802.56 | 978.06 | 870.97 | 785.45| 807.1| 848.83 | 22.69| 9.33 | 8.35| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 811.09 | 905.9 | 955.8 | 1093.3 | 1066.32 | 811.09| 955.8| 966.48 | 29.20| 12.02 | 10.75| | painting | 10.97 | 9.34 | 17.21 | 16.12 | 11.38 | 9.34| 11.38| 13 | 60.54| 26.54 | 23.77| | rendering | 291.18 | 311.15 | 336.92 | 351.29 | 317.55 | 291.18| 317.55| 321.62 | 18.69| 7.24 | 6.47| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1476.37 | 1336.28 | 1511.74 | 1610.13 | 1582.33 | 1336.28| 1511.74| 1503.37 | 18.22| 7.16 | 6.40| | painting | 15.26 | 18.85 | 19.67 | 22.23 | 20.68 | 15.26| 19.67| 19.34 | 36.04| 13.44 | 12.05| | rendering | 608.21 | 615.38 | 658.31 | 637.66 | 673.94 | 608.21| 637.66| 638.7 | 10.29| 4.36 | 3.90| OPEN_MODAL| | | | | | | | | | | | scripting | 449.12 | 452.54 | 470.53 | 530.67 | 479.62 | 449.12| 470.53| 476.5 | 17.11| 6.88 | 6.16| | painting | 21.96 | 12.93 | 8.42 | 9.21 | 8.83 | 8.42| 9.21| 12.27 | 110.35| 46.54 | 41.65| | rendering | 1182.42 | 1298.43 | 1220.75 | 1298.69 | 1223.02 | 1182.42| 1223.02| 1244.66 | 9.34| 4.16 | 3.72| CLOSE_MODAL| | | | | | | | | | | | scripting | 208.45 | 233.04 | 203.81 | 204.24 | 227.52 | 203.81| 208.45| 215.41 | 13.57| 6.42 | 5.74| | painting | 14.24 | 4.44 | 4.87 | 11.72 | 13.16 | 4.44| 11.72| 9.69 | 101.14| 48.30 | 43.24| | rendering | 895.31 | 962.48 | 1054.09 | 923.3 | 1055.22 | 895.31| 962.48| 978.08 | 16.35| 7.55 | 6.76| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 928.62 | 952.68 | 1052.42 | 1032.75 | 1068.36 | 928.62| 1032.75| 1006.97 | 13.88| 6.20 | 5.54| | painting | 9.66 | 4.74 | 8.44 | 8.06 | 5.31 | 4.74| 8.06| 7.24 | 67.96| 29.28 | 26.10| | rendering | 656.93 | 633.77 | 759.95 | 709.98 | 692.5 | 633.77| 692.5| 690.63 | 18.27| 7.08 | 6.33| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 154.27 | 155.01 | 216.97 | 180.21 | 177.64 | 154.27| 177.64| 176.82 | 35.46| 14.44 | 12.92| | painting | 2.09 | 5.95 | 3.56 | 2.7 | 2.4 | 2.09| 2.7| 3.34 | 115.57| 46.71 | 41.62| | rendering | 307.38 | 311.72 | 347.37 | 347.05 | 320.01 | 307.38| 320.01| 326.71 | 12.24| 5.90 | 5.27|
This PR has been tested and no issues have been found.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3096984191.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 63c1c27
.
PR: 16886.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3096984191.
Commit: ``.
Results: Click to view performance test results
| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 395.09 | 600.21 | 401.14 | 368.67 | 352.63 | 352.63| 395.09| 423.55 | 58.45| 23.78 | 21.27| | painting | 3.97 | 6.24 | 4.83 | 6.26 | 6.47 | 3.97| 6.24| 5.55 | 45.05| 19.82 | 17.66| | rendering | 115.32 | 179.43 | 113.45 | 105.43 | 108.48 | 105.43| 113.45| 124.42 | 59.48| 24.92 | 22.29| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1172.68 | 1818.87 | 1021.71 | 1016.67 | 1088.1 | 1016.67| 1088.1| 1223.61 | 65.56| 27.68 | 24.76| | painting | 24.29 | 23.37 | 19.02 | 15.48 | 20.67 | 15.48| 20.67| 20.57 | 42.83| 17.21 | 15.36| | rendering | 929.67 | 646.47 | 841.52 | 786.91 | 844.48 | 646.47| 841.52| 809.81 | 34.97| 12.92 | 11.55| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 931.14 | 1277.23 | 939.57 | 908.8 | 967.43 | 908.8| 939.57| 1004.83 | 36.67| 15.30 | 13.68| | painting | 12.3 | 20.96 | 9.12 | 12.3 | 9.59 | 9.12| 12.3| 12.85 | 92.14| 37.12 | 33.15| | rendering | 319.08 | 385.8 | 324.29 | 298.92 | 324.13 | 298.92| 324.13| 330.44 | 26.29| 9.88 | 8.84| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1996.2 | 2045.13 | 1850.53 | 1424.13 | 1570.96 | 1424.13| 1850.53| 1777.39 | 34.94| 15.21 | 13.60| | painting | 25.51 | 19.39 | 15.51 | 13.41 | 18.88 | 13.41| 18.88| 18.54 | 65.26| 24.87 | 22.22| | rendering | 570.64 | 562.08 | 482.32 | 451.69 | 479.07 | 451.69| 482.32| 509.16 | 23.36| 10.53 | 9.42| OPEN_MODAL| | | | | | | | | | | | scripting | 557.05 | 825.81 | 459.02 | 447.99 | 562.66 | 447.99| 557.05| 570.51 | 66.22| 26.71 | 23.89| | painting | 17.02 | 21.11 | 12.73 | 10.05 | 16.58 | 10.05| 16.58| 15.5 | 71.35| 27.42 | 24.52| | rendering | 431.8 | 735.94 | 394.11 | 375.71 | 433.04 | 375.71| 431.8| 474.12 | 75.98| 31.30 | 28.00| CLOSE_MODAL| | | | | | | | | | | | scripting | 324.38 | 249.95 | 200.26 | 193.05 | 181.08 | 181.08| 200.26| 229.74 | 62.37| 25.70 | 22.99| | painting | 8.28 | 16.55 | 11.99 | 8.66 | 8.48 | 8.28| 8.66| 10.79 | 76.65| 32.99 | 29.56| | rendering | 398.43 | 458.65 | 360.39 | 357.74 | 348.32 | 348.32| 360.39| 384.71 | 28.68| 11.84 | 10.59| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 1194.75 | 1303.95 | 945.71 | 979.5 | 1170.55 | 945.71| 1170.55| 1118.89 | 32.02| 13.56 | 12.13| | painting | 9.38 | 11.96 | 6.85 | 7.44 | 12.42 | 6.85| 9.38| 9.61 | 57.96| 26.43 | 23.62| | rendering | 778.21 | 822.23 | 610.14 | 624.14 | 1167.7 | 610.14| 778.21| 800.48 | 69.65| 28.15 | 25.18| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 214.05 | 205.87 | 158.28 | 156.07 | 354.48 | 156.07| 205.87| 217.75 | 91.12| 37.16 | 33.24| | painting | 3.34 | 4.94 | 3.84 | 4.8 | 4.04 | 3.34| 4.04| 4.19 | 38.19| 15.99 | 14.32| | rendering | 361.96 | 418.62 | 315.66 | 316.15 | 660.17 | 315.66| 361.96| 414.51 | 83.11| 34.66 | 31.00|
/ok-to-test sha=6e9a1dc
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3124753092.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 6e9a1dc
.
PR: 16886.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3124753092.
Commit: ``.
Results: Click to view performance test results
Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
---|---|---|---|---|---|---|---|---|---|---|---|
SELECT_CATEGORY | |||||||||||
scripting | 338.42 | 364.04 | 333.53 | 403.66 | 339.91 | 333.53 | 339.91 | 355.91 | 19.70 | 8.20 | 7.34 |
painting | 3.44 | 7.4 | 3.05 | 3.35 | 3.97 | 3.05 | 3.44 | 4.24 | 102.59 | 42.45 | 37.97 |
rendering | 104.1 | 105.86 | 103.51 | 117.06 | 107.08 | 103.51 | 105.86 | 107.52 | 12.60 | 5.13 | 4.59 |
BIND_TABLE_DATA | |||||||||||
scripting | 1029.42 | 1051.26 | 1112.45 | 1259.27 | 1046.6 | 1029.42 | 1051.26 | 1099.8 | 20.90 | 8.59 | 7.69 |
painting | 16.67 | 15.35 | 18.61 | 24.72 | 17.56 | 15.35 | 17.56 | 18.58 | 50.43 | 19.54 | 17.49 |
rendering | 779.49 | 775.08 | 797.26 | 848.36 | 781.04 | 775.08 | 781.04 | 796.25 | 9.20 | 3.81 | 3.41 |
CLICK_ON_TABLE_ROW | |||||||||||
scripting | 800.72 | 873.1 | 902.19 | 1295.7 | 887.69 | 800.72 | 887.69 | 951.88 | 52.00 | 20.60 | 18.43 |
painting | 13.13 | 8.96 | 12.48 | 9.74 | 9.49 | 8.96 | 9.74 | 10.76 | 38.75 | 17.66 | 15.80 |
rendering | 295.33 | 308.94 | 294.2 | 325.58 | 291.75 | 291.75 | 295.33 | 303.16 | 11.16 | 4.69 | 4.19 |
UPDATE_POST_TITLE | |||||||||||
scripting | 1384.71 | 1278.77 | 1396.68 | 1356.58 | 1272.43 | 1272.43 | 1356.58 | 1337.83 | 9.29 | 4.39 | 3.92 |
painting | 14.08 | 12.31 | 13.3 | 15.91 | 12.33 | 12.31 | 13.3 | 13.59 | 26.49 | 10.96 | 9.86 |
rendering | 457.13 | 442.76 | 444.52 | 446.38 | 437.06 | 437.06 | 444.52 | 445.57 | 4.50 | 1.65 | 1.47 |
OPEN_MODAL | |||||||||||
scripting | 433.57 | 494.56 | 430.7 | 902.69 | 433.83 | 430.7 | 433.83 | 539.07 | 87.56 | 38.03 | 34.02 |
painting | 11.42 | 8.53 | 15.64 | 11.95 | 7.98 | 7.98 | 11.42 | 11.1 | 69.01 | 27.66 | 24.77 |
rendering | 367.72 | 361.77 | 386.39 | 374.75 | 369.63 | 361.77 | 369.63 | 372.05 | 6.62 | 2.49 | 2.23 |
CLOSE_MODAL | |||||||||||
scripting | 161.88 | 186.41 | 172.12 | 202.45 | 178.4 | 161.88 | 178.4 | 180.25 | 22.51 | 8.49 | 7.60 |
painting | 4.27 | 10.3 | 15.94 | 4.86 | 9.78 | 4.27 | 9.78 | 9.03 | 129.24 | 52.49 | 46.95 |
rendering | 336.25 | 347.35 | 335.59 | 343.45 | 337.21 | 335.59 | 337.21 | 339.97 | 3.46 | 1.52 | 1.36 |
SELECT_WIDGET_MENU_OPEN | |||||||||||
scripting | 925 | 931.43 | 960.54 | 919.23 | 931.93 | 919.23 | 931.43 | 933.63 | 4.42 | 1.71 | 1.53 |
painting | 8.62 | 4.89 | 5.68 | 5.15 | 8.64 | 4.89 | 5.68 | 6.6 | 56.82 | 28.48 | 25.45 |
rendering | 586.86 | 573.04 | 601.83 | 582.08 | 591.82 | 573.04 | 586.86 | 587.13 | 4.90 | 1.83 | 1.64 |
SELECT_WIDGET_SELECT_OPTION | |||||||||||
scripting | 155.76 | 157.07 | 155.91 | 148.73 | 163.34 | 148.73 | 155.91 | 156.16 | 9.36 | 3.32 | 2.97 |
painting | 3.52 | 3.83 | 3.47 | 3.75 | 4.61 | 3.47 | 3.75 | 3.84 | 29.69 | 11.98 | 10.68 |
rendering | 306.05 | 294.64 | 309.59 | 300.07 | 301.36 | 294.64 | 301.36 | 302.34 | 4.94 | 1.90 | 1.70 |