fix: return statement is not necessary to execute .then and .catch's execution

[ApekshaBhosale]

Description

One needs to return the function so .then and .catch to be executed Previous architecture - https://www.notion.so/appsmith/Architecture-problems-ff74dd3415d24458b9531d788971ec2a New architecture - https://www.notion.so/appsmith/new-architecture-for-promises-335bfa61905c49ef90e05afb5c95a390

Fixes # (issue) https://github.com/appsmithorg/appsmith/issues/9782

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

• Test A
• Test B

Checklist:

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Sep 29, 2022 at 2:25PM (UTC)

[ApekshaBhosale]

/ok-to-test sha=b2085a2

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3087847336. Workflow: Appsmith External Integration Test Workflow. Commit: b2085a2. PR: 16802.

[ApekshaBhosale]

/ok-to-test sha=e4dce1b

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3088103557. Workflow: Appsmith External Integration Test Workflow. Commit: e4dce1b. PR: 16802.

[ApekshaBhosale]

/ok-to-test sha=bb5c7c5

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3088191304. Workflow: Appsmith External Integration Test Workflow. Commit: bb5c7c5. PR: 16802.

[ApekshaBhosale]

/ok-to-test sha=257bac3

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3088718427. Workflow: Appsmith External Integration Test Workflow. Commit: 257bac3. PR: 16802.

[ApekshaBhosale]

/ok-to-test sha=49ac925

[ApekshaBhosale]

/ok-to-test sha=49ac925

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097430659. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097431745. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097431790. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097432246. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097432309. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097432421. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097432772. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097433012. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[arunvjn]

/ok-to-test sha=49ac925

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3105882281. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[ApekshaBhosale]

/ok-to-test sha=49ac925

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3111833116. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[github-actions[bot]]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3111833116. Commit: ``. Results:

Click to view performance test results

	Run 1 (ms)	Run 2 (ms)	Run 3 (ms)	Run 4 (ms)	Run 5 (ms)	Minimum (ms)	Median (ms)	Mean (ms)	Range (%)	SD.Sample (%)	SD.Population (%)
SELECT_CATEGORY
scripting	343.62	345.8	374.44	707.59	705.94	343.62	374.44	495.48	73.46	39.00	34.89
painting	4.01	6.51	6.86	6.49	8.92	4.01	6.51	6.56	74.85	26.52	23.78
rendering	104.49	107.52	105.26	200.23	179.47	104.49	107.52	139.39	68.68	33.47	29.94
BIND_TABLE_DATA
scripting	1117.81	1073.51	1040.56	1390.15	1702.97	1040.56	1117.81	1265	52.36	22.23	19.88
painting	17.08	17.17	10.74	25.88	19.85	10.74	17.17	18.14	83.46	30.15	26.96
rendering	812.59	785.21	793.82	1058.5	603.96	603.96	793.82	810.82	56.06	19.99	17.88
CLICK_ON_TABLE_ROW
scripting	803.43	940.21	876.8	1565.44	1567.96	803.43	940.21	1150.77	66.44	33.26	29.75
painting	10.08	10.86	13.95	20.43	21.04	10.08	13.95	15.27	71.77	34.05	30.45
rendering	298.81	314.69	297.81	542.56	422.87	297.81	314.69	375.35	65.21	28.50	25.49
UPDATE_POST_TITLE
scripting	1467.77	1454.91	1441.51	2543.98	2248.71	1441.51	1467.77	1831.38	60.20	28.74	25.70
painting	12.09	15.65	16.35	32.99	24.1	12.09	16.35	20.24	103.26	41.35	36.96
rendering	440.79	460.8	469.38	690.69	789.45	440.79	469.38	570.22	61.14	27.93	24.98
OPEN_MODAL
scripting	446.4	431.35	471.51	552.78	674.52	431.35	471.51	515.31	47.19	19.52	17.46
painting	9.88	12.24	10.85	15.54	36.65	9.88	12.24	17.03	157.19	65.59	58.66
rendering	380.25	359.01	395.94	448.68	447.12	359.01	395.94	406.2	22.08	9.91	8.87
CLOSE_MODAL
scripting	176.25	212.33	175.06	251.71	268.84	175.06	212.33	216.84	43.25	19.75	17.66
painting	13.84	9.29	8.54	7.47	12.62	7.47	9.29	10.35	61.55	26.47	23.67
rendering	323.7	356.04	337.8	421.17	416.72	323.7	356.04	371.09	26.27	12.18	10.89
SELECT_WIDGET_MENU_OPEN
scripting	907.55	961.65	937.06	1425.23	1037.28	907.55	961.65	1053.75	49.13	20.23	18.09
painting	5.27	6.79	10.36	12.33	10.91	5.27	10.36	9.13	77.33	32.53	29.13
rendering	580.44	593.47	595.91	1030.35	660.08	580.44	595.91	692.05	65.01	27.69	24.77
SELECT_WIDGET_SELECT_OPTION
scripting	156.88	186.69	206.01	278.64	214.7	156.88	206.01	208.58	58.38	21.58	19.30
painting	2.02	5.92	5.18	6.15	2.84	2.02	5.18	4.42	93.44	42.53	38.01
rendering	319.31	306.39	328.61	396.47	352.55	306.39	328.61	340.67	26.44	10.41	9.31

[arunvjn]

/ok-to-test sha=49ac925

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3141300324. Workflow: Appsmith External Integration Test Workflow. Commit: 49ac925. PR: 16802.

[arunvjn]

/ok-to-test sha=e7debe6

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3141809658. Workflow: Appsmith External Integration Test Workflow. Commit: e7debe6. PR: 16802.

[github-actions[bot]]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3141809658. Commit: ``. Results:

Click to view performance test results

	Run 1 (ms)	Run 2 (ms)	Run 3 (ms)	Run 4 (ms)	Run 5 (ms)	Minimum (ms)	Median (ms)	Mean (ms)	Range (%)	SD.Sample (%)	SD.Population (%)
SELECT_CATEGORY
scripting	372.7	501.88	433.87	415.4	591.82	372.7	433.87	463.13	47.31	18.50	16.55
painting	5.08	7.69	3.99	5.27	5.46	3.99	5.27	5.5	67.27	24.55	22.00
rendering	109.49	125.21	131.96	112.65	229.31	109.49	125.21	141.72	84.55	35.15	31.44
BIND_TABLE_DATA
scripting	1223.05	1650.3	1158.56	1154.62	1239.69	1154.62	1223.05	1285.24	38.57	16.15	14.44
painting	28.34	28.42	23.91	30.09	34.66	23.91	28.42	29.08	36.97	13.31	11.90
rendering	927.56	661.17	878.5	938.82	1021.39	661.17	927.56	885.49	40.68	15.30	13.69
CLICK_ON_TABLE_ROW
scripting	906.2	1156.71	1043.34	1001	1099.81	906.2	1043.34	1041.41	24.05	9.19	8.22
painting	24.6	22.9	12.46	12.95	10.51	10.51	12.95	16.68	84.47	39.21	35.07
rendering	318.57	347.73	322.88	315.96	390.55	315.96	322.88	339.14	21.99	9.26	8.28
UPDATE_POST_TITLE
scripting	1626	1647.04	1640.06	1538.38	1568.03	1538.38	1626	1603.9	6.77	3.00	2.68
painting	21.89	16.63	17.97	16.96	18.67	16.63	17.97	18.42	28.56	11.40	10.21
rendering	498.26	496.23	506.36	483.6	493.2	483.6	496.23	495.53	4.59	1.67	1.49
OPEN_MODAL
scripting	491.32	577.38	555.48	466.66	541.92	466.66	541.92	526.55	21.03	8.75	7.82
painting	14.75	11.86	10.36	12.78	12.77	10.36	12.77	12.5	35.12	12.80	11.44
rendering	416.9	443.64	428.75	390.24	465.07	390.24	428.75	428.92	17.45	6.56	5.87
CLOSE_MODAL
scripting	269.06	235.11	269.77	188.52	229.23	188.52	235.11	238.34	34.09	14.08	12.60
painting	7.13	6.25	6.05	6.17	8.89	6.05	6.25	6.9	41.16	17.25	15.51
rendering	397.7	379.9	373.04	351.44	356.69	351.44	373.04	371.75	12.44	5.00	4.47
SELECT_WIDGET_MENU_OPEN
scripting	1250.14	1087.4	1050.45	982.57	1039.66	982.57	1050.45	1082.04	24.73	9.35	8.37
painting	13.88	11.63	7.71	9.83	11.24	7.71	11.24	10.86	56.81	20.99	18.78
rendering	835.46	718.4	675.12	622.02	652.62	622.02	675.12	700.72	30.46	11.86	10.61
SELECT_WIDGET_SELECT_OPTION
scripting	246.9	188.68	161.9	176.67	214.68	161.9	188.68	197.77	42.98	16.98	15.19
painting	3.78	3.11	4.95	4.66	11.07	3.11	4.66	5.51	144.46	57.89	51.72
rendering	436.53	361.91	329.28	314.37	345.4	314.37	345.4	357.5	34.17	13.32	11.91

[arunvjn]

/ok-to-test sha=a8fcc53