appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Autoassigns column datatype in table widget

Open souma-ghosh opened this issue 3 years ago • 27 comments

Description

When creating a column from tableData we were auto-assigning columns to "Plain Text" type by default without looking at the data of the column.

In this PR (In order to auto-assign better column types) before creating each column

  1. We pick up the the first non-null value for that column from tableData
  2. Assign datatype to the column according to the value

Note: Currently limited the check for non-null values to maxRowsToCheck rows, where maxRowsToCheck = 5

Datatypes being checked for and the corresponding column type being assigned:

  • number: Number
  • boolean: Checkbox
  • string: Plain Text
  • popular date formats: Date
  • fallback/default: Plain Text

Fixes #12831

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Jest tests

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

souma-ghosh avatar Sep 12 '22 13:09 souma-ghosh

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 10:16PM (UTC)

vercel[bot] avatar Sep 12 '22 13:09 vercel[bot]

/ok-to-test sha=e775589

souma-ghosh avatar Sep 14 '22 07:09 souma-ghosh

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3051047438. Workflow: Appsmith External Integration Test Workflow. Commit: e775589. PR: 16701.

github-actions[bot] avatar Sep 14 '22 07:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3051047438. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 468.56 | 371.32 | 367.96 | 325.7 | 343.71 | 325.7| 367.96| 375.45 | 38.05| 14.72 | 13.17| | painting | 4.07 | 13.64 | 3.06 | 2.93 | 3.32 | 2.93| 3.32| 5.4 | 198.33| 85.74 | 76.67| | rendering | 120.8 | 108.79 | 108.3 | 101.93 | 107.84 | 101.93| 108.3| 109.53 | 17.23| 6.29 | 5.62| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1037.74 | 1060.64 | 967.13 | 965.72 | 1194.52 | 965.72| 1037.74| 1045.15 | 21.89| 8.95 | 8.01| | painting | 28.8 | 30.47 | 15.31 | 21.82 | 24.02 | 15.31| 24.02| 24.08 | 62.96| 25.00 | 22.38| | rendering | 920.41 | 911.26 | 823.15 | 800.6 | 856.91 | 800.6| 856.91| 862.47 | 13.89| 6.12 | 5.47| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 863.38 | 867.69 | 827.8 | 862.89 | 936.92 | 827.8| 863.38| 871.74 | 12.52| 4.57 | 4.09| | painting | 12.48 | 11.75 | 10.47 | 9.95 | 9.98 | 9.95| 10.47| 10.93 | 23.15| 10.34 | 9.24| | rendering | 317.6 | 307.8 | 297.31 | 306.08 | 322.7 | 297.31| 307.8| 310.3 | 8.18| 3.22 | 2.88| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1402.65 | 1304.96 | 1207.26 | 1176.89 | 1317.79 | 1176.89| 1304.96| 1281.91 | 17.61| 7.09 | 6.34| | painting | 22.92 | 16.16 | 14.46 | 12.56 | 13.89 | 12.56| 14.46| 16 | 64.75| 25.50 | 22.81| | rendering | 495.74 | 475.07 | 449.97 | 456.14 | 466.53 | 449.97| 466.53| 468.69 | 9.77| 3.82 | 3.42| OPEN_MODAL| | | | | | | | | | | | scripting | 493.33 | 456.9 | 393.2 | 441.02 | 459.1 | 393.2| 456.9| 448.71 | 22.32| 8.12 | 7.26| | painting | 16.24 | 12.96 | 19.03 | 7.9 | 13.4 | 7.9| 13.4| 13.91 | 80.01| 29.83 | 26.67| | rendering | 418.45 | 403.91 | 373.51 | 399.42 | 395.96 | 373.51| 399.42| 398.25 | 11.28| 4.09 | 3.65| CLOSE_MODAL| | | | | | | | | | | | scripting | 219.25 | 187.53 | 162.42 | 174.57 | 281.45 | 162.42| 187.53| 205.04 | 58.05| 23.25 | 20.80| | painting | 5.07 | 14.44 | 12.79 | 5.24 | 10.74 | 5.07| 10.74| 9.66 | 97.00| 44.62 | 39.96| | rendering | 367 | 354.01 | 334.58 | 369.2 | 398.86 | 334.58| 367| 364.73 | 17.62| 6.45 | 5.77| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 972.67 | 931.28 | 906.79 | 960.84 | 1065.74 | 906.79| 960.84| 967.46 | 16.43| 6.27 | 5.61| | painting | 13.96 | 6.72 | 5.24 | 13.48 | 10.19 | 5.24| 10.19| 9.92 | 87.90| 39.42 | 35.28| | rendering | 645.28 | 634.02 | 587.72 | 654.45 | 726.04 | 587.72| 645.28| 649.5 | 21.30| 7.68 | 6.87| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 186.34 | 155.17 | 152.27 | 163.51 | 200.54 | 152.27| 163.51| 171.57 | 28.13| 12.24 | 10.95| | painting | 10.05 | 3.85 | 3.04 | 3.65 | 9.67 | 3.04| 3.85| 6.05 | 115.87| 57.69 | 51.57| | rendering | 324.97 | 309.41 | 296.75 | 321.79 | 343.51 | 296.75| 321.79| 319.29 | 14.64| 5.49 | 4.91|

github-actions[bot] avatar Sep 14 '22 11:09 github-actions[bot]

@souma-ghosh On changing the type of a value, it isn’t reflecting on the table (In this case, I changed a boolean value to string). Not sure if this pertains to this PR. Could you have a look and confirm please?

https://www.loom.com/share/a5afac6d7b3e4a419dcbc57d77e94b62

laveena-en avatar Sep 15 '22 08:09 laveena-en

@souma-ghosh On changing the type of a value, it isn’t reflecting on the table (In this case, I changed a boolean value to string). Not sure if this pertains to this PR. Could you have a look and confirm please?

https://www.loom.com/share/a5afac6d7b3e4a419dcbc57d77e94b62

@sbalaji1192 @dilippitchika Should we try to switch the column data type if the user changes the table data manually as shown in the above video?

souma-ghosh avatar Sep 15 '22 08:09 souma-ghosh

@souma-ghosh We don't have to. We're only going to guess the type when a column is generated. we don't have to keep guessing every time the table data changes.

CC @dilippitchika

sbalaji1192 avatar Sep 15 '22 08:09 sbalaji1192

If everything else is working fine we can go ahead with the current solution then @laveena-en

souma-ghosh avatar Sep 15 '22 09:09 souma-ghosh

Agreed with balaji, we only guess the first time. After that, it's the users responsibility to manage them.

dilippitchika avatar Sep 15 '22 09:09 dilippitchika

Yes, we can go ahead with this. Tested and verified for data that consists of:

  1. String
  2. Number
  3. Boolean values

laveena-en avatar Sep 15 '22 10:09 laveena-en

@laveena-en what about dates?

dilippitchika avatar Sep 15 '22 10:09 dilippitchika

@dilippitchika Dates have not been handled yet. For us to confirm whether a column data is date type or not it has to be a valid ISO or UTC format or another format we explicitly specify. So we cannot guess a column to be of type date unless we know what format/formats we are expecting

souma-ghosh avatar Sep 15 '22 10:09 souma-ghosh

/ok-to-test sha=fd70e6b

souma-ghosh avatar Sep 16 '22 05:09 souma-ghosh

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3065773253. Workflow: Appsmith External Integration Test Workflow. Commit: fd70e6b. PR: 16701.

github-actions[bot] avatar Sep 16 '22 06:09 github-actions[bot]

/ok-to-test sha=fd70e6b

souma-ghosh avatar Sep 19 '22 09:09 souma-ghosh

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3081404518. Workflow: Appsmith External Integration Test Workflow. Commit: fd70e6b. PR: 16701.

github-actions[bot] avatar Sep 19 '22 09:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3081404518. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 383.89 | 1319.82 | 355.35 | 359.81 | 346.07 | 346.07| 359.81| 552.99 | 176.09| 77.56 | 69.37| | painting | 8.82 | 6.07 | 3.92 | 3.5 | 2.94 | 2.94| 3.92| 5.05 | 116.44| 47.92 | 42.77| | rendering | 110.9 | 118.9 | 106.92 | 107.33 | 106.77 | 106.77| 107.33| 110.16 | 11.01| 4.69 | 4.19| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1137.44 | 1314.16 | 1088.72 | 1129.55 | 1029.84 | 1029.84| 1129.55| 1139.94 | 24.94| 9.33 | 8.34| | painting | 27.88 | 25 | 11.41 | 20.8 | 19.05 | 11.41| 20.8| 20.83 | 79.07| 30.24 | 27.08| | rendering | 875.69 | 991.76 | 809.8 | 892.52 | 835.14 | 809.8| 875.69| 880.98 | 20.65| 7.95 | 7.11| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 928.43 | 1129.19 | 869.26 | 899.88 | 942.7 | 869.26| 928.43| 953.89 | 27.25| 10.69 | 9.56| | painting | 10.29 | 12.5 | 13 | 12.91 | 11.83 | 10.29| 12.5| 12.11 | 22.38| 9.25 | 8.26| | rendering | 321.29 | 329.62 | 291.68 | 314.17 | 318.85 | 291.68| 318.85| 315.12 | 12.04| 4.52 | 4.05| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1977.85 | 1781.02 | 1399.25 | 1488.88 | 1499.3 | 1399.25| 1499.3| 1629.26 | 35.51| 14.85 | 13.28| | painting | 31.77 | 22.04 | 15.39 | 27.55 | 14.67 | 14.67| 22.04| 22.28 | 76.75| 33.53 | 29.98| | rendering | 552.97 | 509.92 | 456.27 | 478.15 | 466.88 | 456.27| 478.15| 492.84 | 19.62| 7.95 | 7.11| OPEN_MODAL| | | | | | | | | | | | scripting | 629.76 | 508.7 | 432.74 | 913.97 | 456.73 | 432.74| 508.7| 588.38 | 81.79| 33.52 | 29.98| | painting | 29.9 | 10.8 | 8.9 | 10.48 | 21.77 | 8.9| 10.8| 16.37 | 128.28| 55.77 | 49.91| | rendering | 467.31 | 398.65 | 372.74 | 384.46 | 392.8 | 372.74| 392.8| 403.19 | 23.46| 9.21 | 8.24| CLOSE_MODAL| | | | | | | | | | | | scripting | 801.19 | 262.41 | 184.68 | 170.6 | 281.34 | 170.6| 262.41| 340.04 | 185.45| 77.11 | 68.97| | painting | 6.16 | 5.31 | 5.32 | 4.27 | 7.36 | 4.27| 5.32| 5.68 | 54.40| 20.25 | 18.13| | rendering | 379.29 | 364.52 | 344.12 | 332.96 | 374.27 | 332.96| 364.52| 359.03 | 12.90| 5.53 | 4.94| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 1066.05 | 931.6 | 967.52 | 984.13 | 977.4 | 931.6| 977.4| 985.34 | 13.65| 5.02 | 4.49| | painting | 9.32 | 4.63 | 11.7 | 7.74 | 7.02 | 4.63| 7.74| 8.08 | 87.50| 32.67 | 29.21| | rendering | 685.11 | 600.07 | 595.19 | 623.91 | 629.72 | 595.19| 623.91| 626.8 | 14.35| 5.71 | 5.11| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 200.02 | 156.32 | 179.96 | 173.6 | 158.16 | 156.32| 173.6| 173.61 | 25.17| 10.29 | 9.20| | painting | 3.11 | 2.69 | 3.61 | 11.33 | 6.99 | 2.69| 3.61| 5.55 | 155.68| 65.77 | 58.92| | rendering | 346.19 | 302.39 | 306.28 | 323.57 | 320.85 | 302.39| 320.85| 319.86 | 13.69| 5.41 | 4.84|

github-actions[bot] avatar Sep 19 '22 10:09 github-actions[bot]

/ok-to-test sha=8d07cdf

souma-ghosh avatar Sep 20 '22 09:09 souma-ghosh

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3089183270. Workflow: Appsmith External Integration Test Workflow. Commit: 8d07cdf. PR: 16701.

github-actions[bot] avatar Sep 20 '22 09:09 github-actions[bot]

/ok-to-test sha=e42ee65

souma-ghosh avatar Sep 20 '22 10:09 souma-ghosh

/ok-to-test sha=e42ee65

souma-ghosh avatar Sep 20 '22 10:09 souma-ghosh

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3089378883. Workflow: Appsmith External Integration Test Workflow. Commit: e42ee65. PR: 16701.

github-actions[bot] avatar Sep 20 '22 10:09 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3089378025. Workflow: Appsmith External Integration Test Workflow. Commit: e42ee65. PR: 16701.

github-actions[bot] avatar Sep 20 '22 10:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3089378025. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 332.01 | 343.34 | 1099.22 | 362.43 | 353.21 | 332.01| 353.21| 498.04 | 154.05| 67.52 | 60.39| | painting | 7.75 | 8.23 | 3.02 | 2.95 | 5.09 | 2.95| 5.09| 5.41 | 97.60| 46.40 | 41.59| | rendering | 104.26 | 103.39 | 102.16 | 100.51 | 107.58 | 100.51| 103.39| 103.58 | 6.83| 2.55 | 2.28| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1032.08 | 1086.01 | 1052.84 | 1116.52 | 1148.71 | 1032.08| 1086.01| 1087.23 | 10.73| 4.33 | 3.87| | painting | 16.72 | 19.15 | 20.71 | 16.11 | 21.3 | 16.11| 19.15| 18.8 | 27.61| 12.34 | 11.06| | rendering | 798.54 | 782.6 | 817.76 | 794.19 | 841.46 | 782.6| 798.54| 806.91 | 7.29| 2.86 | 2.56| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 1052.48 | 907.72 | 881.04 | 869.46 | 965.59 | 869.46| 907.72| 935.26 | 19.57| 8.05 | 7.20| | painting | 8.6 | 13.56 | 10.91 | 8.54 | 10.09 | 8.54| 10.09| 10.34 | 48.55| 19.92 | 17.89| | rendering | 285.64 | 303.79 | 312.68 | 297.32 | 300.83 | 285.64| 300.83| 300.05 | 9.01| 3.29 | 2.94| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1432.22 | 1354.23 | 1343.46 | 1389.49 | 1448.13 | 1343.46| 1389.49| 1393.51 | 7.51| 3.32 | 2.97| | painting | 14.19 | 13.19 | 12.11 | 17.23 | 18.3 | 12.11| 14.19| 15 | 41.27| 17.67 | 15.80| | rendering | 445.93 | 450.87 | 462.45 | 456.41 | 467.93 | 445.93| 456.41| 456.72 | 4.82| 1.92 | 1.72| OPEN_MODAL| | | | | | | | | | | | scripting | 439.39 | 416.63 | 421.43 | 871.92 | 474.32 | 416.63| 439.39| 524.74 | 86.76| 37.24 | 33.31| | painting | 8.18 | 16.39 | 11.08 | 11.17 | 11.73 | 8.18| 11.17| 11.71 | 70.11| 25.28 | 22.63| | rendering | 371.91 | 367.41 | 352.47 | 380.16 | 398.28 | 352.47| 371.91| 374.05 | 12.25| 4.51 | 4.03| CLOSE_MODAL| | | | | | | | | | | | scripting | 172.15 | 207.73 | 212.53 | 200.11 | 176.36 | 172.15| 200.11| 193.78 | 20.84| 9.51 | 8.50| | painting | 7.81 | 10.04 | 4.12 | 10.82 | 13.76 | 4.12| 10.04| 9.31 | 103.54| 38.67 | 34.59| | rendering | 330.54 | 332.65 | 325.47 | 347.84 | 348.99 | 325.47| 332.65| 337.1 | 6.98| 3.16 | 2.83| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 891.32 | 936.81 | 910.4 | 976.5 | 968.35 | 891.32| 936.81| 936.68 | 9.09| 3.90 | 3.49| | painting | 4.98 | 5.18 | 5.19 | 15.31 | 6.2 | 4.98| 5.19| 7.37 | 140.16| 60.52 | 54.14| | rendering | 600.29 | 594.11 | 593.47 | 627.44 | 599.61 | 593.47| 599.61| 602.98 | 5.63| 2.33 | 2.08| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 155.75 | 171.84 | 155.83 | 169.22 | 155.75 | 155.75| 155.83| 161.68 | 9.95| 5.03 | 4.50| | painting | 2.09 | 5.87 | 2.6 | 10.49 | 3.32 | 2.09| 3.32| 4.87 | 172.48| 71.05 | 63.45| | rendering | 308.91 | 310.03 | 308.3 | 308.02 | 296.67 | 296.67| 308.3| 306.39 | 4.36| 1.79 | 1.60|

github-actions[bot] avatar Sep 20 '22 11:09 github-actions[bot]

/ok-to-test sha=518bf59

souma-ghosh avatar Sep 21 '22 09:09 souma-ghosh

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3096507382. Workflow: Appsmith External Integration Test Workflow. Commit: 518bf59. PR: 16701.

github-actions[bot] avatar Sep 21 '22 09:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3096507382. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 750.22 | 370.48 | 385.58 | 378.23 | 536.24 | 370.48| 385.58| 484.15 | 78.43| 33.84 | 30.27| | painting | 12.75 | 3.17 | 10.65 | 3.74 | 7.36 | 3.17| 7.36| 7.53 | 127.22| 55.64 | 49.80| | rendering | 228.55 | 111.39 | 115.85 | 117.36 | 119.48 | 111.39| 117.36| 138.53 | 84.57| 36.39 | 32.55| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1674.11 | 1558.88 | 1157.59 | 1084.32 | 1217.87 | 1084.32| 1217.87| 1338.55 | 44.06| 19.52 | 17.46| | painting | 30.83 | 17.07 | 29.37 | 25.66 | 32.24 | 17.07| 29.37| 27.03 | 56.12| 22.53 | 20.13| | rendering | 928.95 | 579.81 | 921.02 | 891.88 | 952.02 | 579.81| 921.02| 854.74 | 43.55| 18.16 | 16.24| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 1650.51 | 1107.24 | 1042.6 | 1380.23 | 1327.47 | 1042.6| 1327.47| 1301.61 | 46.70| 18.56 | 16.60| | painting | 20.05 | 15.79 | 13.29 | 17.68 | 22.95 | 13.29| 17.68| 17.95 | 53.82| 20.84 | 18.61| | rendering | 462.23 | 343.08 | 343.48 | 356.37 | 389.25 | 343.08| 356.37| 378.88 | 31.45| 13.26 | 11.86| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1660.14 | 1788.24 | 1658.5 | 1732.23 | 1865.75 | 1658.5| 1732.23| 1740.97 | 11.90| 5.07 | 4.54| | painting | 15.53 | 19.69 | 17.26 | 25.4 | 20.02 | 15.53| 19.69| 19.58 | 50.41| 19.10 | 17.06| | rendering | 491.77 | 549.88 | 493.59 | 504.19 | 536.16 | 491.77| 504.19| 515.12 | 11.28| 5.12 | 4.58| OPEN_MODAL| | | | | | | | | | | | scripting | 453.86 | 523.16 | 1042.52 | 525.89 | 630.68 | 453.86| 525.89| 635.22 | 92.67| 37.20 | 33.27| | painting | 11.91 | 20.49 | 21.9 | 11.8 | 17.36 | 11.8| 17.36| 16.69 | 60.52| 28.22 | 25.22| | rendering | 392.15 | 412.29 | 411.36 | 447.17 | 462.14 | 392.15| 412.29| 425.02 | 16.47| 6.75 | 6.04| CLOSE_MODAL| | | | | | | | | | | | scripting | 198.61 | 197.14 | 200.48 | 267.32 | 244.37 | 197.14| 200.48| 221.58 | 31.67| 14.59 | 13.05| | painting | 7.13 | 10.76 | 11.43 | 18.7 | 12.55 | 7.13| 11.43| 12.11 | 95.54| 34.68 | 31.05| | rendering | 365.83 | 388.6 | 433.75 | 427.28 | 416.34 | 365.83| 416.34| 406.36 | 16.71| 7.01 | 6.27| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 989.63 | 979.38 | 1059.16 | 1012.03 | 1261.37 | 979.38| 1012.03| 1060.31 | 26.60| 10.99 | 9.83| | painting | 11.23 | 6.64 | 8.19 | 5.81 | 14.29 | 5.81| 8.19| 9.23 | 91.87| 37.92 | 33.91| | rendering | 632.84 | 626.28 | 700.86 | 658.28 | 887.86 | 626.28| 658.28| 701.22 | 37.30| 15.45 | 13.82| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 176.74 | 169.14 | 205.49 | 182.67 | 246.68 | 169.14| 182.67| 196.14 | 39.53| 15.98 | 14.29| | painting | 10.56 | 6.65 | 5.79 | 2.66 | 6.08 | 2.66| 6.08| 6.35 | 124.41| 44.41 | 39.69| | rendering | 333.48 | 344.15 | 334.96 | 336.33 | 428.16 | 333.48| 336.33| 355.42 | 26.64| 11.50 | 10.29|

github-actions[bot] avatar Sep 21 '22 12:09 github-actions[bot]

/ok-to-test sha=95dd1f0

souma-ghosh avatar Sep 22 '22 06:09 souma-ghosh

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3103250969. Workflow: Appsmith External Integration Test Workflow. Commit: 95dd1f0. PR: 16701.

github-actions[bot] avatar Sep 22 '22 06:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3103250969. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 348.02 | 378.63 | 353.54 | 347.08 | 362.93 | 347.08| 353.54| 358.04 | 8.81| 3.66 | 3.28| | painting | 4.23 | 4.24 | 2.94 | 3.23 | 6.29 | 2.94| 4.23| 4.19 | 79.95| 31.26 | 27.92| | rendering | 105.75 | 114.49 | 105.25 | 102.63 | 106.31 | 102.63| 105.75| 106.89 | 11.10| 4.19 | 3.75| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1078.14 | 1052.33 | 1062.67 | 1065.58 | 1142.86 | 1052.33| 1065.58| 1080.32 | 8.38| 3.35 | 2.99| | painting | 14.05 | 11.57 | 17.91 | 17.67 | 16.65 | 11.57| 16.65| 15.57 | 40.72| 17.41 | 15.54| | rendering | 792.51 | 790.37 | 789.51 | 795.27 | 815.33 | 789.51| 792.51| 796.6 | 3.24| 1.34 | 1.20| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 771.99 | 915.27 | 878.89 | 1026.82 | 877.14 | 771.99| 878.89| 894.02 | 28.50| 10.23 | 9.15| | painting | 11.49 | 10.93 | 12.14 | 14.04 | 10.68 | 10.68| 11.49| 11.86 | 28.33| 11.30 | 10.12| | rendering | 310.33 | 332.49 | 300.4 | 296.5 | 307.92 | 296.5| 307.92| 309.53 | 11.63| 4.52 | 4.04| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1373.36 | 1311.78 | 1298.64 | 1442.08 | 1335.75 | 1298.64| 1335.75| 1352.32 | 10.61| 4.26 | 3.81| | painting | 12.04 | 17.21 | 15.05 | 13.42 | 13.33 | 12.04| 13.42| 14.21 | 36.38| 14.00 | 12.53| | rendering | 455.22 | 449.65 | 452.64 | 452.9 | 460.82 | 449.65| 452.9| 454.25 | 2.46| 0.92 | 0.82| OPEN_MODAL| | | | | | | | | | | | scripting | 467.65 | 469.6 | 460.85 | 460.68 | 458.48 | 458.48| 460.85| 463.45 | 2.40| 1.05 | 0.94| | painting | 9.6 | 14.98 | 14.98 | 15.46 | 8.46 | 8.46| 14.98| 12.7 | 55.12| 26.61 | 23.78| | rendering | 384.13 | 424.89 | 377.77 | 367.04 | 387.13 | 367.04| 384.13| 388.19 | 14.90| 5.64 | 5.05| CLOSE_MODAL| | | | | | | | | | | | scripting | 207.03 | 188.13 | 169.45 | 174.43 | 167.54 | 167.54| 174.43| 181.32 | 21.78| 9.08 | 8.13| | painting | 9.23 | 7.49 | 15.33 | 4.47 | 11.14 | 4.47| 9.23| 9.53 | 113.96| 42.60 | 38.20| | rendering | 332.7 | 338.88 | 347.83 | 334.9 | 347.87 | 332.7| 338.88| 340.44 | 4.46| 2.09 | 1.87| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 928.69 | 931.76 | 931.15 | 943.63 | 974.57 | 928.69| 931.76| 941.96 | 4.87| 2.03 | 1.82| | painting | 12.23 | 10.8 | 4.12 | 6.89 | 17.96 | 4.12| 10.8| 10.4 | 133.08| 50.96 | 45.58| | rendering | 588.02 | 593.28 | 598.71 | 619.24 | 616.59 | 588.02| 598.71| 603.17 | 5.18| 2.32 | 2.08| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 154.23 | 162.81 | 169.49 | 171.57 | 152.56 | 152.56| 162.81| 162.13 | 11.73| 5.32 | 4.76| | painting | 6.47 | 5.5 | 6.97 | 3.9 | 9.18 | 3.9| 6.47| 6.4 | 82.50| 30.31 | 27.19| | rendering | 328.51 | 312.38 | 308.68 | 310.17 | 308.57 | 308.57| 310.17| 313.66 | 6.36| 2.69 | 2.41|

github-actions[bot] avatar Sep 22 '22 07:09 github-actions[bot]