appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Informative error messages on cyclic dependency for queries on page load

Open sondermanish opened this issue 2 years ago • 4 comments

Description

This commit addresses 16154 and changes the files mentioned below:

Layout.java
ActionCollectionDTO.java ActionDTO.java LayoutDTO.java LayoutActionServiceCEImpl.java LayoutCollectionServiceCEImpl.java LayoutActionServiceTest.java

PageApi.tsx ReduxActionConstants.tsx ActionConstants.tsx entities/Action/index.ts JSCollection/index.ts editorReducer.tsx PluginActionSaga.ts ActionSagas.ts JSActionSagas.ts JSPaneSagas.ts PageSagas.tsx sagas/helper.ts editorSelectors.tsx

Type of change

New feature: The user will now see the toast and debug messages when the user will encounter/ generate cyclic dependency on below mentioned flows.

  • Changing JS object: Receiving <ActionCollectionDTO> Endpoint: api/v1/collections/actions/{id}
  • Refactoring JSObject: Response <LayoutDTO> Endpoint: api/v1/collections/actions/refactor
  • Changing DSL name: Response <LayoutDTO> Endpoint: api/v1/layouts/refactor
  • Changing DSL attribute: Response <LayoutDTO> Endpoint: api/v1/{layoutId}/pages/{pageId}
  • Reloading page: Response<NewPage> Endpoint: api/v1/pages/{pageId}
  • Changing db query: Response <ActionDTO> Endpoint: api/v1/actions/{actionId}

How Has This Been Tested?

The backend changes has been tested:

  • Junit test cases
  • Manually

The frontend changes has been tested:

  • Manually

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

sondermanish avatar Sep 08 '22 06:09 sondermanish

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 2:39PM (UTC)

vercel[bot] avatar Sep 08 '22 06:09 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 2 hours (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Sep 15 '22 15:09 vercel[bot]

/ok-to-test sha=562dcff

sneha122 avatar Sep 19 '22 12:09 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3082516946. Workflow: Appsmith External Integration Test Workflow. Commit: 562dcff. PR: 16634.

github-actions[bot] avatar Sep 19 '22 12:09 github-actions[bot]

/ok-to-test sha=843a303

sneha122 avatar Sep 22 '22 05:09 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3103044327. Workflow: Appsmith External Integration Test Workflow. Commit: 843a303. PR: 16634.

github-actions[bot] avatar Sep 22 '22 05:09 github-actions[bot]

/ok-to-test sha=15cb6bd

sondermanish avatar Sep 22 '22 07:09 sondermanish

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3103769698. Workflow: Appsmith External Integration Test Workflow. Commit: 15cb6bd. PR: 16634.

github-actions[bot] avatar Sep 22 '22 08:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3103769698. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 371.36 | 343.45 | 399.53 | 1315.02 | 365.18 | 343.45| 371.36| 558.91 | 173.83| 75.71 | 67.72| | painting | 5.83 | 8.32 | 3.28 | 18.77 | 3.86 | 3.28| 5.83| 8.01 | 193.38| 79.03 | 70.66| | rendering | 114.03 | 112.5 | 109.56 | 306.77 | 110.99 | 109.56| 112.5| 150.77 | 130.80| 57.85 | 51.74| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1071.11 | 1040.01 | 1073.14 | 1947.91 | 1168.73 | 1040.01| 1073.14| 1260.18 | 72.05| 30.75 | 27.50| | painting | 16.52 | 17.76 | 19.74 | 42.42 | 25.59 | 16.52| 19.74| 24.41 | 106.10| 43.63 | 39.04| | rendering | 850.19 | 811.28 | 831.58 | 800.01 | 906.34 | 800.01| 831.58| 839.88 | 12.66| 4.98 | 4.46| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 1174.91 | 922.86 | 1009.97 | 2700.29 | 987.03 | 922.86| 1009.97| 1359.01 | 130.79| 55.59 | 49.73| | painting | 15.83 | 10.03 | 18.01 | 39.03 | 11.05 | 10.03| 15.83| 18.79 | 154.34| 62.75 | 56.09| | rendering | 314.92 | 299.61 | 350.99 | 649.25 | 315.22 | 299.61| 315.22| 386 | 90.58| 38.44 | 34.38| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1704.79 | 1382.38 | 1597.81 | 4915.99 | 1543.03 | 1382.38| 1597.81| 2228.8 | 158.54| 67.60 | 60.46| | painting | 16.3 | 12.44 | 19.55 | 58.42 | 15.03 | 12.44| 16.3| 24.35 | 188.83| 78.93 | 70.60| | rendering | 511.79 | 448.75 | 490.03 | 1165.16 | 491.94 | 448.75| 491.94| 621.53 | 115.27| 49.03 | 43.86| OPEN_MODAL| | | | | | | | | | | | scripting | 514.15 | 420.44 | 525.33 | 1434.64 | 486.36 | 420.44| 514.15| 676.18 | 149.99| 62.99 | 56.34| | painting | 15.13 | 18.26 | 8.67 | 56.35 | 14.27 | 8.67| 15.13| 22.54 | 211.54| 85.27 | 76.26| | rendering | 409.91 | 368.79 | 389.3 | 689.88 | 403.23 | 368.79| 403.23| 452.22 | 71.00| 29.58 | 26.46| CLOSE_MODAL| | | | | | | | | | | | scripting | 202.2 | 641.6 | 268.19 | 737.88 | 169.76 | 169.76| 268.19| 403.93 | 140.65| 65.73 | 58.79| | painting | 5.03 | 6.4 | 5.99 | 14.64 | 9.68 | 5.03| 6.4| 8.35 | 115.09| 47.07 | 42.04| | rendering | 362.85 | 331.16 | 416.68 | 852.97 | 344.48 | 331.16| 362.85| 461.63 | 113.04| 47.91 | 42.85| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 968.27 | 998.73 | 2174.54 | 1080.87 | 1024.72 | 968.27| 1024.72| 1249.43 | 96.55| 41.52 | 37.14| | painting | 8.1 | 6.12 | 21.36 | 7.68 | 13.04 | 6.12| 8.1| 11.26 | 135.35| 55.15 | 49.38| | rendering | 618.06 | 646.68 | 1292.33 | 659.32 | 654.37 | 618.06| 654.37| 774.15 | 87.10| 37.47 | 33.52| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 160.68 | 183.51 | 598.84 | 182.13 | 181.66 | 160.68| 182.13| 261.36 | 167.65| 72.27 | 64.64| | painting | 1.96 | 2.22 | 10.17 | 17.45 | 15.21 | 1.96| 10.17| 9.4 | 164.79| 76.38 | 68.30| | rendering | 326.77 | 321.46 | 670.31 | 354.27 | 332.06 | 321.46| 332.06| 400.97 | 87.00| 37.68 | 33.70|

github-actions[bot] avatar Sep 22 '22 08:09 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3106761368. Workflow: Appsmith External Integration Test Workflow. Commit: 02b5bc8. PR: 16634.

github-actions[bot] avatar Sep 22 '22 15:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3106761368. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_WIDGET_MENU_OPEN
scripting 1000.25 968.48 1025.36 1035.74 981.52 968.48 1000.25 1002.27 6.71 2.84 2.54
painting 7.76 9.04 6.54 11.33 5.88 5.88 7.76 8.11 67.20 26.76 23.92
rendering 626.35 651.15 641.11 671.92 608 608 641.11 639.71 9.99 3.79 3.39
SELECT_WIDGET_SELECT_OPTION
scripting 167.61 162.1 167.51 221 171.47 162.1 167.61 177.94 33.10 13.66 12.22
painting 9 3.95 2.54 2.92 2.57 2.54 2.92 4.2 153.81 65.48 58.57
rendering 315.79 323.81 329.36 349.14 320.36 315.79 323.81 327.69 10.18 3.96 3.54
SELECT_CATEGORY
scripting 381.13 349.35 375.38 374.06 349.35 374.72 369.98 8.59 3.81 3.30
painting 5.79 4.69 6.54 3.6 3.6 5.24 5.16 56.98 25.00 21.51
rendering 111.27 113.4 109.36 106.74 106.74 110.315 110.19 6.04 2.57 2.22
BIND_TABLE_DATA
scripting 1120.47 1024.74 1202.01 1546.27 1024.74 1161.24 1223.37 42.63 18.57 16.08
painting 19.02 20.64 21.58 25.86 19.02 21.11 21.77 31.42 13.41 11.62
rendering 865.81 829.44 892.6 491.23 491.23 847.625 769.77 52.14 24.36 21.09
CLICK_ON_TABLE_ROW
scripting 920.48 1031.72 999.88 1095.54 920.48 1015.8 1011.9 17.30 7.19 6.23
painting 9.81 12.49 14.43 12.88 9.81 12.685 12.4 37.26 15.48 13.39
rendering 320.57 330.55 321.09 329.11 320.57 325.1 325.33 3.07 1.61 1.39
UPDATE_POST_TITLE
scripting 1472.5 2313.51 1658.71 1619.21 1472.5 1638.96 1765.98 47.62 21.16 18.33
painting 15.26 23.43 16.18 14.84 14.84 15.719999999999999 17.43 49.28 23.18 20.08
rendering 528.29 628.47 534.08 479.85 479.85 531.185 542.67 27.39 11.45 9.92
OPEN_MODAL
scripting 509.44 593.83 496.13 558.97 496.13 534.205 539.59 18.11 8.37 7.25
painting 14.81 22.72 11.34 12.92 11.34 13.865 15.45 73.66 32.69 28.28
rendering 421.35 452.52 407.38 454.82 407.38 436.935 434.02 10.93 5.40 4.67
CLOSE_MODAL
scripting 191.09 295 190.23 233.69 190.23 212.39 227.5 46.05 21.70 18.79
painting 17.67 7.98 13.31 4.8 4.8 10.645 10.94 117.64 52.10 45.06
rendering 348.17 376.17 350.78 357.28 348.17 354.03 358.1 7.82 3.53 3.06

github-actions[bot] avatar Sep 22 '22 16:09 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3113448188. Workflow: Appsmith External Integration Test Workflow. Commit: 9fd0505. PR: 16634.

github-actions[bot] avatar Sep 23 '22 14:09 github-actions[bot]

/ok-to-test sha=7d9733f

sondermanish avatar Sep 23 '22 14:09 sondermanish

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3113544429. Workflow: Appsmith External Integration Test Workflow. Commit: 7d9733f. PR: 16634.

github-actions[bot] avatar Sep 23 '22 14:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3113448188. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 587.11 542.32 364.37 380.72 343.66 343.66 380.72 443.64 54.88 25.34 22.67
painting 6.16 5.09 5.33 3.38 3 3 5.09 4.59 68.85 29.41 26.14
rendering 123.71 120.92 107.5 104.75 106.95 104.75 107.5 112.77 16.81 7.83 7.01
BIND_TABLE_DATA
scripting 1990.21 1655.9 1106.92 1067.8 1032.36 1032.36 1106.92 1370.64 69.88 31.40 28.09
painting 32.19 27.01 22.26 21.64 18.34 18.34 22.26 24.29 57.02 22.19 19.84
rendering 687.87 563.38 837.08 831.22 785.91 563.38 785.91 741.09 36.93 15.64 13.99
CLICK_ON_TABLE_ROW
scripting 1976.92 1679.71 918.02 932.78 927.83 918.02 932.78 1287.05 82.27 39.25 35.11
painting 21.51 22.76 11.59 9.4 9.74 9.4 11.59 15 89.07 43.87 39.27
rendering 565.77 592.05 319.93 328.9 295.22 295.22 328.9 420.37 70.61 34.62 30.97
UPDATE_POST_TITLE
scripting 2994.42 1798.34 1435.46 1540.21 1436.98 1435.46 1540.21 1841.08 84.68 35.93 32.14
painting 36.39 15.8 14.3 16.06 13.47 13.47 15.8 19.2 119.38 50.36 45.05
rendering 845.77 513.7 464.73 493.94 453.45 453.45 493.94 554.32 70.78 29.70 26.57
OPEN_MODAL
scripting 950.71 1038.87 480.27 524.52 456.72 456.72 524.52 690.22 84.34 40.69 36.39
painting 24.47 19.18 8.48 17.15 15.13 8.48 17.15 16.88 94.73 34.60 30.98
rendering 643.41 404.9 389.2 431.22 362.54 362.54 404.9 446.25 62.94 25.32 22.65
CLOSE_MODAL
scripting 454.53 182.14 219.18 221.55 170.52 170.52 219.18 249.58 113.80 46.77 41.84
painting 12.38 5.5 13.7 6.17 4.77 4.77 6.17 8.5 105.06 49.41 44.12
rendering 595.52 351.36 341.7 336.58 340.7 336.58 341.7 393.17 65.86 28.80 25.76
SELECT_WIDGET_MENU_OPEN
scripting 1228.57 1062.81 1010.14 952.38 943.24 943.24 1010.14 1039.43 27.45 11.18 10.00
painting 12.27 12.73 5.87 6.54 7.81 5.87 7.81 9.04 75.88 35.73 31.97
rendering 804.96 757.15 630.27 595.45 599.97 595.45 630.27 677.56 30.92 14.30 12.79
SELECT_WIDGET_SELECT_OPTION
scripting 375.63 162.6 154.56 172.02 163.09 154.56 163.09 205.58 107.53 46.34 41.44
painting 6.07 2.38 4.91 2.29 5.13 2.29 4.91 4.16 90.87 41.35 37.02
rendering 345.05 321.44 314.98 314.57 332.59 314.57 321.44 325.73 9.36 4.00 3.58

github-actions[bot] avatar Sep 23 '22 15:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3113544429. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 372.64 423.86 337.67 378.72 342.54 337.67 372.64 371.09 23.23 9.31 8.33
painting 7.85 5.75 3.59 4.66 4.66 3.59 4.66 5.3 80.38 30.57 27.36
rendering 114.76 116.58 102.99 106.65 104.68 102.99 106.65 109.13 12.45 5.63 5.03
BIND_TABLE_DATA
scripting 1163.43 1193.97 1122.98 1085.05 1155.41 1085.05 1155.41 1144.17 9.52 3.64 3.25
painting 29.24 36.29 15.44 23.68 20.42 15.44 23.68 25.01 83.37 32.23 28.79
rendering 847.67 957.88 795.51 829.99 814.95 795.51 829.99 849.2 19.12 7.50 6.71
CLICK_ON_TABLE_ROW
scripting 1208.09 1124.02 894.47 1001.47 914.87 894.47 1001.47 1028.58 30.49 13.13 11.75
painting 14.6 14.41 18.67 10.68 10.87 10.68 14.41 13.85 57.69 23.68 21.16
rendering 314.23 355 290.96 322.6 298.49 290.96 314.23 316.26 20.25 7.90 7.07
UPDATE_POST_TITLE
scripting 1687.23 1842.76 1476.94 1549.49 1410.12 1410.12 1549.49 1593.31 27.15 10.87 9.73
painting 16.71 20.96 31.78 15.26 13.08 13.08 16.71 19.56 95.60 37.88 33.90
rendering 501.9 521.93 460.89 479.86 442.18 442.18 479.86 481.35 16.57 6.59 5.89
OPEN_MODAL
scripting 508.31 572.75 502.48 486.5 484.84 484.84 502.48 510.98 17.20 7.04 6.30
painting 13.35 14.32 16.72 14.53 15.4 13.35 14.53 14.86 22.68 8.55 7.60
rendering 417.15 431.14 383.06 381.85 393.16 381.85 393.16 401.27 12.28 5.46 4.88
CLOSE_MODAL
scripting 173.63 730.87 224.88 173.25 182.34 173.25 182.34 296.99 187.76 81.98 73.33
painting 10.98 13.98 5.66 3.74 12.51 3.74 10.98 9.37 109.28 47.49 42.48
rendering 333.27 382.87 338.24 316.5 336.06 316.5 336.06 341.39 19.44 7.24 6.48
SELECT_WIDGET_MENU_OPEN
scripting 1026.23 919.18 936.72 969.07 970.04 919.18 969.07 964.25 11.10 4.24 3.79
painting 14.69 11.92 6.79 10.57 13.96 6.79 11.92 11.59 68.16 27.09 24.25
rendering 645.6 589.84 603.24 606.59 633.27 589.84 606.59 615.71 9.06 3.73 3.34
SELECT_WIDGET_SELECT_OPTION
scripting 157.33 147.85 164.22 160.31 155.29 147.85 157.33 157 10.43 3.90 3.48
painting 4.12 3.84 3.53 3.19 2.6 2.6 3.53 3.46 43.93 17.05 15.32
rendering 312.99 307.76 301.54 301.75 312.85 301.54 307.76 307.38 3.73 1.83 1.64

github-actions[bot] avatar Sep 23 '22 15:09 github-actions[bot]