feat: embed settings

[akash-codemonk]

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #15661

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

• Test A
• Test B

Checklist:

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
appsmith	⬜️ Ignored (Inspect)		Nov 22, 2022 at 4:59AM (UTC)

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[akash-codemonk]

/ok-to-test sha=f5d79fe

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3144018824. Workflow: Appsmith External Integration Test Workflow. Commit: f5d79fe. PR: 16629.

[github-actions[bot]]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3144018824. Commit: ``. Results:

Click to view performance test results

	Run 1 (ms)	Run 2 (ms)	Run 3 (ms)	Run 4 (ms)	Run 5 (ms)	Minimum (ms)	Median (ms)	Mean (ms)	Range (%)	SD.Sample (%)	SD.Population (%)
SELECT_WIDGET_MENU_OPEN
scripting	960.64	957.85	929.19	1006.86	427.91	427.91	957.85	856.49	67.60	28.16	25.19
painting	13.02	9.04	7.31	6.51	11.56	6.51	9.04	9.49	68.60	29.19	26.03
rendering	606.1	610.77	600.36	633.02	845.6	600.36	610.77	659.17	37.20	15.92	14.24
SELECT_WIDGET_SELECT_OPTION
scripting	163.77	154.52	157.12	193.32	214.05	154.52	163.77	176.56	33.72	14.75	13.20
painting	2.18	3.49	2.11	2.07	4.07	2.07	2.18	2.78	71.94	33.45	29.86
rendering	325.46	306.06	315.96	348.45	468.07	306.06	325.46	352.8	45.92	18.80	16.81
SELECT_CATEGORY
scripting	390.83	350.95	362.83	365.72	373.67	350.95	365.72	368.8	10.81	4.00	3.58
painting	4.02	3.26	8.54	3.22	4.19	3.22	4.02	4.65	114.41	47.74	42.80
rendering	126.43	109.49	105.34	112.32	107.74	105.34	109.49	112.26	18.79	7.41	6.63
BIND_TABLE_DATA
scripting	1670.67	1061.81	1046.54	1230.8	1087.17	1046.54	1087.17	1219.4	51.18	21.54	19.27
painting	28.39	20.6	16.88	17.45	19.37	16.88	19.37	20.54	56.04	22.59	20.20
rendering	591.93	821.96	826.07	848.36	846.81	591.93	826.07	787.03	32.58	13.94	12.47
CLICK_ON_TABLE_ROW
scripting	1097.98	887.69	867.83	1045.28	834.67	834.67	887.69	946.69	27.81	12.37	11.06
painting	11.14	9.62	11.29	12.84	9.54	9.54	11.14	10.89	30.30	12.58	11.20
rendering	346.23	298.64	295.14	322.91	307.9	295.14	307.9	314.16	16.26	6.65	5.95
UPDATE_POST_TITLE
scripting	1643.42	1420.67	1372.43	1369.74	2628.1	1369.74	1420.67	1686.87	74.60	31.90	28.53
painting	20.41	13.14	14.06	13.7	24.98	13.14	14.06	17.26	68.60	30.30	27.11
rendering	558.1	455.08	453.83	469.52	693.63	453.83	469.52	526.03	45.59	19.61	17.54
OPEN_MODAL
scripting	488.73	448.58	417.76	493.8	741.37	417.76	488.73	518.05	62.47	24.83	22.21
painting	18.75	8.78	8.75	13.66	21.4	8.75	13.66	14.27	88.65	40.22	36.02
rendering	414.85	372.37	368.63	397.64	454.22	368.63	397.64	401.54	21.32	8.72	7.80
CLOSE_MODAL
scripting	196.72	227.06	206.22	208.51	265.59	196.72	208.51	220.82	31.19	12.38	11.07
painting	5.39	12.44	16.61	11.02	7.91	5.39	11.02	10.67	105.15	40.30	36.08
rendering	363.23	333.56	334.28	374.61	423.75	333.56	363.23	365.89	24.65	10.11	9.04

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[akash-codemonk]

/ok-to-test sha=b183225

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3310346852. Workflow: Appsmith External Integration Test Workflow. Commit: b183225. PR: 16629. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16629&runId=3310346852_1

[akash-codemonk]

/ok-to-test sha=5a54f46

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3418795012. Workflow: Appsmith External Integration Test Workflow. Commit: 5a54f46. PR: 16629. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16629&runId=3418795012_1

[Richarex]

@RoopKrrish9696 can we please have a hover state for Embed Settings radio button & Limit embedding to certain URLs text field

[ginilpg]

@ankitakinger All of your review comments have been addressed. Could you please review this again?

[ankitakinger]

@akash-codemonk Below are the things which needs to be looked at IMO:

1. EE repo needs a separate PR for this change for the file appsmith-ee/app/client/src/ee/pages/AdminSettings/config/general.tsx as the embed settings will get removed on EE if this is not done.
2. Can we use the same design-system colors for Radio buttons? (Orange instead of black) It looks weird where everything is Orange, but the Radio buttons are black.
3. Cursor on the cross buttons of the tags in the tag input field is not a pointer, while it was earlier.
4. The UI is changing a bit here for tags, hence tagging @vinay-appsmith for his inputs on how he thinks the tags UI should look on the Admin settings page Before: After: @vinay-appsmith Ref: This is OIDC settings page on EE Admin settings
5. Also, I feel this part of the page is a little clumsy, its not a blocker but just thought to point it out. Can we do something about this?

[RoopKrrish9696]

@ankitakinger Regarding the points you made:

1. For point 2, according to the DS, we use black colour for radio buttons/checkboxes. The ones used before must be old designs IMO. For DS reference .
2. For point 4, we don't have a tag input component, I tried to use the RBAC ones. I think @vinay-appsmith can help here.

[vinay-appsmith]

@ankitakinger @RoopKrrish9696 There is a mismatch with the design system figma file and the design system repo in Storybook. Some of the component designs in Figma haven't been translated to code, yet - which is why you see these differences (orange vs. black).

Stick to the DS repo as much as possible because it will help in making the changes fast when we review the color across the components in our system. (this is happening in the next 2 weeks, iirc)

An exception to the above statement is the tags component. This needs to change to the design that is shared in the thread above (2nd image). The orange on the tags is just too bright. This change needs to happen at the DS level.

[akash-codemonk]

1. Will create a PR there once this PR is merged.
2. So we are going with orange i.e same as the default color used by the design system repo? @RoopKrrish9696

3. Will fix this
4. For taginputs we want to go with the default design system colors? We want to update the brightness of orange but that will happen in the design system repo. @RoopKrrish9696 @vinay-appsmith

[akash-codemonk]

/ok-to-test sha=614337b

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3515719922. Workflow: Appsmith External Integration Test Workflow. Commit: 614337b. PR: 16629. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16629&runId=3515719922_1

[vercel[bot]]

Deployment failed with the following error:

Resource is limited - try again in 8 minutes (more than 100, code: "api-deployments-free-per-day").

[akash-codemonk]

/ok-to-test sha=3a70471

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3520581210. Workflow: Appsmith External Integration Test Workflow. Commit: 3a70471. PR: 16629. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16629&runId=3520581210_1