appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: New settings pane

Open eco-monk opened this issue 2 years ago • 12 comments

Description

  • Added Settings panel. (will now be inside property pane)
  • Can be opened from
    • app/page context menu in entity explorer
    • from App settings CTA in property pane.
  • General settings (app name and icon) can be edited.
  • Moved Theme setting into the setting pane
  • Page properties.
    • custom slugs can be enabled now (Change Page URL field)
    • custom slugs cannot be enabled unless application version is 2 (CTA added in page settings)

UI overview: https://www.loom.com/share/37b31daf627244288e67ba73d5edbbfb

Fixes #14745

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

NA

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

eco-monk avatar Aug 29 '22 06:08 eco-monk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 1:53AM (UTC)

vercel[bot] avatar Aug 29 '22 06:08 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 29 '22 06:08 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Sep 02 '22 06:09 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Sep 02 '22 06:09 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Sep 02 '22 06:09 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 13 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Sep 07 '22 02:09 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 10 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Sep 07 '22 05:09 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 15 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Sep 07 '22 05:09 vercel[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Sep 20 '22 16:09 github-actions[bot]

/ok-to-test sha=d494ce4

eco-monk avatar Oct 08 '22 08:10 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3209783098. Workflow: Appsmith External Integration Test Workflow. Commit: d494ce4. PR: 16361.

github-actions[bot] avatar Oct 08 '22 08:10 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3209783098. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 367.78 397 351.76 350.06 339.07 339.07 351.76 361.13 16.04 6.24 5.58
painting 6.28 5.94 5.6 6.07 5.54 5.54 5.94 5.89 12.56 5.26 4.75
rendering 107.23 107.45 105.44 106.82 103.69 103.69 106.82 106.13 3.54 1.48 1.32
BIND_TABLE_DATA
scripting 1025.02 1083.41 1046.55 1095.74 1066.65 1025.02 1066.65 1063.47 6.65 2.67 2.38
painting 25.28 16.71 19.39 17.92 20.53 16.71 19.39 19.97 42.91 16.52 14.82
rendering 818.49 828.06 796.34 835.4 825.14 796.34 825.14 820.69 4.76 1.82 1.62
CLICK_ON_TABLE_ROW
scripting 808.52 878.91 869.89 862.08 915.26 808.52 869.89 866.93 12.31 4.44 3.97
painting 10.91 8.21 11.88 9.44 8.27 8.21 9.44 9.74 37.68 16.63 14.89
rendering 298.21 307.43 291.32 303.16 306.39 291.32 303.16 301.3 5.35 2.20 1.97
UPDATE_POST_TITLE
scripting 988.54 845.06 849.07 864.1 891.99 845.06 864.1 887.75 16.16 6.68 5.97
painting 8.99 8.56 8.98 7.67 10.84 7.67 8.98 9.01 35.18 12.87 11.43
rendering 573.58 597.27 577.76 590.48 604.69 573.58 590.48 588.76 5.28 2.21 1.98
OPEN_MODAL
scripting 480.01 449.61 482.08 432.87 459.57 432.87 459.57 460.83 10.68 4.51 4.03
painting 18.52 11.23 8.88 11.34 21.24 8.88 11.34 14.24 86.80 37.43 33.43
rendering 1180.3 1196.75 1171.98 1175.4 1190.8 1171.98 1180.3 1183.05 2.09 0.88 0.79
CLOSE_MODAL
scripting 194.34 177.78 170.69 168.39 231.3 168.39 177.78 188.5 33.37 13.79 12.33
painting 8.63 6.38 11.13 6.44 4.34 4.34 6.44 7.38 92.01 35.09 31.30
rendering 725.09 755.51 716.45 736.77 775.5 716.45 736.77 741.86 7.96 3.21 2.87
SELECT_WIDGET_MENU_OPEN
scripting 295.34 294.65 280.66 279.68 290 279.68 290 288.07 5.44 2.60 2.33
painting 6.35 5.86 6.24 6.44 6.72 5.86 6.35 6.32 13.61 4.91 4.43
rendering 641.6 632.93 649.49 635.83 639.72 632.93 639.72 639.91 2.59 0.99 0.88
SELECT_WIDGET_SELECT_OPTION
scripting 173.52 161.43 153.19 152.84 175.11 152.84 161.43 163.22 13.64 6.56 5.87
painting 4.16 9.72 3.43 4.37 5.87 3.43 4.37 5.51 114.16 45.74 40.83
rendering 321.3 319.08 316.48 318.78 332.76 316.48 319.08 321.68 5.06 2.00 1.79

github-actions[bot] avatar Oct 08 '22 09:10 github-actions[bot]

  • [ ] Update modal should say, ".....new app URL will be.." not "current app URL" image

  • [ ] Need more space between error text and fixed content image image

  • [ ] The input box here is disabled here because of the URL not being updated but does not convey this information since cursor turns into edit icon but CTA amounts to nothing. Provide a better feedback when such an action is taking place. image

  • [ ] Text "to new readable format to change this*" does not provide ample information since this* does not have a link or a sub text explanation following the asterisk. Or add an asterisk to the Change URL text image

  • [ ] Add a tooltip here since the purpose of this toggle is unclear image

  • [ ] Incorrect tooltip on a non-home page page. Also, the tooltip needs a rephrase image

  • [ ] Text shows lint error but nothing shows up on hover image

ramsaptami avatar Oct 21 '22 06:10 ramsaptami

@RoopKrrish9696 @kocharrahul7 Most of @ramsaptami's comments will require your input. I've added my comments at the end of each point

  • [ ] Update modal should say, ".....new app URL will be.." not "current app URL" image Comments: We're not creating a new app are we? We could make it current app's URL will be become: instead?
  • [x] Need more space between error text and fixed content image image Comments: Agreed, this is being discussed with design system. #17393 Will be trying a few workarounds meanwhile.
  • [x] The input box here is disabled here because of the URL not being updated but does not convey this information since cursor turns into edit icon but CTA amounts to nothing. Provide a better feedback when such an action is taking place. image Comments: Agreed, should be fixed by design system #17431.
  • [ ] Text "to new readable format to change this*" does not provide ample information since this* does not have a link or a sub text explanation following the astrix image Comments: this means the Page URL field here, as far as I can tell. @RoopKrrish9696 can help review this better.
  • [ ] Add a tooltip here since the purpose of this toggle is unclear image Comments: @RoopKrrish9696, FYI.
  • [ ] Incorrect tooltip on a non-home page page. Also, the tooltip needs a rephrase image Comments: Tooltip will be hidden appropriately in latest DP. @kocharrahul7 / @RoopKrrish9696, can you help with rephrasing this?
  • [ ] Text shows lint error but nothing shows up on hover image Comments: We haven't enabled linting on this field. This must be browser's grammar correction. https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_input_test Should we consider disabling that? (To be done at design system)

eco-monk avatar Oct 26 '22 07:10 eco-monk

/ok-to-test sha=3913db2

eco-monk avatar Oct 26 '22 11:10 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3328738843. Workflow: Appsmith External Integration Test Workflow. Commit: 3913db2. PR: 16361. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16361&runId=3328738843_1

github-actions[bot] avatar Oct 26 '22 11:10 github-actions[bot]

/ok-to-test sha=4b28df6

eco-monk avatar Oct 26 '22 14:10 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3330002473. Workflow: Appsmith External Integration Test Workflow. Commit: 4b28df6. PR: 16361. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16361&runId=3330002473_1

github-actions[bot] avatar Oct 26 '22 14:10 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3330002473. Workflow: Appsmith External Integration Test Workflow. Commit: 4b28df6. PR: 16361. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16361&runId=3330002473_2

github-actions[bot] avatar Oct 26 '22 15:10 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3330002473. Workflow: Appsmith External Integration Test Workflow. Commit: 4b28df6. PR: 16361. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16361&runId=3330002473_4

github-actions[bot] avatar Oct 26 '22 23:10 github-actions[bot]

/ok-to-test sha=4b28df6

eco-monk avatar Oct 26 '22 23:10 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3333370562. Workflow: Appsmith External Integration Test Workflow. Commit: 4b28df6. PR: 16361. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16361&runId=3333370562_1

github-actions[bot] avatar Oct 26 '22 23:10 github-actions[bot]

  • [ ] Functional testing issues observed from the video attached https://www.loom.com/share/964088785a054ee9a026bd857f0229a4

  • Need to improve the copy experience of the URL on page settings

  • Manually copying the URL from the field adds blank space which is incorrect

  • URL signature is incorrect when custom URL is set since it removes the page name

  • [ ] Automatic URL redirection does not happen when page name is changed (issue could be cascaded to git connected apps as well) - issue that was addressed in v1 hence its a regressed issue

  • [ ] Home page tooltip does not show up until the page has been set as a home page https://www.loom.com/share/a1bf2cbf7a1544e890cb714c11a45e6a

  • [x] Switch toggle is incorrect here since user can only mark a page as the home page, they can't un-mark it as a home page so this one-way interaction needs a re-think - can't be a switch or a checkbox https://www.loom.com/share/a1bf2cbf7a1544e890cb714c11a45e6a

Anand/Roop: When we uncheck -> something else needs to become a home page by default (not handled right now)

  • [ ] Signing in with shared URL with existing users returns a 404 https://www.loom.com/share/459880f2dc0442cabfaa6a46fcf5ebf8

ramsaptami avatar Oct 27 '22 06:10 ramsaptami

Thanks for those points @ramsaptami can you suggest what do you think would be the right terminology for the last tooltip?

RoopKrrish9696 avatar Oct 27 '22 11:10 RoopKrrish9696

@roop something on the lines of "Set current page as your homepage by clicking here" or "Toggle this to set the current page as your homepage"

ramsaptami avatar Oct 27 '22 12:10 ramsaptami

/ok-to-test sha=c83faf7

eco-monk avatar Oct 27 '22 12:10 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3337596135. Workflow: Appsmith External Integration Test Workflow. Commit: c83faf7. PR: 16361. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16361&runId=3337596135_1

github-actions[bot] avatar Oct 27 '22 12:10 github-actions[bot]

/ok-to-test sha=4759d4a

eco-monk avatar Oct 28 '22 06:10 eco-monk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3343256471. Workflow: Appsmith External Integration Test Workflow. Commit: 4759d4a. PR: 16361. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16361&runId=3343256471_1

github-actions[bot] avatar Oct 28 '22 06:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 28 '22 13:10 github-actions[bot]