appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Maintain Focus and Context Phase 1

Open hetunandu opened this issue 2 years ago • 46 comments

Description

Phase 1 of maintaining focus and context

Fixes #16456 Fixes #15789

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

TODO

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

hetunandu avatar Aug 26 '22 04:08 hetunandu

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 7:53AM (UTC)

vercel[bot] avatar Aug 26 '22 04:08 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 26 '22 04:08 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 29 '22 05:08 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 29 '22 05:08 github-actions[bot]

/ok-to-test sha=4dc2854

hetunandu avatar Aug 30 '22 08:08 hetunandu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2954903203. Workflow: Appsmith External Integration Test Workflow. Commit: 4dc2854. PR: 16317.

github-actions[bot] avatar Aug 30 '22 08:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2954903203. Commit: 4dc2854. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 319.37 334.78 375.37 480.62 344.21 344.21 370.87 43.48 17.44 15.60
painting 3.68 5.86 4.18 4.99 5.83 4.99 4.91 44.40 19.76 17.72
rendering 112.64 117.64 122.77 118.98 126.58 118.98 119.72 11.64 4.41 3.94
BIND_TABLE_DATA
scripting 1343.76 1207.11 1320.37 1223.18 1200.48 1223.18 1258.98 11.38 5.38 4.81
painting 26.47 12.23 27.58 21.68 23.7 23.7 22.33 68.74 27.32 24.45
rendering 497.45 475.86 513.99 488.1 488.83 488.83 492.85 7.74 2.86 2.56
CLICK_ON_TABLE_ROW
scripting 904.12 931.67 966.15 956.29 943.55 943.55 940.36 6.60 2.56 2.29
painting 12.21 10.69 15.11 14.36 14.25 14.25 13.32 33.18 13.66 12.24
rendering 318.03 312.45 351.94 325.77 320.43 320.43 325.72 12.12 4.73 4.23
UPDATE_POST_TITLE
scripting 1567.33 1519.02 1675.48 1694.77 1551.1 1567.33 1601.54 10.97 4.90 4.39
painting 17.28 21.33 17.87 20.85 23.4 20.85 20.15 30.37 12.61 11.32
rendering 490.9 514 562.46 536.66 515.37 515.37 523.88 13.66 5.15 4.60
OPEN_MODAL
scripting 651.18 643.14 861.99 623.36 608.43 643.14 677.62 37.42 15.41 13.78
painting 12.03 14.9 13.56 10.99 27.45 13.56 15.79 104.24 42.37 37.87
rendering 441.53 429.18 574.48 432.45 421.92 432.45 459.91 33.17 14.01 12.53
CLOSE_MODAL
scripting 341.56 359.57 377.97 351.47 423.47 359.57 370.81 22.09 8.72 7.80
painting 6.71 13.51 9.26 24.11 18.92 13.51 14.5 120.00 48.90 43.72
rendering 665.84 654.54 683.72 676.43 706.35 676.43 677.38 7.65 2.89 2.59
SELECT_WIDGET_MENU_OPEN
scripting 1114.24 1149.64 1295.6 1187.6 1271.25 1187.6 1203.67 15.07 6.46 5.78
painting 5.27 4.75 25.49 4.65 6.23 5.27 9.28 224.57 97.84 87.61
rendering 633.04 638.12 692.82 649.1 730.98 649.1 668.81 14.64 6.28 5.61
SELECT_WIDGET_SELECT_OPTION
scripting 160.42 162.37 182.1 166.08 186.73 166.08 171.54 15.34 7.02 6.28
painting 4.35 5.33 6.12 4.24 3.96 4.35 4.8 45.00 18.75 16.88
rendering 326.14 322.27 366.99 333.88 332.28 332.28 336.31 13.30 5.29 4.73

github-actions[bot] avatar Aug 30 '22 09:08 github-actions[bot]

/ok-to-test sha=ce929ac

rahulramesha avatar Sep 07 '22 16:09 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3009339250. Workflow: Appsmith External Integration Test Workflow. Commit: ce929ac. PR: 16317.

github-actions[bot] avatar Sep 07 '22 16:09 github-actions[bot]

/ok-to-test sha=5230746

rahulramesha avatar Sep 08 '22 14:09 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3016086332. Workflow: Appsmith External Integration Test Workflow. Commit: 5230746. PR: 16317.

github-actions[bot] avatar Sep 08 '22 14:09 github-actions[bot]

/ok-to-test sha=cf60ab3

rahulramesha avatar Sep 09 '22 14:09 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3023098029. Workflow: Appsmith External Integration Test Workflow. Commit: cf60ab3. PR: 16317.

github-actions[bot] avatar Sep 09 '22 14:09 github-actions[bot]

/ok-to-test sha=f8a9b18

rahulramesha avatar Sep 09 '22 20:09 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3025143762. Workflow: Appsmith External Integration Test Workflow. Commit: f8a9b18. PR: 16317.

github-actions[bot] avatar Sep 09 '22 20:09 github-actions[bot]

/ok-to-test sha=afd8e7c

hetunandu avatar Sep 12 '22 05:09 hetunandu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3034944873. Workflow: Appsmith External Integration Test Workflow. Commit: afd8e7c. PR: 16317.

github-actions[bot] avatar Sep 12 '22 05:09 github-actions[bot]

/ok-to-test sha=ae3735b

akash-codemonk avatar Sep 13 '22 08:09 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3044313208. Workflow: Appsmith External Integration Test Workflow. Commit: ae3735b. PR: 16317.

github-actions[bot] avatar Sep 13 '22 10:09 github-actions[bot]

@hetunandu [New App] Page1 theme properties changes are reflecting on Page2 & vice-versa When the user creates two pages and on "Page1" from the Property pane under "Theme Properties" closes 'Font' , 'Color' & 'Border' properties and switches to "Page2" observes that the same changes on "Page2" & vice-versa.

  1. Go to DP URL:- https://appsmith-eputc306c-get-appsmith.vercel.app/user/login
  2. Click on 'New Workspace' & create a new app
  3. Create two pages on the same app "Page1" & "Page2"
  4. Now from the 'Property Pane' under "Theme Properties" close 'Font' , 'Color' & 'Border' properties
  5. Switch to "Page2" & observe

Actual Result "Page1" theme properties changes are reflecting on "Page2"

Expected Result "Page1" theme properties changes should not reflect on "Page2" & vice- versa

NOTE Working fine on old apps. Refer to the attached video. https://www.loom.com/share/6ddb454c7dff4969ab9a715c14b6eb56

Richarex avatar Sep 13 '22 11:09 Richarex

@Richarex, this seems to be existing behaviour in release, could you please check and confirm?. We haven't really thought about this use case, Will tackle this in Phase 2 of context switching.

rahulramesha avatar Sep 13 '22 18:09 rahulramesha

/ok-to-test sha=be7b268

rahulramesha avatar Sep 13 '22 18:09 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3047546981. Workflow: Appsmith External Integration Test Workflow. Commit: be7b268. PR: 16317.

github-actions[bot] avatar Sep 13 '22 18:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3047546981. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 1092.87 | 336.17 | 329.78 | 335.59 | 321.76 | 321.76| 335.59| 483.23 | 159.57| 70.54 | 63.09| | painting | 4.62 | 5.51 | 4.46 | 3.35 | 3.77 | 3.35| 4.46| 4.34 | 49.77| 19.12 | 17.05| | rendering | 111.04 | 106.82 | 107.98 | 107.21 | 103.33 | 103.33| 107.21| 107.28 | 7.19| 2.57 | 2.30| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1010.2 | 1017.61 | 992.53 | 1040.18 | 1017.43 | 992.53| 1017.43| 1015.59 | 4.69| 1.69 | 1.51| | painting | 23.63 | 21.77 | 15.6 | 22.5 | 19.27 | 15.6| 21.77| 20.55 | 39.08| 15.57 | 13.92| | rendering | 802.52 | 817.76 | 830.75 | 827.73 | 808.74 | 802.52| 817.76| 817.5 | 3.45| 1.48 | 1.32| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 884.79 | 861.25 | 823.16 | 858.56 | 814.67 | 814.67| 858.56| 848.49 | 8.26| 3.42 | 3.06| | painting | 9.55 | 9.75 | 21.86 | 10.66 | 12.64 | 9.55| 10.66| 12.89 | 95.50| 40.03 | 35.84| | rendering | 301.49 | 304.3 | 302.17 | 316.48 | 338.8 | 301.49| 304.3| 312.65 | 11.93| 5.06 | 4.53| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1308.83 | 1256.9 | 1233.8 | 1301.02 | 1273.34 | 1233.8| 1273.34| 1274.78 | 5.89| 2.43 | 2.18| | painting | 19.39 | 15.14 | 14.36 | 13.67 | 14.6 | 13.67| 14.6| 15.43 | 37.07| 14.71 | 13.16| | rendering | 471.95 | 458.95 | 453.16 | 471.55 | 438.66 | 438.66| 458.95| 458.85 | 7.26| 3.03 | 2.71| OPEN_MODAL| | | | | | | | | | | | scripting | 535.2 | 517.29 | 543.58 | 576.3 | 502.67 | 502.67| 535.2| 535.01 | 13.76| 5.24 | 4.68| | painting | 15.26 | 17.27 | 16.06 | 12.45 | 10.67 | 10.67| 15.26| 14.34 | 46.03| 18.90 | 16.95| | rendering | 500.23 | 499.99 | 510.54 | 530.98 | 493.92 | 493.92| 500.23| 507.13 | 7.31| 2.88 | 2.58| CLOSE_MODAL| | | | | | | | | | | | scripting | 275.47 | 292.48 | 320.79 | 301.37 | 295.3 | 275.47| 295.3| 297.08 | 15.26| 5.51 | 4.93| | painting | 13.4 | 15.91 | 13.38 | 14.87 | 12.87 | 12.87| 13.4| 14.09 | 21.58| 8.94 | 8.02| | rendering | 334.67 | 347.22 | 362.92 | 353.28 | 352.42 | 334.67| 352.42| 350.1 | 8.07| 2.95 | 2.64| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 909.56 | 920 | 970.77 | 967.47 | 880.04 | 880.04| 920| 929.57 | 9.76| 4.19 | 3.75| | painting | 6.15 | 4.82 | 10.45 | 6.23 | 4.01 | 4.01| 6.15| 6.33 | 101.74| 39.18 | 35.07| | rendering | 603.27 | 617.98 | 627.84 | 638.92 | 585.62 | 585.62| 617.98| 614.73 | 8.67| 3.40 | 3.04| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 162.84 | 159.12 | 150.5 | 157.34 | 153.58 | 150.5| 157.34| 156.68 | 7.88| 3.06 | 2.74| | painting | 2.46 | 6.59 | 3.68 | 16.69 | 2.02 | 2.02| 3.68| 6.29 | 233.23| 96.66 | 86.49| | rendering | 315.87 | 311.8 | 305.62 | 311.31 | 295.47 | 295.47| 311.31| 308.01 | 6.62| 2.57 | 2.30|

github-actions[bot] avatar Sep 13 '22 19:09 github-actions[bot]

/ok-to-test sha=5beb968

akash-codemonk avatar Sep 14 '22 05:09 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3050416577. Workflow: Appsmith External Integration Test Workflow. Commit: 5beb968. PR: 16317.

github-actions[bot] avatar Sep 14 '22 05:09 github-actions[bot]

/ok-to-test sha=3f20b5a

akash-codemonk avatar Sep 14 '22 15:09 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3053969703. Workflow: Appsmith External Integration Test Workflow. Commit: 3f20b5a. PR: 16317.

github-actions[bot] avatar Sep 14 '22 15:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3053969703. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 370.33 | 348.62 | 375.49 | 312.84 | 369.19 | 312.84| 369.19| 355.29 | 17.63| 7.28 | 6.51| | painting | 8.74 | 4.29 | 6.88 | 4.99 | 3.32 | 3.32| 4.99| 5.64 | 96.10| 38.48 | 34.40| | rendering | 110.05 | 112.55 | 110.18 | 102.27 | 113.51 | 102.27| 110.18| 109.71 | 10.25| 4.03 | 3.60| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1019.56 | 1160.5 | 1020.99 | 1047.45 | 1191.85 | 1019.56| 1047.45| 1088.07 | 15.83| 7.53 | 6.74| | painting | 18.31 | 28.19 | 22.87 | 25.94 | 26.49 | 18.31| 25.94| 24.36 | 40.56| 15.97 | 14.29| | rendering | 834.49 | 896.07 | 811.05 | 865.91 | 914.8 | 811.05| 865.91| 864.46 | 12.00| 4.94 | 4.42| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 737.67 | 962.92 | 829.6 | 855.55 | 1123.98 | 737.67| 855.55| 901.94 | 42.83| 16.39 | 14.66| | painting | 10.09 | 10.28 | 9.94 | 10.19 | 14.21 | 9.94| 10.19| 10.94 | 39.03| 16.73 | 14.99| | rendering | 299.85 | 330.38 | 297.05 | 309.29 | 356.59 | 297.05| 309.29| 318.63 | 18.69| 7.82 | 7.00| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1344.71 | 1398.24 | 1151.67 | 1218.97 | 2403.32 | 1151.67| 1344.71| 1503.38 | 83.26| 34.09 | 30.49| | painting | 16.14 | 18.69 | 14.39 | 13.16 | 26.71 | 13.16| 16.14| 17.82 | 76.04| 30.25 | 27.05| | rendering | 464.09 | 497.1 | 428.13 | 449 | 597.72 | 428.13| 464.09| 487.21 | 34.81| 13.69 | 12.25| OPEN_MODAL| | | | | | | | | | | | scripting | 499.48 | 522.77 | 447.07 | 458.19 | 763.19 | 447.07| 499.48| 538.14 | 58.74| 24.06 | 21.52| | painting | 12.2 | 18.79 | 14.24 | 12.73 | 23.18 | 12.2| 14.24| 16.23 | 67.65| 28.77 | 25.75| | rendering | 511.63 | 525.57 | 481.85 | 500.29 | 686.18 | 481.85| 511.63| 541.1 | 37.76| 15.28 | 13.66| CLOSE_MODAL| | | | | | | | | | | | scripting | 215.48 | 738.04 | 203.94 | 244.58 | 396.32 | 203.94| 244.58| 359.67 | 148.50| 62.60 | 55.99| | painting | 23.75 | 12.14 | 10.42 | 12.26 | 12.91 | 10.42| 12.26| 14.3 | 93.22| 37.48 | 33.57| | rendering | 345.12 | 372.92 | 343.8 | 346.86 | 467.54 | 343.8| 346.86| 375.25 | 32.98| 14.12 | 12.63| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 983.49 | 936.34 | 908.85 | 1061.32 | 1065.16 | 908.85| 983.49| 991.03 | 15.77| 7.18 | 6.42| | painting | 5.85 | 4.64 | 4.07 | 14.24 | 7.46 | 4.07| 5.85| 7.25 | 140.28| 56.83 | 50.76| | rendering | 650.38 | 607.2 | 607.1 | 731.64 | 710.97 | 607.1| 650.38| 661.46 | 18.83| 8.75 | 7.83| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 158.72 | 162.69 | 162.56 | 195.19 | 202.92 | 158.72| 162.69| 176.42 | 25.05| 11.85 | 10.60| | painting | 4.37 | 3.44 | 2.71 | 18.92 | 3.1 | 2.71| 3.44| 6.51 | 249.00| 107.07 | 95.70| | rendering | 324.14 | 303.44 | 312.02 | 373.78 | 339.16 | 303.44| 324.14| 330.51 | 21.28| 8.37 | 7.49|

github-actions[bot] avatar Sep 14 '22 15:09 github-actions[bot]

/ok-to-test sha=f78ecbd

rahulramesha avatar Sep 14 '22 18:09 rahulramesha