appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: Re-selecting dropdown value triggers evaluation cycle

Open aswathkk opened this issue 2 years ago • 14 comments

Description

Reselecting the selected value from the dropdown control in the property pane results in an unnecessary update Property call which leads to the app getting saved and a subsequent evaluations cycle

Fixes #15625

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

aswathkk avatar Aug 23 '22 05:08 aswathkk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 4:45PM (UTC)

vercel[bot] avatar Aug 23 '22 05:08 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 23 '22 05:08 github-actions[bot]

/ok-to-test sha=2fd1522

aswathkk avatar Aug 23 '22 06:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2909437659. Workflow: Appsmith External Integration Test Workflow. Commit: 2fd1522. PR: 16201.

github-actions[bot] avatar Aug 23 '22 07:08 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2909437659. Workflow: Appsmith External Integration Test Workflow. Commit: 2fd1522. PR: 16201.

github-actions[bot] avatar Aug 23 '22 14:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2909437659. Commit: 2fd1522. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 303.35 345.58 326.62 327.01 1020.14 327.01 464.54 154.30 66.94 59.87
painting 5.67 3.79 6.59 4.3 3.06 4.3 4.68 75.43 30.56 27.35
rendering 117.06 107.69 114.7 107.75 106.53 107.75 110.75 9.51 4.33 3.86
BIND_TABLE_DATA
scripting 1494.09 1548.36 1543.51 1478.49 1491.56 1494.09 1511.2 4.62 2.14 1.91
painting 15.72 12.25 26.34 12.09 19.34 15.72 17.15 83.09 34.64 30.96
rendering 419.2 437.95 465.33 413.53 443.2 437.95 435.84 11.89 4.73 4.23
CLICK_ON_TABLE_ROW
scripting 749.35 893.2 1303.72 836.25 854.64 854.64 927.43 59.77 23.38 20.91
painting 8.96 15.51 10.76 9.48 18.77 10.76 12.7 77.24 33.62 30.08
rendering 310.48 302.77 308.5 293.51 306.68 306.68 304.39 5.58 2.20 1.97
UPDATE_POST_TITLE
scripting 1385.95 1467.78 1502.95 1264.59 1428.36 1428.36 1409.93 16.91 6.54 5.85
painting 13.5 17.71 15.44 12.84 21.55 15.44 16.21 53.73 21.84 19.49
rendering 457.43 466.82 471.06 450.32 460.86 460.86 461.3 4.50 1.75 1.57
OPEN_MODAL
scripting 497.49 536.24 527.63 541.53 510.89 527.63 522.76 8.42 3.50 3.13
painting 8.98 16.28 14.05 16.01 12.49 14.05 13.56 53.83 22.05 19.69
rendering 374.02 384.78 381.42 383.43 373 381.42 379.33 3.11 1.44 1.29
CLOSE_MODAL
scripting 289.78 333.5 343.93 293.6 317.07 317.07 315.58 17.16 7.56 6.76
painting 12.64 8.27 4.88 4.55 13.65 8.27 8.8 103.41 48.18 43.07
rendering 616.72 627.98 627.12 611.81 620.49 620.49 620.82 2.60 1.11 0.99
SELECT_WIDGET_MENU_OPEN
scripting 1114.15 1127.56 1080.6 1075.84 1032.88 1080.6 1086.21 8.72 3.41 3.05
painting 9.2 7.02 8.52 5.58 6.44 7.02 7.35 49.25 20.27 18.10
rendering 631.16 663.66 607.23 626.78 589.6 626.78 623.69 11.87 4.46 3.99
SELECT_WIDGET_SELECT_OPTION
scripting 141.32 142.36 136.12 141.1 141.56 141.32 140.49 4.44 1.77 1.59
painting 11.33 3.89 3.9 8.96 3.43 3.9 6.3 125.40 57.30 51.27
rendering 315.53 317.87 311.22 301.41 319.93 315.53 313.19 5.91 2.34 2.09

github-actions[bot] avatar Aug 23 '22 15:08 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 24 '22 01:08 github-actions[bot]

List of dropdown properties for several widgets which are still showing the evaluation trigger are shared with @aswathkk. Moving to In progress.

Sripriya93 avatar Aug 30 '22 04:08 Sripriya93

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Sep 06 '22 16:09 github-actions[bot]

Still could find few widgets showing the evaluation trigger shared it with @aswathkk , moving to In progress.

Sripriya93 avatar Sep 13 '22 10:09 Sripriya93

Working fine, moving to done. Have checked all the widgets with dropdown property.

Sripriya93 avatar Sep 21 '22 09:09 Sripriya93

/ok-to-test sha=a4958ff

aswathkk avatar Sep 21 '22 10:09 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3097428177. Workflow: Appsmith External Integration Test Workflow. Commit: a4958ff. PR: 16201.

github-actions[bot] avatar Sep 21 '22 11:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3097428177. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 414.15 | 419.39 | 405.88 | 510.31 | 470.06 | 405.88| 419.39| 443.96 | 23.52| 10.09 | 9.02| | painting | 7 | 13.83 | 3.78 | 4.73 | 6.16 | 3.78| 6.16| 7.1 | 141.55| 55.77 | 49.86| | rendering | 115.79 | 113.47 | 117.94 | 141.44 | 120.91 | 113.47| 117.94| 121.91 | 22.94| 9.24 | 8.26| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1137.43 | 1163.88 | 1389.48 | 1727.1 | 1166.22 | 1137.43| 1166.22| 1316.82 | 44.78| 19.06 | 17.04| | painting | 22.73 | 28.17 | 31.7 | 22.79 | 26.42 | 22.73| 26.42| 26.36 | 34.03| 14.42 | 12.90| | rendering | 886.92 | 919.02 | 1079.33 | 702.93 | 949.29 | 702.93| 919.02| 907.5 | 41.48| 14.96 | 13.38| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 948.43 | 1020.8 | 1245.96 | 1469.62 | 1129.12 | 948.43| 1129.12| 1162.79 | 44.82| 17.64 | 15.78| | painting | 10.46 | 24.75 | 13.94 | 17.79 | 12.22 | 10.46| 13.94| 15.83 | 90.27| 35.88 | 32.09| | rendering | 314.21 | 331.74 | 414.18 | 445.85 | 332.32 | 314.21| 332.32| 367.66 | 35.80| 15.90 | 14.23| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1881.03 | 1893.95 | 2073.43 | 2156.63 | 1796.95 | 1796.95| 1893.95| 1960.4 | 18.35| 7.60 | 6.79| | painting | 23.53 | 23.06 | 21.52 | 27.59 | 19.92 | 19.92| 23.06| 23.12 | 33.17| 12.41 | 11.12| | rendering | 514.1 | 525.99 | 563.98 | 588.16 | 545.81 | 514.1| 545.81| 547.61 | 13.52| 5.41 | 4.84| OPEN_MODAL| | | | | | | | | | | | scripting | 533.16 | 580.76 | 679.71 | 732.87 | 570.27 | 533.16| 580.76| 619.35 | 32.25| 13.47 | 12.05| | painting | 9.86 | 10.77 | 13.96 | 17.7 | 10.68 | 9.86| 10.77| 12.59 | 62.27| 25.89 | 23.11| | rendering | 424.55 | 413.04 | 473.35 | 556.32 | 426.3 | 413.04| 426.3| 458.71 | 31.24| 12.92 | 11.55| CLOSE_MODAL| | | | | | | | | | | | scripting | 274.42 | 263.75 | 270.83 | 398.65 | 303.33 | 263.75| 274.42| 302.2 | 44.64| 18.53 | 16.57| | painting | 9.46 | 4.63 | 7.54 | 9.15 | 9.53 | 4.63| 9.15| 8.06 | 60.79| 25.81 | 23.08| | rendering | 373.06 | 347.44 | 433.51 | 487.95 | 387.83 | 347.44| 387.83| 405.96 | 34.61| 13.67 | 12.23| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 1078.54 | 1094.72 | 1216.91 | 1079.61 | 1064.74 | 1064.74| 1079.61| 1106.9 | 13.75| 5.64 | 5.04| | painting | 9.23 | 6.77 | 9.55 | 8.56 | 12.59 | 6.77| 9.23| 9.34 | 62.31| 22.59 | 20.24| | rendering | 672.72 | 778.08 | 888.57 | 711.8 | 662.7 | 662.7| 711.8| 742.77 | 30.41| 12.55 | 11.23| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 202.24 | 191.78 | 231.26 | 185.64 | 170 | 170| 191.78| 196.18 | 31.23| 11.63 | 10.40| | painting | 2.64 | 2.68 | 3.73 | 2.89 | 2.44 | 2.44| 2.68| 2.88 | 44.79| 17.36 | 15.63| | rendering | 397.37 | 338.65 | 472.28 | 375.21 | 305.12 | 305.12| 375.21| 377.73 | 44.25| 16.81 | 15.04|

github-actions[bot] avatar Sep 21 '22 12:09 github-actions[bot]

/ok-to-test sha=5f307a2

aswathkk avatar Sep 22 '22 12:09 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3105322535. Workflow: Appsmith External Integration Test Workflow. Commit: 5f307a2. PR: 16201.

github-actions[bot] avatar Sep 22 '22 12:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3105322535. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 330.07 353.38 382.28 390.43 381.12 330.07 381.12 367.46 16.43 6.84 6.12
painting 4.57 8.25 3.93 5.1 4.64 3.93 4.64 5.3 81.51 32.08 28.68
rendering 102.72 105.45 110.14 111.27 108.56 102.72 108.56 107.63 7.94 3.26 2.92
BIND_TABLE_DATA
scripting 1208.24 1099.66 1186.68 1528.45 1194.07 1099.66 1194.07 1243.42 34.48 13.26 11.86
painting 16.08 22.43 30.8 20.57 28.3 16.08 22.43 23.64 62.27 25.13 22.46
rendering 787.04 819.58 873.77 524.67 902.46 524.67 819.58 781.5 48.34 19.26 17.22
CLICK_ON_TABLE_ROW
scripting 810.43 931.95 1013.85 1492 982.51 810.43 982.51 1046.15 65.15 24.95 22.31
painting 13.73 12.88 10.54 11.81 10.5 10.5 11.81 11.89 27.17 12.03 10.68
rendering 299.3 313.23 311.27 406.89 316.42 299.3 313.23 329.42 32.66 13.29 11.89
UPDATE_POST_TITLE
scripting 1487.19 1296.84 1519.78 1668.25 1605.41 1296.84 1519.78 1515.49 24.51 9.33 8.35
painting 13.56 13.13 18.73 17.99 18 13.13 17.99 16.28 34.40 16.58 14.86
rendering 447.96 453.93 472.92 492.63 493.29 447.96 472.92 472.15 9.60 4.47 4.00
OPEN_MODAL
scripting 481.58 455.16 455.84 615.4 483.56 455.16 481.58 498.31 32.16 13.42 12.00
painting 12.52 9 8.91 18.95 9.53 8.91 9.53 11.78 85.23 36.25 32.43
rendering 376.32 382.3 381.48 426.62 406.08 376.32 382.3 394.56 12.75 5.40 4.83
CLOSE_MODAL
scripting 221.72 153.27 212.85 320.58 191.51 153.27 212.85 219.99 76.05 28.24 25.26
painting 4.94 17.94 24 19.28 10.37 4.94 17.94 15.31 124.49 49.58 44.28
rendering 351.88 321.64 368.57 413.35 351.11 321.64 351.88 361.31 25.38 9.31 8.33
SELECT_WIDGET_MENU_OPEN
scripting 929.84 1001.36 1067.58 1231.21 1005.15 929.84 1005.15 1047.03 28.78 10.88 9.73
painting 15.4 6.03 7.59 13.23 19.15 6.03 13.23 12.28 106.84 44.38 39.74
rendering 592.77 640.32 678.54 750.26 657.57 592.77 657.57 663.89 23.72 8.69 7.78
SELECT_WIDGET_SELECT_OPTION
scripting 163.49 174.61 210.13 179.58 211.62 163.49 179.58 187.89 25.62 11.60 10.37
painting 2.42 6.34 3.12 7.45 4.31 2.42 4.31 4.73 106.34 45.03 40.17
rendering 320.07 321.08 327.86 329.41 325.42 320.07 325.42 324.77 2.88 1.26 1.13

github-actions[bot] avatar Sep 22 '22 12:09 github-actions[bot]

/ok-to-test sha=680e040

aswathkk avatar Sep 27 '22 16:09 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3137375026. Workflow: Appsmith External Integration Test Workflow. Commit: 680e040. PR: 16201.

github-actions[bot] avatar Sep 27 '22 16:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3137375026. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 365.78 333.22 361.88 368.18 334.91 333.22 361.88 352.79 9.91 4.89 4.37
painting 5.7 4.81 3.44 4.99 3.99 3.44 4.81 4.59 49.24 19.17 17.21
rendering 102.7 103.91 107.29 107.9 105.13 102.7 105.13 105.39 4.93 2.09 1.87
BIND_TABLE_DATA
scripting 1147.56 1098.37 1138.42 1126.08 1047.04 1047.04 1126.08 1111.49 9.04 3.64 3.26
painting 23.99 18.93 23.99 13.75 15.31 13.75 18.93 19.19 53.36 24.80 22.20
rendering 841.06 776.65 868.22 859.6 801.2 776.65 841.06 829.35 11.04 4.72 4.22
CLICK_ON_TABLE_ROW
scripting 890.11 1121.01 928.05 922.59 905.43 890.11 922.59 953.44 24.22 9.95 8.90
painting 14.55 12.14 9.09 12.44 9.95 9.09 12.14 11.63 46.95 18.57 16.60
rendering 299.63 289.35 314.46 302.35 301.8 289.35 301.8 301.52 8.33 2.96 2.65
UPDATE_POST_TITLE
scripting 1442.36 1408.22 1547.47 1319 1330.86 1319 1408.22 1409.58 16.21 6.59 5.89
painting 13.74 13.52 23.66 17.95 12.22 12.22 13.74 16.22 70.53 28.85 25.83
rendering 456.19 466.52 483.92 448.19 446.28 446.28 456.19 460.22 8.18 3.36 3.01
OPEN_MODAL
scripting 431.03 433.59 465.88 436.85 442.1 431.03 436.85 441.89 7.89 3.17 2.84
painting 7.68 9.46 14.2 8.27 18.19 7.68 9.46 11.56 90.92 39.01 34.86
rendering 375.77 387.31 374.63 382 378.36 374.63 378.36 379.61 3.34 1.36 1.21
CLOSE_MODAL
scripting 183.33 171.56 214.11 163.42 216.91 163.42 183.33 189.87 28.17 12.89 11.53
painting 4.31 3.81 5.04 14.47 4.39 3.81 4.39 6.4 166.56 70.78 63.28
rendering 329.88 323.19 385.65 333.3 345.4 323.19 333.3 343.48 18.18 7.25 6.49
SELECT_WIDGET_MENU_OPEN
scripting 937.25 954.86 943.75 964.38 910.79 910.79 943.75 942.21 5.69 2.17 1.94
painting 7.99 5 5.64 6.72 8.49 5 6.72 6.77 51.55 22.01 19.65
rendering 597.85 621.91 610.18 593.24 590.19 590.19 597.85 602.67 5.26 2.19 1.96
SELECT_WIDGET_SELECT_OPTION
scripting 157.36 163.16 159.38 164.5 151.76 151.76 159.38 159.23 8.00 3.18 2.84
painting 3.33 3.59 3.43 6.51 3.71 3.33 3.59 4.11 77.37 32.85 29.44
rendering 305.76 313.33 313 314.33 307.08 305.76 313 310.7 2.76 1.28 1.14

github-actions[bot] avatar Sep 27 '22 17:09 github-actions[bot]