appsmith
appsmith copied to clipboard
feat: Making the error messages in amazon s3 plugin informative
Description
Makes the s3 errors more readable by following the
This feature makes changes to three files:
* ./server/appsmith-plugins/amazons3Plugin/.../AmazonS3Plugin.java
* ./server/appsmith-plugins/amazons3Plugin/...//AmazonS3ErrorUtils.java
* ./server/appsmith-plugins/amazons3Plugin/.../AmazonS3PluginTest.java
* ./server/appsmith-plugins/amazons3Plugin/.../AmazonS3ErrorUtilsTest.java
Fixes #8554
Type of change
- 🚀 New feature -> Makes the amazon s3 error messages more readable and follows s3 error naming convention
How Has This Been Tested?
- Manual testing
- Junit Testing
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
appsmith | ⬜️ Ignored (Inspect) | Aug 9, 2022 at 8:58AM (UTC) |
/ok-to-test sha=d030460
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2825216940.
Workflow: Appsmith External Integration Test Workflow
.
Commit: d030460
.
PR: 15861.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2825216940.
Commit: d030460
.
Results: Click to view performance test results
Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
---|---|---|---|---|---|---|---|---|---|
SELECT_WIDGET_MENU_OPEN | |||||||||
scripting | 1100.88 | 1052.15 | 1033.87 | 1028.56 | 1082.91 | 1052.15 | 1059.67 | 2.96 | 2.65 |
painting | 14.73 | 6.37 | 12.34 | 5.91 | 11.85 | 11.85 | 10.24 | 38.09 | 34.08 |
rendering | 917.57 | 838.02 | 817.26 | 816.63 | 823.69 | 823.69 | 842.63 | 5.08 | 4.54 |
SELECT_WIDGET_SELECT_OPTION | |||||||||
scripting | 168.18 | 165.64 | 172.73 | 170.71 | 152.2 | 168.18 | 165.89 | 4.88 | 4.37 |
painting | 4.04 | 2.16 | 4.6 | 13.61 | 9.04 | 4.6 | 6.69 | 69.06 | 61.73 |
rendering | 316.71 | 307.3 | 298.13 | 311.63 | 305.61 | 307.3 | 307.88 | 2.25 | 2.02 |
Since unit tests are added, skipping Cypress! Hence, adding 'TestPlanApproved'.
/ok-to-test sha=d030460
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2858192718.
Workflow: Appsmith External Integration Test Workflow
.
Commit: d030460
.
PR: 15861.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2858192718.
Commit: d030460
.
Results: Click to view performance test results
Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
---|---|---|---|---|---|---|---|---|---|
SELECT_WIDGET_MENU_OPEN | |||||||||
scripting | 1006.35 | 1034.55 | 1054.24 | 1046.13 | 1047.6 | 1046.13 | 1037.77 | 1.83 | 1.63 |
painting | 11.05 | 4.97 | 5.25 | 11.24 | 9.6 | 9.6 | 8.42 | 36.70 | 32.78 |
rendering | 806.43 | 809.27 | 810.82 | 810.7 | 817.65 | 810.7 | 810.97 | 0.51 | 0.46 |
SELECT_WIDGET_SELECT_OPTION | |||||||||
scripting | 160.29 | 140.76 | 151.75 | 161.59 | 158.58 | 158.58 | 154.59 | 5.57 | 4.98 |
painting | 6.62 | 5.61 | 2.07 | 9.02 | 5.12 | 5.61 | 5.69 | 44.29 | 39.54 |
rendering | 296.69 | 296.09 | 296.09 | 302.41 | 303.14 | 296.69 | 298.88 | 1.19 | 1.07 |