appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: autocomplete fixes & enhancement

Open rishabhrathod01 opened this issue 2 years ago • 6 comments

Description

  • Add Auto-completion for Document viewer widget
  • Add Auto-completion for complex objects making array of object autocompletion work.
  • Add Auto-completion statement to get a code snippet for loops, conditions and so on.

Fixes #15568 Fixes #13613

Type

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement

How Has This Been Tested?

Cypress test

  • [x] Document viewer widget autocompletion test
  • [x] complex local variable autocompletion test
  • [x] Api data response autocompletion test
  • [ ] Autocompletion test for code snippets

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

rishabhrathod01 avatar Aug 09 '22 05:08 rishabhrathod01

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 9:56AM (UTC)

vercel[bot] avatar Aug 09 '22 05:08 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 09 '22 05:08 github-actions[bot]

/ok-to-test sha=7a7e12b

rishabhrathod01 avatar Aug 09 '22 20:08 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2828033105. Workflow: Appsmith External Integration Test Workflow. Commit: 7a7e12b. PR: 15857.

github-actions[bot] avatar Aug 09 '22 20:08 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2828033105. Workflow: Appsmith External Integration Test Workflow. Commit: 7a7e12b. PR: 15857.

github-actions[bot] avatar Aug 10 '22 04:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2828033105. Commit: 7a7e12b. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1176.28 1069.61 1101.55 1094.78 1079.03 1094.78 1104.25 3.82 3.42
painting 10.8 16.46 11 6.91 8.55 10.8 10.74 33.61 30.07
rendering 873.72 840.48 833.28 854.95 829.28 840.48 846.34 2.15 1.92
SELECT_WIDGET_SELECT_OPTION
scripting 164.41 152.96 168.65 169 189.86 168.65 168.98 7.91 7.07
painting 2.56 5.56 3.36 3.32 2.64 3.32 3.49 34.96 31.23
rendering 303.75 297.69 292 299.74 305.75 299.74 299.79 1.80 1.61

github-actions[bot] avatar Aug 10 '22 05:08 github-actions[bot]

Edge case where this. suggests own function image

ramsaptami avatar Aug 10 '22 15:08 ramsaptami

Edge case where this. suggests own function image

This issue if fixed in this PR now. @ramsaptami

rishabhrathod01 avatar Aug 11 '22 07:08 rishabhrathod01

/ok-to-test sha=f7523a2

rishabhrathod01 avatar Aug 11 '22 10:08 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2839498027. Workflow: Appsmith External Integration Test Workflow. Commit: f7523a2. PR: 15857.

github-actions[bot] avatar Aug 11 '22 12:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2839498027. Commit: f7523a2. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1093.58 1087.08 1065.74 1065 1060.38 1065.74 1074.36 1.39 1.24
painting 7.07 5.92 10.44 9.75 12.3 9.75 9.1 28.35 25.38
rendering 845.74 842.85 847.27 840.33 858 845.74 846.84 0.80 0.72
SELECT_WIDGET_SELECT_OPTION
scripting 150.67 148.07 153.11 172.54 162.11 153.11 157.3 6.38 5.70
painting 6.49 2.64 8.7 9.11 3.44 6.49 6.08 48.68 43.59
rendering 317.16 313.12 315.68 315.63 318.79 315.68 316.08 0.66 0.59

github-actions[bot] avatar Aug 11 '22 13:08 github-actions[bot]

We have 2 suggestions that come up after impletmenting this PR, is this how VS handles it as well? @Rishabh-Rathod image

ramsaptami avatar Aug 11 '22 14:08 ramsaptami

We have 2 suggestions that come up after impletmenting this PR, is this how VS handles it as well? @Rishabh-Rathod image

Yes, VScode also handles it this way. 1st autocomplete is to complete the keyword - "for" 2nd autocomplete is for the suggestion snippet to write for loop code. @ramsaptami

rishabhrathod01 avatar Aug 11 '22 15:08 rishabhrathod01

/ok-to-test sha=6be19f3

rishabhrathod01 avatar Aug 11 '22 15:08 rishabhrathod01

DP testing has been completed for all scenarios mentioned in the issue description

ramsaptami avatar Aug 11 '22 15:08 ramsaptami

/ok-to-test sha=22c7eba

rishabhrathod01 avatar Aug 11 '22 15:08 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2841110592. Workflow: Appsmith External Integration Test Workflow. Commit: 22c7eba. PR: 15857.

github-actions[bot] avatar Aug 11 '22 15:08 github-actions[bot]

/ok-to-test sha=22c7eba

rishabhrathod01 avatar Aug 11 '22 15:08 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2841281225. Workflow: Appsmith External Integration Test Workflow. Commit: 22c7eba. PR: 15857.

github-actions[bot] avatar Aug 11 '22 16:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2841281225. Commit: 22c7eba. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1075.73 1025.94 1062.45 1093.82 1038.3 1062.45 1059.25 2.60 2.32
painting 10.52 6.32 12.66 5.94 7.53 7.53 8.59 33.76 30.15
rendering 826.38 814.58 813.07 824.12 868.4 824.12 829.31 2.73 2.44
SELECT_WIDGET_SELECT_OPTION
scripting 161.58 170.04 166.12 169.25 236.39 169.25 180.68 17.33 15.51
painting 2.51 8.67 5.33 2.7 3.45 3.45 4.53 56.73 50.77
rendering 302.62 299.88 297.1 304.81 311.24 302.62 303.13 1.77 1.59

github-actions[bot] avatar Aug 11 '22 17:08 github-actions[bot]

/ok-to-test sha=54e2353

rishabhrathod01 avatar Aug 11 '22 17:08 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2841727446. Workflow: Appsmith External Integration Test Workflow. Commit: 54e2353. PR: 15857.

github-actions[bot] avatar Aug 11 '22 17:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2841727446. Commit: 54e2353. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1081.12 1032.94 1048.38 1023.02 1039.48 1039.48 1044.99 2.13 1.90
painting 5.56 5.23 5.79 6.04 10.6 5.79 6.64 33.58 30.12
rendering 824.31 813.98 815.97 812.86 829.31 815.97 819.29 0.88 0.78
SELECT_WIDGET_SELECT_OPTION
scripting 152.85 156.25 178.16 157.21 173.87 157.21 163.67 7.02 6.27
painting 2.33 18.67 6.24 4.21 6.14 6.14 7.52 85.64 76.60
rendering 301.73 308.8 317.82 307.13 303.59 307.13 307.81 2.03 1.82

github-actions[bot] avatar Aug 11 '22 18:08 github-actions[bot]

@ohansFavour will be reviewing the PR. Updating the reviewer list to avoid duplicate effort.

rishabhrathod01 avatar Aug 12 '22 09:08 rishabhrathod01

/ok-to-test sha=be81ed0

rishabhrathod01 avatar Aug 12 '22 16:08 rishabhrathod01

/ok-to-test sha=16356f4

rishabhrathod01 avatar Aug 15 '22 10:08 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2859908122. Workflow: Appsmith External Integration Test Workflow. Commit: 16356f4. PR: 15857.

github-actions[bot] avatar Aug 15 '22 10:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2859908122. Commit: 16356f4. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1072.77 1182.75 1090.2 1156.25 1082.94 1090.2 1116.98 4.41 3.94
painting 9.06 14.77 15.45 6.83 12.64 12.64 11.75 31.57 28.26
rendering 807.01 904.54 820.37 891.05 812.06 820.37 847.01 5.53 4.95
SELECT_WIDGET_SELECT_OPTION
scripting 149.24 150.86 153.74 148 152.91 150.86 150.95 1.60 1.43
painting 9.89 7.11 3.47 5.45 5.09 5.45 6.2 39.19 35.16
rendering 304.32 306.7 313.27 301.61 294.37 304.32 304.05 2.28 2.04

github-actions[bot] avatar Aug 15 '22 10:08 github-actions[bot]

/ok-to-test sha=ef5f94d

rishabhrathod01 avatar Aug 18 '22 09:08 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2881754489. Workflow: Appsmith External Integration Test Workflow. Commit: ef5f94d. PR: 15857.

github-actions[bot] avatar Aug 18 '22 10:08 github-actions[bot]