appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Select default value control

Open Tooluloope opened this issue 3 years ago • 1 comments

Description

Current fix to default value validation dependency in Select widgets

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Test A
  • Test B

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

Tooluloope avatar Aug 09 '22 03:08 Tooluloope

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Aug 17, 2022 at 0:17AM (UTC)

vercel[bot] avatar Aug 09 '22 03:08 vercel[bot]

/ok-to-test sha=cc102df

Tooluloope avatar Aug 10 '22 07:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2830879206. Workflow: Appsmith External Integration Test Workflow. Commit: cc102df. PR: 15856.

github-actions[bot] avatar Aug 10 '22 07:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2830879206. Commit: cc102df. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1048.01 1892.68 1783.53 1167.07 1824.56 1783.53 1543.17 26.04 23.29
painting 12.05 11.13 9.64 11.31 12.6 11.31 11.35 9.87 8.81
rendering 551.58 1155.33 1040.1 603.13 801.84 801.84 830.4 31.85 28.49
SELECT_WIDGET_SELECT_OPTION
scripting 279.72 331.79 313.83 193.37 352.56 313.83 294.25 21.21 18.97
painting 13.45 6.01 9.97 8.93 10.81 9.97 9.83 27.67 24.72
rendering 734.73 656.21 665.26 349.51 718.06 665.26 624.75 25.21 22.55

github-actions[bot] avatar Aug 10 '22 08:08 github-actions[bot]

/ok-to-test sha=e5be299

Tooluloope avatar Aug 11 '22 07:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2838694611. Workflow: Appsmith External Integration Test Workflow. Commit: e5be299. PR: 15856.

github-actions[bot] avatar Aug 11 '22 09:08 github-actions[bot]

  1. There is no immediate error message popups when Default value is removed/changed from Options of Select & Multiselect widget

https://www.loom.com/share/960253da78114a988cb11346de860892

  1. Search becomes case sensitive when Server side filter is enable https://www.loom.com/share/5e4f5ccdb1df4064bff27f608055d7e5

@Tooluloope

chandannkumar avatar Aug 11 '22 09:08 chandannkumar

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2838694611. Commit: e5be299. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1110.81 1129.43 1121.39 1111.02 1036.15 1111.02 1101.76 3.40 3.04
painting 7.19 9.86 6.46 8.65 11.62 8.65 8.76 23.63 21.12
rendering 586.49 595.87 578.36 601.33 545.22 586.49 581.45 3.80 3.40
SELECT_WIDGET_SELECT_OPTION
scripting 172.95 164.37 171.97 169.77 163.61 169.77 168.53 2.56 2.29
painting 2.4 4.97 8.85 7.71 2.02 4.97 5.19 59.15 52.79
rendering 316.88 325.05 320.19 320.97 301.77 320.19 316.97 2.83 2.53

github-actions[bot] avatar Aug 11 '22 10:08 github-actions[bot]

@Tooluloope Added 1 more callout

chandannkumar avatar Aug 11 '22 11:08 chandannkumar

@Tooluloope why is this PR still open?

dilippitchika avatar Aug 15 '22 07:08 dilippitchika

@chandannkumar Please could you open a new Issue for No 1, For No 2 I think you might need to set your Query better to fix it. The filtering for the Widget is done on the server and not in the widget

cc @dilippitchika

Tooluloope avatar Aug 15 '22 11:08 Tooluloope

/ok-to-test sha=0695915

Tooluloope avatar Aug 15 '22 11:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2860313464. Workflow: Appsmith External Integration Test Workflow. Commit: 0695915. PR: 15856.

github-actions[bot] avatar Aug 15 '22 11:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2860313464. Commit: 0695915. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1015.13 1008.11 1027.16 1039.23 1008.11 1015.13 1019.55 1.32 1.18
painting 4.91 10.24 6.67 7.49 10.41 7.49 7.94 29.85 26.70
rendering 525.73 533.87 524.48 549.42 533.03 533.03 533.31 1.86 1.67
SELECT_WIDGET_SELECT_OPTION
scripting 150.73 177.44 143.79 145.92 152.54 150.73 154.08 8.78 7.85
painting 3.33 2.08 3.36 4 4.06 3.36 3.37 23.74 21.07
rendering 306.1 305.27 312.37 304.45 307.52 306.1 307.14 1.02 0.91

github-actions[bot] avatar Aug 15 '22 12:08 github-actions[bot]

/ok-to-test sha=e89c7fa

Tooluloope avatar Aug 16 '22 00:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2864349306. Workflow: Appsmith External Integration Test Workflow. Commit: e89c7fa. PR: 15856.

github-actions[bot] avatar Aug 16 '22 00:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2864349306. Commit: e89c7fa. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 987.25 1017.67 1060.81 1005.12 1018.33 1017.67 1017.84 2.67 2.38
painting 12.51 5.07 11.29 5.79 5.66 5.79 8.06 43.92 39.33
rendering 530.08 537.19 543.91 530.04 567.72 537.19 541.79 2.88 2.57
SELECT_WIDGET_SELECT_OPTION
scripting 147.9 152.27 149.81 180.43 146.45 149.81 155.37 9.13 8.16
painting 6.26 5.71 3.21 2.64 3.34 3.34 4.23 38.53 34.52
rendering 311.49 300.07 295.44 313.58 294.18 300.07 302.95 2.99 2.67

github-actions[bot] avatar Aug 16 '22 00:08 github-actions[bot]

/ok-to-test sha=381f7c2

Tooluloope avatar Aug 16 '22 01:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2864641129. Workflow: Appsmith External Integration Test Workflow. Commit: 381f7c2. PR: 15856.

github-actions[bot] avatar Aug 16 '22 01:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2864641129. Commit: 381f7c2. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1020.38 1036.11 1030.43 1003.76 1076.45 1030.43 1033.43 2.61 2.34
painting 5.51 6.15 5.49 6.34 6.45 6.15 5.99 7.68 6.84
rendering 528.92 543.43 537.08 547.58 548.11 543.43 541.02 1.49 1.34
SELECT_WIDGET_SELECT_OPTION
scripting 167.71 163.75 143.85 167.67 158.01 163.75 160.2 6.22 5.56
painting 2.48 8.55 5.61 15.88 2.86 5.61 7.08 77.54 69.35
rendering 309.07 308.22 306.76 309.37 309.27 309.07 308.54 0.35 0.32

github-actions[bot] avatar Aug 16 '22 02:08 github-actions[bot]

@Tooluloope On copying select & Multiselect widget, the default values seems incomplete in UI but default value works fine without any error

https://www.loom.com/share/0cbfbe17f3494a26a0a060d231518147

chandannkumar avatar Aug 16 '22 06:08 chandannkumar

/ok-to-test sha=1805cee

Tooluloope avatar Aug 16 '22 23:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2871841812. Workflow: Appsmith External Integration Test Workflow. Commit: 1805cee. PR: 15856.

github-actions[bot] avatar Aug 16 '22 23:08 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 17 '22 00:08 github-actions[bot]

/ok-to-test sha=4621a51

Tooluloope avatar Aug 17 '22 09:08 Tooluloope

/ok-to-test sha=bacb74d

Tooluloope avatar Aug 17 '22 09:08 Tooluloope

/ok-to-test sha=22637c4

Tooluloope avatar Aug 17 '22 12:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2875403935. Workflow: Appsmith External Integration Test Workflow. Commit: 22637c4. PR: 15856.

github-actions[bot] avatar Aug 17 '22 13:08 github-actions[bot]

  • Tested this PR on Select & Multi select widget
  • Tested this on older apps as well

Tested this PR and working as expected

chandannkumar avatar Aug 18 '22 06:08 chandannkumar