appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: select default value validation

Open Tooluloope opened this issue 3 years ago • 19 comments

Description

Default Value validation error. The issue here is that options is still a string when defaultValue is validated Here's a screenshot

Screenshot 2022-08-08 at 13 20 46

Fixes #15701

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

Tooluloope avatar Aug 08 '22 12:08 Tooluloope

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 2:10AM (UTC)

vercel[bot] avatar Aug 08 '22 12:08 vercel[bot]

/ok-to-test sha=3c2215e

Tooluloope avatar Aug 09 '22 02:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2822303968. Workflow: Appsmith External Integration Test Workflow. Commit: 3c2215e. PR: 15846.

github-actions[bot] avatar Aug 09 '22 02:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2822303968. Commit: 3c2215e. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1199 1109.59 1056.72 1147.14 1092.03 1109.59 1120.9 4.86 4.35
painting 10.15 10.91 9.57 11.24 14.96 10.91 11.37 18.56 16.62
rendering 943.53 885.91 837.17 878.45 836.48 878.45 876.31 5.02 4.49
SELECT_WIDGET_SELECT_OPTION
scripting 157.57 165.91 176.26 177.67 161.34 165.91 167.75 5.32 4.76
painting 2.91 5.51 3.89 6.94 2.73 3.89 4.4 40.91 36.59
rendering 311.72 315.05 307.28 332.73 307.16 311.72 314.79 3.35 3.00

github-actions[bot] avatar Aug 09 '22 04:08 github-actions[bot]

/ok-to-test sha=9ecb647

Tooluloope avatar Aug 09 '22 09:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2824046739. Workflow: Appsmith External Integration Test Workflow. Commit: 9ecb647. PR: 15846.

github-actions[bot] avatar Aug 09 '22 09:08 github-actions[bot]

Tested this PR on older apps to check the fix and it is working as expected

chandannkumar avatar Aug 09 '22 09:08 chandannkumar

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2824046739. Commit: 9ecb647. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1186.95 1196.94 1167.56 1160.57 1284.85 1186.95 1199.37 4.17 3.73
painting 8.63 8.52 8.67 7.97 16.43 8.63 10.04 35.66 31.87
rendering 890.17 929.83 908.24 883.89 934.22 908.24 909.27 2.49 2.23
SELECT_WIDGET_SELECT_OPTION
scripting 212.29 172.91 150.56 174.14 193.01 174.14 180.58 12.88 11.51
painting 5.64 3.05 8.14 3.21 13.79 5.64 6.77 65.58 58.64
rendering 327.87 320.9 313.42 310.83 319.37 319.37 318.48 2.10 1.88

github-actions[bot] avatar Aug 09 '22 09:08 github-actions[bot]

/ok-to-test sha=8131664

Tooluloope avatar Aug 09 '22 11:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2824932264. Workflow: Appsmith External Integration Test Workflow. Commit: 8131664. PR: 15846.

github-actions[bot] avatar Aug 09 '22 11:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2824932264. Commit: 8131664. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1126.77 1055.55 1079.9 1054.63 1055.85 1055.85 1074.54 2.89 2.59
painting 12.83 6.09 10.59 6.58 12.04 10.59 9.63 32.29 28.97
rendering 827.09 848.96 823.81 829.38 829.45 829.38 831.74 1.19 1.06
SELECT_WIDGET_SELECT_OPTION
scripting 143.77 151.89 155.88 172.31 153.17 153.17 155.4 6.74 6.03
painting 4.75 2.55 4.29 2.43 3.35 3.35 3.47 29.68 26.51
rendering 291.87 311.94 304.22 302.23 303.34 303.34 302.72 2.37 2.12

github-actions[bot] avatar Aug 09 '22 13:08 github-actions[bot]

/ok-to-test sha=0dcd883

Tooluloope avatar Aug 09 '22 15:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2826684205. Workflow: Appsmith External Integration Test Workflow. Commit: 0dcd883. PR: 15846.

github-actions[bot] avatar Aug 09 '22 16:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2826684205. Commit: 0dcd883. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1009.5 1052.81 1023.56 1056.9 1031.4 1031.4 1034.83 1.93 1.72
painting 9.83 12.33 5.26 6.65 10.75 9.83 8.96 32.70 29.24
rendering 787.77 842.93 801.82 826.89 811.94 811.94 814.27 2.64 2.36
SELECT_WIDGET_SELECT_OPTION
scripting 148.48 160.68 144.78 154.94 148.78 148.78 151.53 4.14 3.71
painting 15.03 5.86 3.98 2.3 3.46 3.98 6.13 83.85 75.04
rendering 304.35 295.61 291.33 307.36 295.32 295.61 298.79 2.26 2.02

github-actions[bot] avatar Aug 09 '22 16:08 github-actions[bot]

/ok-to-test sha=81fa0b4

Tooluloope avatar Aug 09 '22 22:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2828676096. Workflow: Appsmith External Integration Test Workflow. Commit: 81fa0b4. PR: 15846.

github-actions[bot] avatar Aug 09 '22 22:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2828676096. Commit: 81fa0b4. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1025.21 1038.81 1016.13 1021.19 1011.11 1021.19 1022.49 1.03 0.92
painting 11.18 5.62 5.36 15.86 11.99 11.18 10 44.80 40.10
rendering 835.52 804.64 808.34 822.21 825.41 822.21 819.22 1.55 1.39
SELECT_WIDGET_SELECT_OPTION
scripting 144.82 156.03 168.77 160.46 162.53 160.46 158.52 5.63 5.03
painting 4.51 9.75 1.94 4.27 7.98 4.51 5.69 55.01 49.21
rendering 305.76 300.28 294.81 306.2 301.22 301.22 301.65 1.54 1.38

github-actions[bot] avatar Aug 09 '22 23:08 github-actions[bot]

/ok-to-test sha=92d40b3

Tooluloope avatar Aug 10 '22 06:08 Tooluloope

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2830545591. Workflow: Appsmith External Integration Test Workflow. Commit: 92d40b3. PR: 15846.

github-actions[bot] avatar Aug 10 '22 06:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2830545591. Commit: 92d40b3. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2056.19 1444.29 2097.7 1087.64 1160.9 1444.29 1569.34 30.74 27.49
painting 12.39 15.38 17.71 18.22 12.96 15.38 15.33 17.35 15.53
rendering 1978.84 1105.94 1481.79 844.3 844.37 1105.94 1251.05 38.64 34.56
SELECT_WIDGET_SELECT_OPTION
scripting 358.93 165.42 251 156.5 150.27 165.42 216.42 41.37 37.01
painting 14.06 4.76 20.27 5.98 5.59 5.98 10.13 67.13 60.02
rendering 740.58 331.36 561.42 301.07 316.66 331.36 450.22 43.14 38.59

github-actions[bot] avatar Aug 10 '22 08:08 github-actions[bot]

/ok-to-test sha=be09ccd

Aishwarya-U-R avatar Aug 10 '22 17:08 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2834364427. Workflow: Appsmith External Integration Test Workflow. Commit: be09ccd. PR: 15846.

github-actions[bot] avatar Aug 10 '22 17:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2834364427. Commit: be09ccd. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1140.9 1101.95 1096.33 1086.87 1157.41 1101.95 1116.69 2.75 2.46
painting 9.16 7.04 6.75 6.78 5.75 6.78 7.1 17.61 15.77
rendering 886.84 851.52 852.4 863.26 847.29 852.4 860.26 1.86 1.66
SELECT_WIDGET_SELECT_OPTION
scripting 157.81 155.86 151.25 243.42 167.48 157.81 175.16 22.04 19.72
painting 3.64 5.95 3.34 2.16 5.4 3.64 4.1 37.80 33.90
rendering 305.95 312.13 301.13 302.9 301.65 302.9 304.75 1.49 1.33

github-actions[bot] avatar Aug 10 '22 17:08 github-actions[bot]

/ok-to-test sha=bb94133

Aishwarya-U-R avatar Aug 11 '22 01:08 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2836800184. Workflow: Appsmith External Integration Test Workflow. Commit: bb94133. PR: 15846.

github-actions[bot] avatar Aug 11 '22 01:08 github-actions[bot]

/ok-to-test sha=5fa9479

Aishwarya-U-R avatar Aug 11 '22 02:08 Aishwarya-U-R

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2836800184. Commit: bb94133. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1049.36 1040.74 1035.79 1067.37 1014.9 1040.74 1041.63 1.84 1.65
painting 12.46 6.39 5.57 6.24 5.9 6.24 7.31 39.67 35.43
rendering 828.89 840.19 810.23 810.56 806.68 810.56 819.31 1.78 1.59
SELECT_WIDGET_SELECT_OPTION
scripting 172.86 163.77 156 147.77 148.92 156 157.86 6.68 5.98
painting 9.35 7.98 3.2 21.94 2.44 7.98 8.98 87.19 77.95
rendering 305.99 337.83 292.9 298.5 297.28 298.5 306.5 5.92 5.29

github-actions[bot] avatar Aug 11 '22 02:08 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2836984087. Workflow: Appsmith External Integration Test Workflow. Commit: 5fa9479. PR: 15846.

github-actions[bot] avatar Aug 11 '22 02:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2836984087. Commit: 5fa9479. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1099.83 1059.83 1045.13 1061.98 1117.05 1061.98 1076.76 2.81 2.51
painting 7.18 6.29 12.82 7.35 5.46 7.18 7.82 37.08 33.12
rendering 857.59 822.08 852.97 825.12 840.55 840.55 839.66 1.90 1.70
SELECT_WIDGET_SELECT_OPTION
scripting 151.84 172.49 160.72 148.54 147.31 151.84 156.18 6.74 6.03
painting 7.7 3.18 2.06 3.67 10.58 3.67 5.44 65.81 58.82
rendering 307.03 298.88 315.41 307.75 310.33 307.75 307.88 1.95 1.74

github-actions[bot] avatar Aug 11 '22 03:08 github-actions[bot]