appsmith
appsmith copied to clipboard
feat: Abort Query Execution
This PR resolves two issues:
- It adds a feature to abort any Action execution via the Action response pane.
- It automatically expands the response pane height when a query is being run.
Fixes #14006 Fixes #15476
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- This change requires a documentation update
Cypress Tests
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
appsmith | ✅ Ready (Inspect) | Visit Preview | Aug 11, 2022 at 1:44PM (UTC) |
Unable to find test scripts. Please add necessary tests to the PR.
Can you also please add Jest/Cypress tests to this PR?
Can you also please add Jest/Cypress tests to this PR?
Of course. PR was still a WIP, hence why I didn't assign a reviewer yet. Thanks for the reviews Arpit!
/ok-to-test sha=60e0a6e
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2826583736.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 60e0a6e
.
PR: 15775.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2826583736.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 60e0a6e
.
PR: 15775.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2826583736.
Commit: 60e0a6e
.
Results: Click to view performance test results
Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
---|---|---|---|---|---|---|---|---|---|
SELECT_WIDGET_MENU_OPEN | |||||||||
scripting | 1062.97 | 1024.76 | 1053 | 1066.05 | 1052.57 | 1053 | 1051.87 | 1.55 | 1.39 |
painting | 13.01 | 10.78 | 5.92 | 5.38 | 11.48 | 10.78 | 9.31 | 37.06 | 33.08 |
rendering | 824.87 | 822.32 | 784.25 | 805.57 | 812.37 | 812.37 | 809.88 | 2.01 | 1.80 |
SELECT_WIDGET_SELECT_OPTION | |||||||||
scripting | 168.77 | 164.29 | 147.89 | 159.85 | 195.47 | 164.29 | 167.25 | 10.52 | 9.41 |
painting | 2.59 | 5.81 | 4.04 | 2.14 | 8.07 | 4.04 | 4.53 | 53.86 | 48.34 |
rendering | 295.72 | 308.86 | 304.09 | 300.45 | 340.94 | 304.09 | 310.01 | 5.79 | 5.18 |
/ok-to-test sha=86baff3
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2832323796.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 86baff3
.
PR: 15775.
/ok-to-test sha=4f3ae93
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2834267777.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 4f3ae93
.
PR: 15775.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2834267777.
Commit: 4f3ae93
.
Results: Click to view performance test results
Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
---|---|---|---|---|---|---|---|---|---|
SELECT_WIDGET_MENU_OPEN | |||||||||
scripting | 1138.16 | 1066.3 | 1072.46 | 1079.51 | 1120.51 | 1079.51 | 1095.39 | 2.92 | 2.61 |
painting | 6.7 | 7.32 | 7.89 | 5.01 | 7.03 | 7.03 | 6.79 | 16.05 | 14.29 |
rendering | 863.68 | 832.71 | 842.99 | 818.23 | 851.12 | 842.99 | 841.75 | 2.06 | 1.84 |
SELECT_WIDGET_SELECT_OPTION | |||||||||
scripting | 154.24 | 172.77 | 164.17 | 172.6 | 178 | 172.6 | 168.36 | 5.54 | 4.95 |
painting | 6.34 | 2.44 | 6.63 | 3.13 | 10.22 | 6.34 | 5.75 | 54.26 | 48.52 |
rendering | 310.04 | 307.59 | 307.63 | 303.39 | 326.68 | 307.63 | 311.07 | 2.91 | 2.60 |
/ok-to-test sha=1216f1e
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2839503792.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 1216f1e
.
PR: 15775.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2839503792.
Commit: 1216f1e
.
Results: Click to view performance test results
Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
---|---|---|---|---|---|---|---|---|---|
SELECT_WIDGET_MENU_OPEN | |||||||||
scripting | 1065.51 | 1039.32 | 1066.48 | 1118.84 | 1136.75 | 1066.48 | 1085.38 | 3.75 | 3.36 |
painting | 5.74 | 7.16 | 8.78 | 6.45 | 14.38 | 7.16 | 8.5 | 40.82 | 36.59 |
rendering | 810.96 | 802.41 | 831.78 | 874.1 | 857.23 | 831.78 | 835.3 | 3.63 | 3.24 |
SELECT_WIDGET_SELECT_OPTION | |||||||||
scripting | 144.61 | 169.23 | 147.68 | 162.23 | 175.89 | 162.23 | 159.93 | 8.45 | 7.56 |
painting | 4.79 | 3.46 | 4.42 | 3.8 | 3.56 | 3.8 | 4.01 | 14.46 | 12.72 |
rendering | 300.74 | 310.54 | 299.59 | 313.74 | 305.98 | 305.98 | 306.12 | 2.00 | 1.78 |
/ok-to-test sha=cb6396e
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2840545027.
Workflow: Appsmith External Integration Test Workflow
.
Commit: cb6396e
.
PR: 15775.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2840545027.
Commit: cb6396e
.
Results: Click to view performance test results
Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
---|---|---|---|---|---|---|---|---|---|
SELECT_WIDGET_MENU_OPEN | |||||||||
scripting | 1018.78 | 1021.91 | 1055.8 | 1128.56 | 1073.1 | 1055.8 | 1059.63 | 4.23 | 3.78 |
painting | 5.9 | 8.75 | 6.13 | 6.39 | 7.2 | 6.39 | 6.87 | 16.89 | 15.14 |
rendering | 809.91 | 777.03 | 831.28 | 883.81 | 835.86 | 831.28 | 827.58 | 4.72 | 4.22 |
SELECT_WIDGET_SELECT_OPTION | |||||||||
scripting | 141.38 | 170.23 | 164.22 | 152.15 | 156.43 | 156.43 | 156.88 | 7.09 | 6.34 |
painting | 5.51 | 9.74 | 3.63 | 9.67 | 2.8 | 5.51 | 6.27 | 52.47 | 46.89 |
rendering | 291.02 | 288.67 | 313.34 | 310.17 | 308.42 | 308.42 | 302.32 | 3.82 | 3.42 |